Bump spotbugs gradle plugin to 6.4.5 #9748

bric3 · 2025-10-14T11:51:25Z

What Does This Do

This PR bumps spotbugs gradle plugin to the most recent version 6.4.5 to this day (from 5.0.14).
And require a JDK 11 minimum to run.

Important

This version of spotbugs has new rules, better detection engine that requires to change so of the warnings ignores, or fix some code.

Motivation

Latest tools provide more value.

Additional Notes

Need

Enforce a JDK 21 to run Gradle #9747

Related to

Bump spotless to latest version 8.0.0 #9881

…internal-api Also this forces JDK 11 to be the minimum.

# Conflicts: # communication/src/main/java/datadog/communication/ddagent/SharedCommunicationObjects.java # utils/test-utils/src/main/groovy/datadog/trace/test/util/DDSpecification.groovy

…ed-jdk11-min

pr-commenter · 2025-10-22T19:00:01Z

Debugger benchmarks

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
ci_job_date	1761158916	1761159261
end_time	2025-10-22T18:49:57	2025-10-22T18:55:42
git_branch	master	bdu/spotbugs-bump-need-jdk11-min
git_commit_sha	`cd02b0c`	`9510177`
start_time	2025-10-22T18:48:37	2025-10-22T18:54:22

See matching parameters

	Baseline	Candidate
ci_job_id	1192513899	1192513899
ci_pipeline_id	80010032	80010032
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
git_commit_date	1761158377	1761158377

Summary

Found 3 performance improvements and 0 performance regressions! Performance is the same for 6 metrics, 6 unstable metrics.

scenario	Δ mean agg_http_req_duration_min	Δ mean agg_http_req_duration_p50	Δ mean agg_http_req_duration_p75	Δ mean agg_http_req_duration_p99	Δ mean throughput
scenario:basic	better [-14.309µs; -6.015µs] or [-5.510%; -2.316%]	better [-19.256µs; -5.767µs] or [-6.587%; -1.973%]	better [-21.062µs; -6.324µs] or [-6.950%; -2.087%]	unstable [-110.275µs; +75.660µs] or [-14.924%; +10.240%]	unstable [-103.234op/s; +238.187op/s] or [-4.026%; +9.289%]

See unchanged results

scenario	Δ mean agg_http_req_duration_min	Δ mean agg_http_req_duration_p50	Δ mean agg_http_req_duration_p75	Δ mean agg_http_req_duration_p99	Δ mean throughput
scenario:noprobe	unstable [-29.139µs; +38.019µs] or [-10.298%; +13.436%]	unstable [-39.129µs; +56.811µs] or [-12.119%; +17.596%]	unstable [-52.309µs; +68.098µs] or [-15.429%; +20.086%]	unstable [-97.837µs; +162.812µs] or [-10.667%; +17.751%]	same
scenario:loop	unsure [+0.300µs; +7.587µs] or [+0.003%; +0.086%]	same	unsure [+14.301µs; +23.957µs] or [+0.159%; +0.266%]	same	same

Request duration reports for reports

gantt
    title reports - request duration [CI 0.99] : candidate=None, baseline=None
    dateFormat X
    axisFormat %s
section baseline
noprobe (322.865 µs) : 284, 362
.   : milestone, 323,
basic (292.34 µs) : 286, 299
.   : milestone, 292,
loop (8.956 ms) : 8953, 8959
.   : milestone, 8956,
section candidate
noprobe (331.706 µs) : 280, 383
.   : milestone, 332,
basic (279.828 µs) : 273, 286
.   : milestone, 280,
loop (8.956 ms) : 8950, 8962
.   : milestone, 8956,

baseline results

Scenario	Request median duration [CI 0.99]
noprobe	322.865 µs [284.107 µs, 361.623 µs]
basic	292.34 µs [285.672 µs, 299.007 µs]
loop	8.956 ms [8.953 ms, 8.959 ms]

candidate results

Scenario	Request median duration [CI 0.99]
noprobe	331.706 µs [280.047 µs, 383.365 µs]
basic	279.828 µs [273.292 µs, 286.365 µs]
loop	8.956 ms [8.95 ms, 8.962 ms]

pr-commenter · 2025-10-22T19:13:21Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	bdu/spotbugs-bump-need-jdk11-min
git_commit_date	1763992896	1764019878
git_commit_sha	`c8bb444`	`dd1b15c`
release_version	1.57.0-SNAPSHOT~c8bb44440b	1.55.0-SNAPSHOT~dd1b15c0c7

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1764022161	1764022161
ci_job_id	1254697034	1254697034
ci_pipeline_id	83867756	83867756
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-0-ykrc9hw4 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-0-ykrc9hw4 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module	Agent	Agent
parent	None	None

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 61 metrics, 4 unstable metrics.

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.55.0-SNAPSHOT~dd1b15c0c7, baseline=1.57.0-SNAPSHOT~c8bb44440b

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.101 s) : 0, 1101113
Total [baseline] (10.771 s) : 0, 10771439
Agent [candidate] (1.11 s) : 0, 1110025
Total [candidate] (10.829 s) : 0, 10829073
section appsec
Agent [baseline] (1.29 s) : 0, 1290019
Total [baseline] (11.098 s) : 0, 11098426
Agent [candidate] (1.291 s) : 0, 1291255
Total [candidate] (11.105 s) : 0, 11104704
section iast
Agent [baseline] (1.241 s) : 0, 1241111
Total [baseline] (11.233 s) : 0, 11233484
Agent [candidate] (1.251 s) : 0, 1250527
Total [candidate] (11.166 s) : 0, 11166461
section profiling
Agent [baseline] (1.234 s) : 0, 1234271
Total [baseline] (11.132 s) : 0, 11131579
Agent [candidate] (1.233 s) : 0, 1232840
Total [candidate] (11.081 s) : 0, 11081449

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.101 s	-
Agent	appsec	1.29 s	188.906 ms (17.2%)
Agent	iast	1.241 s	139.997 ms (12.7%)
Agent	profiling	1.234 s	133.158 ms (12.1%)
Total	tracing	10.771 s	-
Total	appsec	11.098 s	326.987 ms (3.0%)
Total	iast	11.233 s	462.045 ms (4.3%)
Total	profiling	11.132 s	360.14 ms (3.3%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.11 s	-
Agent	appsec	1.291 s	181.23 ms (16.3%)
Agent	iast	1.251 s	140.502 ms (12.7%)
Agent	profiling	1.233 s	122.814 ms (11.1%)
Total	tracing	10.829 s	-
Total	appsec	11.105 s	275.631 ms (2.5%)
Total	iast	11.166 s	337.387 ms (3.1%)
Total	profiling	11.081 s	252.375 ms (2.3%)

gantt
    title petclinic - break down per module: candidate=1.55.0-SNAPSHOT~dd1b15c0c7, baseline=1.57.0-SNAPSHOT~c8bb44440b

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.478 ms) : 0, 1478
crashtracking [candidate] (1.485 ms) : 0, 1485
BytebuddyAgent [baseline] (708.062 ms) : 0, 708062
BytebuddyAgent [candidate] (713.204 ms) : 0, 713204
GlobalTracer [baseline] (248.461 ms) : 0, 248461
GlobalTracer [candidate] (250.786 ms) : 0, 250786
AppSec [baseline] (31.773 ms) : 0, 31773
AppSec [candidate] (32.423 ms) : 0, 32423
Debugger [baseline] (64.038 ms) : 0, 64038
Debugger [candidate] (64.482 ms) : 0, 64482
Remote Config [baseline] (623.057 µs) : 0, 623
Remote Config [candidate] (633.803 µs) : 0, 634
Telemetry [baseline] (8.196 ms) : 0, 8196
Telemetry [candidate] (8.335 ms) : 0, 8335
Flare Poller [baseline] (3.658 ms) : 0, 3658
Flare Poller [candidate] (3.725 ms) : 0, 3725
section appsec
crashtracking [baseline] (1.483 ms) : 0, 1483
crashtracking [candidate] (1.486 ms) : 0, 1486
BytebuddyAgent [baseline] (737.711 ms) : 0, 737711
BytebuddyAgent [candidate] (737.684 ms) : 0, 737684
GlobalTracer [baseline] (242.564 ms) : 0, 242564
GlobalTracer [candidate] (242.817 ms) : 0, 242817
AppSec [baseline] (173.787 ms) : 0, 173787
AppSec [candidate] (174.333 ms) : 0, 174333
Debugger [baseline] (61.468 ms) : 0, 61468
Debugger [candidate] (61.827 ms) : 0, 61827
Remote Config [baseline] (682.388 µs) : 0, 682
Remote Config [candidate] (681.719 µs) : 0, 682
Telemetry [baseline] (8.261 ms) : 0, 8261
Telemetry [candidate] (8.258 ms) : 0, 8258
Flare Poller [baseline] (4.013 ms) : 0, 4013
Flare Poller [candidate] (3.951 ms) : 0, 3951
IAST [baseline] (24.97 ms) : 0, 24970
IAST [candidate] (25.227 ms) : 0, 25227
section iast
crashtracking [baseline] (1.5 ms) : 0, 1500
crashtracking [candidate] (1.498 ms) : 0, 1498
BytebuddyAgent [baseline] (833.182 ms) : 0, 833182
BytebuddyAgent [candidate] (840.005 ms) : 0, 840005
GlobalTracer [baseline] (237.608 ms) : 0, 237608
GlobalTracer [candidate] (238.951 ms) : 0, 238951
AppSec [baseline] (33.209 ms) : 0, 33209
AppSec [candidate] (33.41 ms) : 0, 33410
Debugger [baseline] (60.587 ms) : 0, 60587
Debugger [candidate] (61.041 ms) : 0, 61041
Remote Config [baseline] (549.862 µs) : 0, 550
Remote Config [candidate] (546.659 µs) : 0, 547
Telemetry [baseline] (7.645 ms) : 0, 7645
Telemetry [candidate] (7.662 ms) : 0, 7662
Flare Poller [baseline] (3.555 ms) : 0, 3555
Flare Poller [candidate] (3.494 ms) : 0, 3494
IAST [baseline] (28.505 ms) : 0, 28505
IAST [candidate] (28.842 ms) : 0, 28842
section profiling
crashtracking [baseline] (1.432 ms) : 0, 1432
crashtracking [candidate] (1.431 ms) : 0, 1431
BytebuddyAgent [baseline] (735.428 ms) : 0, 735428
BytebuddyAgent [candidate] (737.388 ms) : 0, 737388
GlobalTracer [baseline] (223.124 ms) : 0, 223124
GlobalTracer [candidate] (222.042 ms) : 0, 222042
AppSec [baseline] (32.426 ms) : 0, 32426
AppSec [candidate] (32.132 ms) : 0, 32132
Debugger [baseline] (63.054 ms) : 0, 63054
Debugger [candidate] (62.704 ms) : 0, 62704
Remote Config [baseline] (642.453 µs) : 0, 642
Remote Config [candidate] (649.437 µs) : 0, 649
Telemetry [baseline] (8.015 ms) : 0, 8015
Telemetry [candidate] (8.004 ms) : 0, 8004
Flare Poller [baseline] (3.774 ms) : 0, 3774
Flare Poller [candidate] (3.71 ms) : 0, 3710
ProfilingAgent [baseline] (97.232 ms) : 0, 97232
ProfilingAgent [candidate] (95.837 ms) : 0, 95837
Profiling [baseline] (97.831 ms) : 0, 97831
Profiling [candidate] (96.418 ms) : 0, 96418

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.55.0-SNAPSHOT~dd1b15c0c7, baseline=1.57.0-SNAPSHOT~c8bb44440b

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.105 s) : 0, 1104882
Total [baseline] (8.854 s) : 0, 8853892
Agent [candidate] (1.111 s) : 0, 1111214
Total [candidate] (8.839 s) : 0, 8839387
section iast
Agent [baseline] (1.248 s) : 0, 1248214
Total [baseline] (9.559 s) : 0, 9559135
Agent [candidate] (1.237 s) : 0, 1237146
Total [candidate] (9.542 s) : 0, 9542090

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.105 s	-
Agent	iast	1.248 s	143.332 ms (13.0%)
Total	tracing	8.854 s	-
Total	iast	9.559 s	705.243 ms (8.0%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.111 s	-
Agent	iast	1.237 s	125.933 ms (11.3%)
Total	tracing	8.839 s	-
Total	iast	9.542 s	702.703 ms (7.9%)

gantt
    title insecure-bank - break down per module: candidate=1.55.0-SNAPSHOT~dd1b15c0c7, baseline=1.57.0-SNAPSHOT~c8bb44440b

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.5 ms) : 0, 1500
crashtracking [candidate] (1.486 ms) : 0, 1486
BytebuddyAgent [baseline] (712.204 ms) : 0, 712204
BytebuddyAgent [candidate] (715.511 ms) : 0, 715511
GlobalTracer [baseline] (248.655 ms) : 0, 248655
GlobalTracer [candidate] (251.337 ms) : 0, 251337
AppSec [baseline] (31.946 ms) : 0, 31946
AppSec [candidate] (32.272 ms) : 0, 32272
Debugger [baseline] (63.273 ms) : 0, 63273
Debugger [candidate] (63.108 ms) : 0, 63108
Remote Config [baseline] (625.018 µs) : 0, 625
Remote Config [candidate] (630.326 µs) : 0, 630
Telemetry [baseline] (8.162 ms) : 0, 8162
Telemetry [candidate] (8.26 ms) : 0, 8260
Flare Poller [baseline] (3.668 ms) : 0, 3668
Flare Poller [candidate] (3.693 ms) : 0, 3693
section iast
crashtracking [baseline] (1.496 ms) : 0, 1496
crashtracking [candidate] (1.463 ms) : 0, 1463
BytebuddyAgent [baseline] (839.293 ms) : 0, 839293
BytebuddyAgent [candidate] (831.335 ms) : 0, 831335
GlobalTracer [baseline] (238.541 ms) : 0, 238541
GlobalTracer [candidate] (236.991 ms) : 0, 236991
AppSec [baseline] (33.32 ms) : 0, 33320
AppSec [candidate] (33.019 ms) : 0, 33019
Debugger [baseline] (60.101 ms) : 0, 60101
Debugger [candidate] (59.841 ms) : 0, 59841
Remote Config [baseline] (544.772 µs) : 0, 545
Remote Config [candidate] (546.605 µs) : 0, 547
Telemetry [baseline] (7.555 ms) : 0, 7555
Telemetry [candidate] (7.566 ms) : 0, 7566
Flare Poller [baseline] (3.43 ms) : 0, 3430
Flare Poller [candidate] (3.373 ms) : 0, 3373
IAST [baseline] (28.958 ms) : 0, 28958
IAST [candidate] (28.214 ms) : 0, 28214

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	bdu/spotbugs-bump-need-jdk11-min
git_commit_date	1763992896	1764019878
git_commit_sha	`c8bb444`	`dd1b15c`
release_version	1.57.0-SNAPSHOT~c8bb44440b	1.55.0-SNAPSHOT~dd1b15c0c7

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1764022654	1764022654
ci_job_id	1254697035	1254697035
ci_pipeline_id	83867756	83867756
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-1-tt6dq230 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-1-tt6dq230 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 2 performance regressions! Performance is the same for 18 metrics, 16 unstable metrics.

scenario	Δ mean agg_http_req_duration_p50	Δ mean agg_http_req_duration_p95	Δ mean throughput	candidate mean agg_http_req_duration_p50	candidate mean agg_http_req_duration_p95	candidate mean throughput	baseline mean agg_http_req_duration_p50	baseline mean agg_http_req_duration_p95	baseline mean throughput
scenario:load:insecure-bank:iast_GLOBAL:high_load	worse [+232.899µs; +362.841µs] or [+8.450%; +13.164%]	worse [+423.522µs; +930.420µs] or [+5.371%; +11.800%]	unstable [-237.510op/s; +19.072op/s] or [-18.200%; +1.461%]	3.054ms	8.562ms	1195.781op/s	2.756ms	7.885ms	1305.000op/s

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~dd1b15c0c7, baseline=1.57.0-SNAPSHOT~c8bb44440b
    dateFormat X
    axisFormat %s
section baseline
no_agent (18.156 ms) : 17969, 18344
.   : milestone, 18156,
appsec (18.9 ms) : 18712, 19089
.   : milestone, 18900,
code_origins (17.858 ms) : 17682, 18035
.   : milestone, 17858,
iast (17.956 ms) : 17778, 18134
.   : milestone, 17956,
profiling (18.71 ms) : 18525, 18894
.   : milestone, 18710,
tracing (17.969 ms) : 17791, 18148
.   : milestone, 17969,
section candidate
no_agent (18.33 ms) : 18139, 18520
.   : milestone, 18330,
appsec (18.757 ms) : 18571, 18944
.   : milestone, 18757,
code_origins (17.826 ms) : 17652, 18000
.   : milestone, 17826,
iast (17.881 ms) : 17702, 18060
.   : milestone, 17881,
profiling (18.517 ms) : 18330, 18703
.   : milestone, 18517,
tracing (17.841 ms) : 17664, 18018
.   : milestone, 17841,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	18.156 ms [17.969 ms, 18.344 ms]	-
appsec	18.9 ms [18.712 ms, 19.089 ms]	744.029 µs (4.1%)
code_origins	17.858 ms [17.682 ms, 18.035 ms]	-298.053 µs (-1.6%)
iast	17.956 ms [17.778 ms, 18.134 ms]	-200.603 µs (-1.1%)
profiling	18.71 ms [18.525 ms, 18.894 ms]	553.294 µs (3.0%)
tracing	17.969 ms [17.791 ms, 18.148 ms]	-186.996 µs (-1.0%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	18.33 ms [18.139 ms, 18.52 ms]	-
appsec	18.757 ms [18.571 ms, 18.944 ms]	427.571 µs (2.3%)
code_origins	17.826 ms [17.652 ms, 18.0 ms]	-503.183 µs (-2.7%)
iast	17.881 ms [17.702 ms, 18.06 ms]	-448.374 µs (-2.4%)
profiling	18.517 ms [18.33 ms, 18.703 ms]	187.093 µs (1.0%)
tracing	17.841 ms [17.664 ms, 18.018 ms]	-488.809 µs (-2.7%)

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~dd1b15c0c7, baseline=1.57.0-SNAPSHOT~c8bb44440b
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.206 ms) : 1193, 1218
.   : milestone, 1206,
iast (3.335 ms) : 3287, 3384
.   : milestone, 3335,
iast_FULL (5.895 ms) : 5837, 5954
.   : milestone, 5895,
iast_GLOBAL (3.513 ms) : 3461, 3564
.   : milestone, 3513,
profiling (2.062 ms) : 2045, 2080
.   : milestone, 2062,
tracing (1.882 ms) : 1866, 1898
.   : milestone, 1882,
section candidate
no_agent (1.196 ms) : 1185, 1208
.   : milestone, 1196,
iast (3.327 ms) : 3275, 3379
.   : milestone, 3327,
iast_FULL (5.809 ms) : 5751, 5867
.   : milestone, 5809,
iast_GLOBAL (3.84 ms) : 3783, 3898
.   : milestone, 3840,
profiling (2.22 ms) : 2200, 2240
.   : milestone, 2220,
tracing (1.952 ms) : 1934, 1969
.   : milestone, 1952,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.206 ms [1.193 ms, 1.218 ms]	-
iast	3.335 ms [3.287 ms, 3.384 ms]	2.13 ms (176.6%)
iast_FULL	5.895 ms [5.837 ms, 5.954 ms]	4.689 ms (388.9%)
iast_GLOBAL	3.513 ms [3.461 ms, 3.564 ms]	2.307 ms (191.3%)
profiling	2.062 ms [2.045 ms, 2.08 ms]	856.618 µs (71.0%)
tracing	1.882 ms [1.866 ms, 1.898 ms]	675.992 µs (56.1%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.196 ms [1.185 ms, 1.208 ms]	-
iast	3.327 ms [3.275 ms, 3.379 ms]	2.131 ms (178.1%)
iast_FULL	5.809 ms [5.751 ms, 5.867 ms]	4.612 ms (385.5%)
iast_GLOBAL	3.84 ms [3.783 ms, 3.898 ms]	2.644 ms (221.0%)
profiling	2.22 ms [2.2 ms, 2.24 ms]	1.024 ms (85.6%)
tracing	1.952 ms [1.934 ms, 1.969 ms]	755.354 µs (63.1%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	bdu/spotbugs-bump-need-jdk11-min
git_commit_date	1763992896	1764019878
git_commit_sha	`c8bb444`	`dd1b15c`
release_version	1.57.0-SNAPSHOT~c8bb44440b	1.55.0-SNAPSHOT~dd1b15c0c7

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1764022315	1764022315
ci_job_id	1254697036	1254697036
ci_pipeline_id	83867756	83867756
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-0-9zbamamq 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-0-9zbamamq 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 1 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 0 unstable metrics.

scenario	Δ mean execution_time	candidate mean execution_time	baseline mean execution_time
scenario:dacapo:tomcat:appsec	better [-1.351ms; -1.008ms] or [-36.596%; -27.306%]	2.512ms	3.691ms

Execution time for tomcat

gantt
    title tomcat - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~dd1b15c0c7, baseline=1.57.0-SNAPSHOT~c8bb44440b
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.47 ms) : 1459, 1482
.   : milestone, 1470,
appsec (3.691 ms) : 3472, 3910
.   : milestone, 3691,
iast (2.202 ms) : 2138, 2266
.   : milestone, 2202,
iast_GLOBAL (2.249 ms) : 2184, 2314
.   : milestone, 2249,
profiling (2.089 ms) : 2035, 2144
.   : milestone, 2089,
tracing (2.047 ms) : 1996, 2098
.   : milestone, 2047,
section candidate
no_agent (1.471 ms) : 1460, 1483
.   : milestone, 1471,
appsec (2.512 ms) : 2457, 2566
.   : milestone, 2512,
iast (2.201 ms) : 2137, 2265
.   : milestone, 2201,
iast_GLOBAL (2.251 ms) : 2186, 2316
.   : milestone, 2251,
profiling (2.066 ms) : 2014, 2118
.   : milestone, 2066,
tracing (2.035 ms) : 1985, 2086
.   : milestone, 2035,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.47 ms [1.459 ms, 1.482 ms]	-
appsec	3.691 ms [3.472 ms, 3.91 ms]	2.221 ms (151.1%)
iast	2.202 ms [2.138 ms, 2.266 ms]	732.128 µs (49.8%)
iast_GLOBAL	2.249 ms [2.184 ms, 2.314 ms]	779.126 µs (53.0%)
profiling	2.089 ms [2.035 ms, 2.144 ms]	619.336 µs (42.1%)
tracing	2.047 ms [1.996 ms, 2.098 ms]	576.98 µs (39.2%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.471 ms [1.46 ms, 1.483 ms]	-
appsec	2.512 ms [2.457 ms, 2.566 ms]	1.04 ms (70.7%)
iast	2.201 ms [2.137 ms, 2.265 ms]	730.119 µs (49.6%)
iast_GLOBAL	2.251 ms [2.186 ms, 2.316 ms]	780.128 µs (53.0%)
profiling	2.066 ms [2.014 ms, 2.118 ms]	594.925 µs (40.4%)
tracing	2.035 ms [1.985 ms, 2.086 ms]	564.251 µs (38.4%)

Execution time for biojava

gantt
    title biojava - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~dd1b15c0c7, baseline=1.57.0-SNAPSHOT~c8bb44440b
    dateFormat X
    axisFormat %s
section baseline
no_agent (14.964 s) : 14964000, 14964000
.   : milestone, 14964000,
appsec (14.809 s) : 14809000, 14809000
.   : milestone, 14809000,
iast (18.148 s) : 18148000, 18148000
.   : milestone, 18148000,
iast_GLOBAL (17.943 s) : 17943000, 17943000
.   : milestone, 17943000,
profiling (14.65 s) : 14650000, 14650000
.   : milestone, 14650000,
tracing (14.813 s) : 14813000, 14813000
.   : milestone, 14813000,
section candidate
no_agent (15.019 s) : 15019000, 15019000
.   : milestone, 15019000,
appsec (14.83 s) : 14830000, 14830000
.   : milestone, 14830000,
iast (18.32 s) : 18320000, 18320000
.   : milestone, 18320000,
iast_GLOBAL (17.886 s) : 17886000, 17886000
.   : milestone, 17886000,
profiling (14.671 s) : 14671000, 14671000
.   : milestone, 14671000,
tracing (14.868 s) : 14868000, 14868000
.   : milestone, 14868000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	14.964 s [14.964 s, 14.964 s]	-
appsec	14.809 s [14.809 s, 14.809 s]	-155.0 ms (-1.0%)
iast	18.148 s [18.148 s, 18.148 s]	3.184 s (21.3%)
iast_GLOBAL	17.943 s [17.943 s, 17.943 s]	2.979 s (19.9%)
profiling	14.65 s [14.65 s, 14.65 s]	-314.0 ms (-2.1%)
tracing	14.813 s [14.813 s, 14.813 s]	-151.0 ms (-1.0%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.019 s [15.019 s, 15.019 s]	-
appsec	14.83 s [14.83 s, 14.83 s]	-189.0 ms (-1.3%)
iast	18.32 s [18.32 s, 18.32 s]	3.301 s (22.0%)
iast_GLOBAL	17.886 s [17.886 s, 17.886 s]	2.867 s (19.1%)
profiling	14.671 s [14.671 s, 14.671 s]	-348.0 ms (-2.3%)
tracing	14.868 s [14.868 s, 14.868 s]	-151.0 ms (-1.0%)

# Conflicts: # gradle/libs.versions.toml

PerfectSlayer

💭 thought: ‏The title is a bit misleading, it seems to be more like a migration than a dependency bump.
As the PR grew a lot, should we split in some way to get product / team approval seperately?

bric3 · 2025-11-24T16:11:55Z

The title is a bit misleading, it seems to be more like a migration than a dependency bump.
As the PR grew a lot, should we split in some way to get product / team approval seperately?

The bump triggered these code updates 😭 (due to updated spotbugs engine).

amarziali · 2025-11-25T14:07:24Z

...t-ci-visibility/src/main/java/datadog/trace/civisibility/execution/RetryUntilSuccessful.java

  private final boolean suppressFailures;
-  private int executions;
-  private boolean successfulExecutionSeen;
+  private final AtomicInteger executions = new AtomicInteger(0);


why those changes should be related to bumping a pluging?

tl;dr New spotbugs engine

#9748 (comment)

Yes but I won't expect needing a code change because we're upgrading a plugin version. They don't have the same semantic

That's the thing spotbugs now identifies this as an issue in this code and as such fails in CI, like in other places this is what I thought was a fix.

But as discussed Monday. We can instead ignore the n'es spotted issues.

Whether an suppress Annotation or code change, this file will be modified.

bric3 added 3 commits October 14, 2025 11:23

build: Enforce a JDK 21 to run Gradle

cb81424

fix: SpotBugs needs 6.4.2 to run after JDK11, relax forbiddenApis on …

ca82eea

…internal-api Also this forces JDK 11 to be the minimum.

fix: Try fixing spotted bugs

88ef442

# Conflicts: # communication/src/main/java/datadog/communication/ddagent/SharedCommunicationObjects.java # utils/test-utils/src/main/groovy/datadog/trace/test/util/DDSpecification.groovy

bric3 added tag: do not merge Do not merge changes tag: no release notes Changes to exclude from release notes comp: tooling Build & Tooling labels Oct 14, 2025

Merge branch 'bdu/test-decoupling-on-jdk21' into bdu/spotbugs-bump-ne…

9510177

…ed-jdk11-min

AlexeyKuznetsov-DD added 2 commits October 23, 2025 12:34

Merged with master.

095d027

Made latest SpotBugs passing.

aae1e80

This comment has been minimized.

Sign in to view

Cleanup classpath to resolve JUnit5 versions conflict.

e4a8703

AlexeyKuznetsov-DD changed the title ~~Bump spotbugs gradle plugin to 6.4.2~~ Bump spotbugs gradle plugin to 6.4.4 Oct 24, 2025

AlexeyKuznetsov-DD changed the base branch from bdu/test-decoupling-on-jdk21 to master October 24, 2025 00:39

AlexeyKuznetsov-DD added 9 commits October 23, 2025 20:55

Cleanup classpath to resolve JUnit5 versions conflict.

261aea6

Exclude logback.

b5f246e

Merge branch 'master' into bdu/spotbugs-bump-need-jdk11-min

03ac8e4

Fixed failed log4j test.

308bca2

Merge branch 'master' into bdu/spotbugs-bump-need-jdk11-min

b4b8e64

Merge branch 'master' into bdu/spotbugs-bump-need-jdk11-min

6eceae4

Merge branch 'master' into bdu/spotbugs-bump-need-jdk11-min

51c0d79

Removed not relevant props

75bdff2

Merge branch 'master' into bdu/spotbugs-bump-need-jdk11-min

99153b9

# Conflicts: # gradle/libs.versions.toml

AlexeyKuznetsov-DD marked this pull request as ready for review November 11, 2025 01:56

AlexeyKuznetsov-DD requested review from a team as code owners November 11, 2025 01:56

AlexeyKuznetsov-DD requested review from daniel-mohedano, dougqh, manuel-alvarez-alvarez, mhlidd and robertpi and removed request for a team November 11, 2025 01:56

AlexeyKuznetsov-DD added 2 commits November 11, 2025 18:50

Merge branch 'master' into bdu/spotbugs-bump-need-jdk11-min

1ddcaf3

Merge branch 'master' into bdu/spotbugs-bump-need-jdk11-min

59e939e

bric3 mentioned this pull request Nov 13, 2025

Drop fromEnv toolchain restriction for local environment #9950

Merged

AlexeyKuznetsov-DD added 3 commits November 13, 2025 11:50

Merge branch 'master' into bdu/spotbugs-bump-need-jdk11-min

095b160

Merge branch 'master' into bdu/spotbugs-bump-need-jdk11-min

cb6d41d

Bump to 6.4.5

f8554c1

AlexeyKuznetsov-DD changed the title ~~Bump spotbugs gradle plugin to 6.4.4~~ Bump spotbugs gradle plugin to 6.4.5 Nov 17, 2025

AlexeyKuznetsov-DD added 2 commits November 17, 2025 15:02

Merge branch 'master' into bdu/spotbugs-bump-need-jdk11-min

516bec0

Merge branch 'master' into bdu/spotbugs-bump-need-jdk11-min

047068e

AlexeyKuznetsov-DD requested review from PerfectSlayer, amarziali and mcculls November 20, 2025 22:39

Merge branch 'master' into bdu/spotbugs-bump-need-jdk11-min

0e4993f

PerfectSlayer reviewed Nov 21, 2025

View reviewed changes

Merge branch 'master' into bdu/spotbugs-bump-need-jdk11-min

1eb01c1

Merge branch 'master' into bdu/spotbugs-bump-need-jdk11-min

dd1b15c

AlexeyKuznetsov-DD mentioned this pull request Nov 24, 2025

Replaced code changes with @SuppressFBWarnings annotations. #10025

Open

amarziali reviewed Nov 25, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Bump spotbugs gradle plugin to 6.4.5 #9748

Bump spotbugs gradle plugin to 6.4.5 #9748

Uh oh!

bric3 commented Oct 14, 2025 •

edited

Loading

Uh oh!

pr-commenter bot commented Oct 22, 2025

Uh oh!

pr-commenter bot commented Oct 22, 2025 •

edited

Loading

Uh oh!

This comment has been minimized.

PerfectSlayer left a comment

Uh oh!

bric3 commented Nov 24, 2025

Uh oh!

amarziali Nov 25, 2025

Uh oh!

bric3 Nov 25, 2025

Uh oh!

amarziali Nov 25, 2025

Uh oh!

bric3 Nov 25, 2025 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Bump spotbugs gradle plugin to 6.4.5 #9748

Are you sure you want to change the base?

Bump spotbugs gradle plugin to 6.4.5 #9748

Uh oh!

Conversation

bric3 commented Oct 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What Does This Do

Motivation

Additional Notes

Uh oh!

pr-commenter bot commented Oct 22, 2025

Debugger benchmarks

Parameters

Summary

Uh oh!

pr-commenter bot commented Oct 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

Uh oh!

This comment has been minimized.

PerfectSlayer left a comment

Choose a reason for hiding this comment

Uh oh!

bric3 commented Nov 24, 2025

Uh oh!

amarziali Nov 25, 2025

Choose a reason for hiding this comment

Uh oh!

bric3 Nov 25, 2025

Choose a reason for hiding this comment

Uh oh!

amarziali Nov 25, 2025

Choose a reason for hiding this comment

Uh oh!

bric3 Nov 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

bric3 commented Oct 14, 2025 •

edited

Loading

pr-commenter bot commented Oct 22, 2025 •

edited

Loading

bric3 Nov 25, 2025 •

edited

Loading