-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip spotless on check_* jobs #8101
base: master
Are you sure you want to change the base?
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 52 metrics, 11 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.45.0-SNAPSHOT~f9d1ad1ff8, baseline=1.45.0-SNAPSHOT~772d178d64
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.093 s) : 0, 1093441
Total [baseline] (10.511 s) : 0, 10511311
Agent [candidate] (1.101 s) : 0, 1100878
Total [candidate] (10.548 s) : 0, 10547999
section appsec
Agent [baseline] (1.231 s) : 0, 1230942
Total [baseline] (10.736 s) : 0, 10736046
Agent [candidate] (1.228 s) : 0, 1228156
Total [candidate] (10.755 s) : 0, 10755305
section iast
Agent [baseline] (1.228 s) : 0, 1228184
Total [baseline] (10.979 s) : 0, 10979331
Agent [candidate] (1.223 s) : 0, 1223166
Total [candidate] (11.077 s) : 0, 11077118
section profiling
Agent [baseline] (1.318 s) : 0, 1317560
Total [baseline] (10.873 s) : 0, 10872639
Agent [candidate] (1.326 s) : 0, 1325770
Total [candidate] (10.855 s) : 0, 10855196
gantt
title petclinic - break down per module: candidate=1.45.0-SNAPSHOT~f9d1ad1ff8, baseline=1.45.0-SNAPSHOT~772d178d64
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (695.246 ms) : 0, 695246
BytebuddyAgent [candidate] (700.888 ms) : 0, 700888
GlobalTracer [baseline] (317.45 ms) : 0, 317450
GlobalTracer [candidate] (319.583 ms) : 0, 319583
AppSec [baseline] (54.328 ms) : 0, 54328
AppSec [candidate] (54.621 ms) : 0, 54621
Remote Config [baseline] (673.104 µs) : 0, 673
Remote Config [candidate] (695.207 µs) : 0, 695
Telemetry [baseline] (11.992 ms) : 0, 11992
Telemetry [candidate] (11.24 ms) : 0, 11240
section appsec
BytebuddyAgent [baseline] (716.544 ms) : 0, 716544
BytebuddyAgent [candidate] (713.742 ms) : 0, 713742
GlobalTracer [baseline] (315.167 ms) : 0, 315167
GlobalTracer [candidate] (314.519 ms) : 0, 314519
AppSec [baseline] (167.726 ms) : 0, 167726
AppSec [candidate] (166.995 ms) : 0, 166995
Remote Config [baseline] (642.898 µs) : 0, 643
Remote Config [candidate] (638.546 µs) : 0, 639
Telemetry [baseline] (7.45 ms) : 0, 7450
Telemetry [candidate] (8.527 ms) : 0, 8527
IAST [baseline] (19.234 ms) : 0, 19234
IAST [candidate] (19.933 ms) : 0, 19933
section iast
BytebuddyAgent [baseline] (819.041 ms) : 0, 819041
BytebuddyAgent [candidate] (814.151 ms) : 0, 814151
GlobalTracer [baseline] (307.702 ms) : 0, 307702
GlobalTracer [candidate] (307.804 ms) : 0, 307804
AppSec [baseline] (57.656 ms) : 0, 57656
AppSec [candidate] (57.993 ms) : 0, 57993
Remote Config [baseline] (609.479 µs) : 0, 609
Remote Config [candidate] (624.703 µs) : 0, 625
Telemetry [baseline] (7.391 ms) : 0, 7391
Telemetry [candidate] (7.535 ms) : 0, 7535
IAST [baseline] (21.95 ms) : 0, 21950
IAST [candidate] (21.274 ms) : 0, 21274
section profiling
ProfilingAgent [baseline] (93.116 ms) : 0, 93116
ProfilingAgent [candidate] (94.06 ms) : 0, 94060
BytebuddyAgent [baseline] (690.424 ms) : 0, 690424
BytebuddyAgent [candidate] (694.462 ms) : 0, 694462
GlobalTracer [baseline] (433.2 ms) : 0, 433200
GlobalTracer [candidate] (435.497 ms) : 0, 435497
AppSec [baseline] (53.236 ms) : 0, 53236
AppSec [candidate] (53.798 ms) : 0, 53798
Remote Config [baseline] (665.992 µs) : 0, 666
Remote Config [candidate] (690.142 µs) : 0, 690
Telemetry [baseline] (7.666 ms) : 0, 7666
Telemetry [candidate] (7.735 ms) : 0, 7735
Profiling [baseline] (93.141 ms) : 0, 93141
Profiling [candidate] (94.084 ms) : 0, 94084
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.45.0-SNAPSHOT~f9d1ad1ff8, baseline=1.45.0-SNAPSHOT~772d178d64
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.098 s) : 0, 1098470
Total [baseline] (8.701 s) : 0, 8700793
Agent [candidate] (1.093 s) : 0, 1093274
Total [candidate] (8.645 s) : 0, 8644709
section iast
Agent [baseline] (1.234 s) : 0, 1234288
Total [baseline] (9.207 s) : 0, 9207463
Agent [candidate] (1.227 s) : 0, 1227382
Total [candidate] (9.263 s) : 0, 9262917
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.218 s) : 0, 1217875
Total [baseline] (9.167 s) : 0, 9167452
Agent [candidate] (1.224 s) : 0, 1223906
Total [candidate] (9.216 s) : 0, 9215636
section iast_TELEMETRY_OFF
Agent [baseline] (1.216 s) : 0, 1215503
Total [baseline] (9.21 s) : 0, 9210371
Agent [candidate] (1.216 s) : 0, 1216428
Total [candidate] (9.187 s) : 0, 9187102
gantt
title insecure-bank - break down per module: candidate=1.45.0-SNAPSHOT~f9d1ad1ff8, baseline=1.45.0-SNAPSHOT~772d178d64
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (700.008 ms) : 0, 700008
BytebuddyAgent [candidate] (695.651 ms) : 0, 695651
GlobalTracer [baseline] (319.335 ms) : 0, 319335
GlobalTracer [candidate] (317.964 ms) : 0, 317964
AppSec [baseline] (54.743 ms) : 0, 54743
AppSec [candidate] (54.555 ms) : 0, 54555
Remote Config [baseline] (689.047 µs) : 0, 689
Remote Config [candidate] (687.566 µs) : 0, 688
Telemetry [baseline] (9.889 ms) : 0, 9889
Telemetry [candidate] (10.658 ms) : 0, 10658
section iast
BytebuddyAgent [baseline] (823.876 ms) : 0, 823876
BytebuddyAgent [candidate] (818.393 ms) : 0, 818393
GlobalTracer [baseline] (309.456 ms) : 0, 309456
GlobalTracer [candidate] (308.101 ms) : 0, 308101
AppSec [baseline] (57.986 ms) : 0, 57986
AppSec [candidate] (58.097 ms) : 0, 58097
IAST [baseline] (20.992 ms) : 0, 20992
IAST [candidate] (20.944 ms) : 0, 20944
Remote Config [baseline] (621.169 µs) : 0, 621
Remote Config [candidate] (610.803 µs) : 0, 611
Telemetry [baseline] (7.419 ms) : 0, 7419
Telemetry [candidate] (7.385 ms) : 0, 7385
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (811.347 ms) : 0, 811347
BytebuddyAgent [candidate] (814.82 ms) : 0, 814820
GlobalTracer [baseline] (305.584 ms) : 0, 305584
GlobalTracer [candidate] (307.32 ms) : 0, 307320
AppSec [baseline] (56.455 ms) : 0, 56455
AppSec [candidate] (56.947 ms) : 0, 56947
IAST [baseline] (22.73 ms) : 0, 22730
IAST [candidate] (22.907 ms) : 0, 22907
Remote Config [baseline] (602.804 µs) : 0, 603
Remote Config [candidate] (616.215 µs) : 0, 616
Telemetry [baseline] (7.43 ms) : 0, 7430
Telemetry [candidate] (7.49 ms) : 0, 7490
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (809.571 ms) : 0, 809571
BytebuddyAgent [candidate] (810.098 ms) : 0, 810098
GlobalTracer [baseline] (305.62 ms) : 0, 305620
GlobalTracer [candidate] (305.901 ms) : 0, 305901
AppSec [baseline] (57.269 ms) : 0, 57269
AppSec [candidate] (58.064 ms) : 0, 58064
IAST [baseline] (21.357 ms) : 0, 21357
IAST [candidate] (20.642 ms) : 0, 20642
Remote Config [baseline] (620.078 µs) : 0, 620
Remote Config [candidate] (622.824 µs) : 0, 623
Telemetry [baseline] (7.368 ms) : 0, 7368
Telemetry [candidate] (7.348 ms) : 0, 7348
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 16 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.45.0-SNAPSHOT~f9d1ad1ff8, baseline=1.45.0-SNAPSHOT~772d178d64
dateFormat X
axisFormat %s
section baseline
no_agent (390.025 µs) : 368, 412
. : milestone, 390,
iast (500.382 µs) : 479, 522
. : milestone, 500,
iast_FULL (657.2 µs) : 636, 679
. : milestone, 657,
iast_GLOBAL (536.107 µs) : 513, 559
. : milestone, 536,
iast_HARDCODED_SECRET_DISABLED (505.844 µs) : 484, 528
. : milestone, 506,
iast_INACTIVE (463.472 µs) : 442, 485
. : milestone, 463,
iast_TELEMETRY_OFF (497.797 µs) : 475, 520
. : milestone, 498,
tracing (458.329 µs) : 436, 481
. : milestone, 458,
section candidate
no_agent (383.891 µs) : 364, 404
. : milestone, 384,
iast (499.425 µs) : 478, 521
. : milestone, 499,
iast_FULL (630.575 µs) : 609, 652
. : milestone, 631,
iast_GLOBAL (503.994 µs) : 481, 527
. : milestone, 504,
iast_HARDCODED_SECRET_DISABLED (501.811 µs) : 480, 524
. : milestone, 502,
iast_INACTIVE (428.387 µs) : 407, 450
. : milestone, 428,
iast_TELEMETRY_OFF (488.865 µs) : 467, 510
. : milestone, 489,
tracing (464.352 µs) : 443, 486
. : milestone, 464,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.45.0-SNAPSHOT~f9d1ad1ff8, baseline=1.45.0-SNAPSHOT~772d178d64
dateFormat X
axisFormat %s
section baseline
no_agent (1.353 ms) : 1332, 1373
. : milestone, 1353,
appsec (1.759 ms) : 1736, 1783
. : milestone, 1759,
appsec_no_iast (1.787 ms) : 1763, 1811
. : milestone, 1787,
iast (1.509 ms) : 1485, 1532
. : milestone, 1509,
profiling (1.544 ms) : 1519, 1568
. : milestone, 1544,
tracing (1.485 ms) : 1459, 1511
. : milestone, 1485,
section candidate
no_agent (1.376 ms) : 1356, 1397
. : milestone, 1376,
appsec (1.788 ms) : 1764, 1812
. : milestone, 1788,
appsec_no_iast (1.762 ms) : 1739, 1786
. : milestone, 1762,
iast (1.517 ms) : 1494, 1540
. : milestone, 1517,
profiling (1.529 ms) : 1504, 1554
. : milestone, 1529,
tracing (1.511 ms) : 1487, 1535
. : milestone, 1511,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.45.0-SNAPSHOT~f9d1ad1ff8, baseline=1.45.0-SNAPSHOT~772d178d64
dateFormat X
axisFormat %s
section baseline
no_agent (14.818 s) : 14818000, 14818000
. : milestone, 14818000,
appsec (14.795 s) : 14795000, 14795000
. : milestone, 14795000,
iast (18.877 s) : 18877000, 18877000
. : milestone, 18877000,
iast_GLOBAL (17.814 s) : 17814000, 17814000
. : milestone, 17814000,
profiling (15.123 s) : 15123000, 15123000
. : milestone, 15123000,
tracing (14.983 s) : 14983000, 14983000
. : milestone, 14983000,
section candidate
no_agent (15.261 s) : 15261000, 15261000
. : milestone, 15261000,
appsec (14.932 s) : 14932000, 14932000
. : milestone, 14932000,
iast (18.514 s) : 18514000, 18514000
. : milestone, 18514000,
iast_GLOBAL (17.915 s) : 17915000, 17915000
. : milestone, 17915000,
profiling (14.736 s) : 14736000, 14736000
. : milestone, 14736000,
tracing (15.121 s) : 15121000, 15121000
. : milestone, 15121000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.45.0-SNAPSHOT~f9d1ad1ff8, baseline=1.45.0-SNAPSHOT~772d178d64
dateFormat X
axisFormat %s
section baseline
no_agent (1.464 ms) : 1453, 1476
. : milestone, 1464,
appsec (2.326 ms) : 2285, 2367
. : milestone, 2326,
iast (2.079 ms) : 2026, 2132
. : milestone, 2079,
iast_GLOBAL (2.132 ms) : 2079, 2185
. : milestone, 2132,
profiling (2.441 ms) : 2248, 2634
. : milestone, 2441,
tracing (1.919 ms) : 1879, 1959
. : milestone, 1919,
section candidate
no_agent (1.464 ms) : 1453, 1476
. : milestone, 1464,
appsec (2.325 ms) : 2283, 2366
. : milestone, 2325,
iast (2.075 ms) : 2023, 2128
. : milestone, 2075,
iast_GLOBAL (2.129 ms) : 2076, 2182
. : milestone, 2129,
profiling (1.951 ms) : 1909, 1993
. : milestone, 1951,
tracing (1.921 ms) : 1881, 1961
. : milestone, 1921,
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
What Does This Do
Skip spotless checks on
check_*
jobs. We have a dedicatedspotless
job.Motivation
On
check_profiling
job, occasionally:Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]