Use Apache archive for Tomcat smoke test - #12488
AlexeyKuznetsov-DD wants to merge 3 commits into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
More details
The new Ivy base URL and the existing artifact pattern make the Apache archive path for Tomcat 9.0.120. This path keeps the fixed smoke-test version available after the CDN removes it.
🤖 Datadog Autotest · Commit dce74b2 · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest
This comment has been minimized.
This comment has been minimized.
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
What Does This Do
Use the Apache archive to download the pinned Tomcat 9.0.120 distribution for the Spring Boot Tomcat smoke test.
Motivation
Keep the pinned Tomcat distribution consistently resolvable.
Additional Notes
The Gradle dependency update workflow could no longer resolve Tomcat 9.0.120 from
dlcdn.apache.org:dlcdn.apache.orgonly retains the latest Tomcat release. It currently serves 9.0.121, so the pinned 9.0.120 distribution has been removed. A fixed version can therefore become unavailable whenever a newer Tomcat version replaces it on the download CDN.archive.apache.orgis operational again and retains all published Tomcat versions, including 9.0.120. Using the archive keeps the pinned smoke-test dependency resolvable across future Tomcat releases without changing the locked version.This addresses the recurring failure pattern previously handled by version bumps in #11091 and #12221.
Validation:
./gradlew :dd-smoke-tests:springboot-tomcat:resolveAndLockAll --write-locks./gradlew :dd-smoke-tests:springboot-tomcat:unzip :dd-smoke-tests:springboot-tomcat:spotlessCheckContributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueJira ticket: N/A