Skip to content

Use Apache archive for Tomcat smoke test - #12488

Open
AlexeyKuznetsov-DD wants to merge 3 commits into
masterfrom
alexeyk/use-archived-tomcat-distribution
Open

AlexeyKuznetsov-DD wants to merge 3 commits into
masterfrom
alexeyk/use-archived-tomcat-distribution

Conversation

@AlexeyKuznetsov-DD

Copy link
Copy Markdown
Contributor

What Does This Do

Use the Apache archive to download the pinned Tomcat 9.0.120 distribution for the Spring Boot Tomcat smoke test.

Motivation

Keep the pinned Tomcat distribution consistently resolvable.

Additional Notes

The Gradle dependency update workflow could no longer resolve Tomcat 9.0.120 from dlcdn.apache.org:

Could not find tomcat:tomcat-9:9.0.120.
Searched in:
  https://dlcdn.apache.org/tomcat/tomcat-9/v9.0.120/bin/apache-tomcat-9.0.120.zip

dlcdn.apache.org only retains the latest Tomcat release. It currently serves 9.0.121, so the pinned 9.0.120 distribution has been removed. A fixed version can therefore become unavailable whenever a newer Tomcat version replaces it on the download CDN.

archive.apache.org is operational again and retains all published Tomcat versions, including 9.0.120. Using the archive keeps the pinned smoke-test dependency resolvable across future Tomcat releases without changing the locked version.

This addresses the recurring failure pattern previously handled by version bumps in #11091 and #12221.

Validation:

  • ./gradlew :dd-smoke-tests:springboot-tomcat:resolveAndLockAll --write-locks
  • ./gradlew :dd-smoke-tests:springboot-tomcat:unzip :dd-smoke-tests:springboot-tomcat:spotlessCheck

Contributor Checklist

Jira ticket: N/A

@AlexeyKuznetsov-DD AlexeyKuznetsov-DD added type: bug fix Bug fix comp: testing Testing tag: no release notes Changes to exclude from release notes tag: ai generated Largely based on code generated by an AI or LLM labels Sep 14, 2026
@AlexeyKuznetsov-DD
AlexeyKuznetsov-DD marked this pull request as ready for review September 14, 2026 17:29
@AlexeyKuznetsov-DD
AlexeyKuznetsov-DD requested a review from a team as a code owner September 14, 2026 17:29
@AlexeyKuznetsov-DD
AlexeyKuznetsov-DD requested review from bric3 and removed request for a team September 14, 2026 17:29
@AlexeyKuznetsov-DD AlexeyKuznetsov-DD self-assigned this Sep 14, 2026
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 14, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-14T17:33:00.722436Z dce74b2 Draft marked ready
🔒 Security Review Completed 2026-09-14T17:33:00.554900Z dce74b2 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@datadog-datadog-prod-us1-2 datadog-datadog-prod-us1-2 Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Datadog Autotest: PASS

More details

The new Ivy base URL and the existing artifact pattern make the Apache archive path for Tomcat 9.0.120. This path keeps the fixed smoke-test version available after the CDN removes it.

Was this helpful? React 👍 or 👎

Open Bits AI session

🤖 Datadog Autotest · Commit dce74b2 · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest

@datadog-datadog-prod-us1-2

This comment has been minimized.

@dd-octo-sts

dd-octo-sts Bot commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite Status
Startup 🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
Scenario Candidate master Δ (95% CI of mean)
startup:insecure-bank:iast:Agent 14.77 s 14.68 s [-0.4%; +1.7%] (no difference)
startup:insecure-bank:tracing:Agent 13.60 s 13.66 s [-1.2%; +0.3%] (no difference)
startup:petclinic:appsec:Agent 17.38 s 17.26 s [-0.3%; +1.7%] (no difference)
startup:petclinic:iast:Agent 17.28 s 17.06 s [-3.1%; +5.7%] (no difference)
startup:petclinic:profiling:Agent 16.81 s 16.68 s [-5.2%; +6.7%] (unstable)
startup:petclinic:sca:Agent 17.37 s 16.33 s [+0.6%; +12.1%] (unstable)
startup:petclinic:tracing:Agent 16.16 s 16.50 s [-6.2%; +2.0%] (no difference)

Commit: be34cbb1 · CI Pipeline · Benchmarking Platform UI


Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: testing Testing tag: ai generated Largely based on code generated by an AI or LLM tag: no release notes Changes to exclude from release notes type: bug fix Bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant