Draft
Conversation
Co-authored-by: dougqh <dougqh@gmail.com>
Contributor
|
I can only run on private repositories. |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 65 metrics, 6 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.61.0-SNAPSHOT~f8c6313b14, baseline=1.61.0-SNAPSHOT~1916c9079d
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.058 s) : 0, 1058421
Total [baseline] (8.833 s) : 0, 8832713
Agent [candidate] (1.06 s) : 0, 1059517
Total [candidate] (8.873 s) : 0, 8873345
section iast
Agent [baseline] (1.226 s) : 0, 1225753
Total [baseline] (9.578 s) : 0, 9577908
Agent [candidate] (1.226 s) : 0, 1226165
Total [candidate] (9.577 s) : 0, 9577277
gantt
title insecure-bank - break down per module: candidate=1.61.0-SNAPSHOT~f8c6313b14, baseline=1.61.0-SNAPSHOT~1916c9079d
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.211 ms) : 0, 1211
crashtracking [candidate] (1.201 ms) : 0, 1201
BytebuddyAgent [baseline] (629.889 ms) : 0, 629889
BytebuddyAgent [candidate] (630.069 ms) : 0, 630069
AgentMeter [baseline] (29.456 ms) : 0, 29456
AgentMeter [candidate] (29.508 ms) : 0, 29508
GlobalTracer [baseline] (257.523 ms) : 0, 257523
GlobalTracer [candidate] (257.541 ms) : 0, 257541
AppSec [baseline] (31.707 ms) : 0, 31707
AppSec [candidate] (31.689 ms) : 0, 31689
Debugger [baseline] (59.624 ms) : 0, 59624
Debugger [candidate] (59.746 ms) : 0, 59746
Remote Config [baseline] (612.0 µs) : 0, 612
Remote Config [candidate] (589.961 µs) : 0, 590
Telemetry [baseline] (8.051 ms) : 0, 8051
Telemetry [candidate] (8.02 ms) : 0, 8020
Flare Poller [baseline] (4.257 ms) : 0, 4257
Flare Poller [candidate] (4.997 ms) : 0, 4997
section iast
crashtracking [baseline] (1.193 ms) : 0, 1193
crashtracking [candidate] (1.186 ms) : 0, 1186
BytebuddyAgent [baseline] (795.233 ms) : 0, 795233
BytebuddyAgent [candidate] (795.63 ms) : 0, 795630
AgentMeter [baseline] (11.369 ms) : 0, 11369
AgentMeter [candidate] (11.377 ms) : 0, 11377
GlobalTracer [baseline] (247.03 ms) : 0, 247030
GlobalTracer [candidate] (247.568 ms) : 0, 247568
IAST [baseline] (25.343 ms) : 0, 25343
IAST [candidate] (25.331 ms) : 0, 25331
AppSec [baseline] (26.487 ms) : 0, 26487
AppSec [candidate] (26.489 ms) : 0, 26489
Debugger [baseline] (69.787 ms) : 0, 69787
Debugger [candidate] (67.456 ms) : 0, 67456
Remote Config [baseline] (531.335 µs) : 0, 531
Remote Config [candidate] (515.882 µs) : 0, 516
Telemetry [baseline] (9.204 ms) : 0, 9204
Telemetry [candidate] (10.665 ms) : 0, 10665
Flare Poller [baseline] (3.403 ms) : 0, 3403
Flare Poller [candidate] (3.797 ms) : 0, 3797
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.61.0-SNAPSHOT~f8c6313b14, baseline=1.61.0-SNAPSHOT~1916c9079d
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.062 s) : 0, 1062185
Total [baseline] (11.058 s) : 0, 11058223
Agent [candidate] (1.068 s) : 0, 1068198
Total [candidate] (11.192 s) : 0, 11191823
section appsec
Agent [baseline] (1.255 s) : 0, 1254518
Total [baseline] (11.246 s) : 0, 11245982
Agent [candidate] (1.248 s) : 0, 1247593
Total [candidate] (11.184 s) : 0, 11184205
section iast
Agent [baseline] (1.228 s) : 0, 1228321
Total [baseline] (11.304 s) : 0, 11303578
Agent [candidate] (1.226 s) : 0, 1225973
Total [candidate] (11.326 s) : 0, 11325764
section profiling
Agent [baseline] (1.19 s) : 0, 1190413
Total [baseline] (11.181 s) : 0, 11180982
Agent [candidate] (1.184 s) : 0, 1183779
Total [candidate] (11.079 s) : 0, 11079398
gantt
title petclinic - break down per module: candidate=1.61.0-SNAPSHOT~f8c6313b14, baseline=1.61.0-SNAPSHOT~1916c9079d
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.205 ms) : 0, 1205
crashtracking [candidate] (1.206 ms) : 0, 1206
BytebuddyAgent [baseline] (631.598 ms) : 0, 631598
BytebuddyAgent [candidate] (633.965 ms) : 0, 633965
AgentMeter [baseline] (29.541 ms) : 0, 29541
AgentMeter [candidate] (29.615 ms) : 0, 29615
GlobalTracer [baseline] (258.029 ms) : 0, 258029
GlobalTracer [candidate] (259.006 ms) : 0, 259006
AppSec [baseline] (31.873 ms) : 0, 31873
AppSec [candidate] (32.021 ms) : 0, 32021
Debugger [baseline] (60.779 ms) : 0, 60779
Debugger [candidate] (60.923 ms) : 0, 60923
Remote Config [baseline] (590.261 µs) : 0, 590
Remote Config [candidate] (598.432 µs) : 0, 598
Telemetry [baseline] (8.097 ms) : 0, 8097
Telemetry [candidate] (8.144 ms) : 0, 8144
Flare Poller [baseline] (4.339 ms) : 0, 4339
Flare Poller [candidate] (6.596 ms) : 0, 6596
section appsec
crashtracking [baseline] (1.204 ms) : 0, 1204
crashtracking [candidate] (1.204 ms) : 0, 1204
BytebuddyAgent [baseline] (662.948 ms) : 0, 662948
BytebuddyAgent [candidate] (658.891 ms) : 0, 658891
AgentMeter [baseline] (12.195 ms) : 0, 12195
AgentMeter [candidate] (12.089 ms) : 0, 12089
GlobalTracer [baseline] (259.645 ms) : 0, 259645
GlobalTracer [candidate] (258.14 ms) : 0, 258140
IAST [baseline] (24.369 ms) : 0, 24369
IAST [candidate] (24.278 ms) : 0, 24278
AppSec [baseline] (178.623 ms) : 0, 178623
AppSec [candidate] (178.274 ms) : 0, 178274
Debugger [baseline] (66.553 ms) : 0, 66553
Debugger [candidate] (65.785 ms) : 0, 65785
Remote Config [baseline] (627.235 µs) : 0, 627
Remote Config [candidate] (634.468 µs) : 0, 634
Telemetry [baseline] (8.329 ms) : 0, 8329
Telemetry [candidate] (8.344 ms) : 0, 8344
Flare Poller [baseline] (3.606 ms) : 0, 3606
Flare Poller [candidate] (3.607 ms) : 0, 3607
section iast
crashtracking [baseline] (1.19 ms) : 0, 1190
crashtracking [candidate] (1.223 ms) : 0, 1223
BytebuddyAgent [baseline] (796.61 ms) : 0, 796610
BytebuddyAgent [candidate] (794.54 ms) : 0, 794540
AgentMeter [baseline] (11.417 ms) : 0, 11417
AgentMeter [candidate] (11.388 ms) : 0, 11388
GlobalTracer [baseline] (247.526 ms) : 0, 247526
GlobalTracer [candidate] (247.252 ms) : 0, 247252
IAST [baseline] (25.367 ms) : 0, 25367
IAST [candidate] (25.375 ms) : 0, 25375
AppSec [baseline] (26.427 ms) : 0, 26427
AppSec [candidate] (26.51 ms) : 0, 26510
Debugger [baseline] (70.418 ms) : 0, 70418
Debugger [candidate] (70.598 ms) : 0, 70598
Remote Config [baseline] (529.505 µs) : 0, 530
Remote Config [candidate] (533.254 µs) : 0, 533
Telemetry [baseline] (9.345 ms) : 0, 9345
Telemetry [candidate] (9.147 ms) : 0, 9147
Flare Poller [baseline] (3.32 ms) : 0, 3320
Flare Poller [candidate] (3.277 ms) : 0, 3277
section profiling
crashtracking [baseline] (1.179 ms) : 0, 1179
crashtracking [candidate] (1.174 ms) : 0, 1174
BytebuddyAgent [baseline] (687.294 ms) : 0, 687294
BytebuddyAgent [candidate] (682.897 ms) : 0, 682897
AgentMeter [baseline] (8.973 ms) : 0, 8973
AgentMeter [candidate] (9.033 ms) : 0, 9033
GlobalTracer [baseline] (216.655 ms) : 0, 216655
GlobalTracer [candidate] (215.736 ms) : 0, 215736
AppSec [baseline] (32.398 ms) : 0, 32398
AppSec [candidate] (32.204 ms) : 0, 32204
Debugger [baseline] (65.58 ms) : 0, 65580
Debugger [candidate] (65.913 ms) : 0, 65913
Remote Config [baseline] (570.387 µs) : 0, 570
Remote Config [candidate] (565.207 µs) : 0, 565
Telemetry [baseline] (7.77 ms) : 0, 7770
Telemetry [candidate] (7.736 ms) : 0, 7736
Flare Poller [baseline] (4.283 ms) : 0, 4283
Flare Poller [candidate] (3.464 ms) : 0, 3464
ProfilingAgent [baseline] (94.444 ms) : 0, 94444
ProfilingAgent [candidate] (94.169 ms) : 0, 94169
Profiling [baseline] (95.02 ms) : 0, 95020
Profiling [candidate] (94.727 ms) : 0, 94727
LoadParameters
See matching parameters
SummaryFound 2 performance improvements and 4 performance regressions! Performance is the same for 15 metrics, 15 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.61.0-SNAPSHOT~f8c6313b14, baseline=1.61.0-SNAPSHOT~1916c9079d
dateFormat X
axisFormat %s
section baseline
no_agent (1.184 ms) : 1172, 1195
. : milestone, 1184,
iast (3.122 ms) : 3081, 3163
. : milestone, 3122,
iast_FULL (5.595 ms) : 5540, 5650
. : milestone, 5595,
iast_GLOBAL (3.57 ms) : 3521, 3619
. : milestone, 3570,
profiling (2.102 ms) : 2083, 2122
. : milestone, 2102,
tracing (1.826 ms) : 1811, 1842
. : milestone, 1826,
section candidate
no_agent (1.192 ms) : 1180, 1204
. : milestone, 1192,
iast (3.158 ms) : 3114, 3203
. : milestone, 3158,
iast_FULL (5.98 ms) : 5919, 6040
. : milestone, 5980,
iast_GLOBAL (3.69 ms) : 3620, 3759
. : milestone, 3690,
profiling (2.312 ms) : 2288, 2336
. : milestone, 2312,
tracing (1.869 ms) : 1853, 1885
. : milestone, 1869,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.61.0-SNAPSHOT~f8c6313b14, baseline=1.61.0-SNAPSHOT~1916c9079d
dateFormat X
axisFormat %s
section baseline
no_agent (19.239 ms) : 19041, 19437
. : milestone, 19239,
appsec (19.393 ms) : 19194, 19592
. : milestone, 19393,
code_origins (17.706 ms) : 17532, 17880
. : milestone, 17706,
iast (17.855 ms) : 17677, 18033
. : milestone, 17855,
profiling (18.601 ms) : 18418, 18784
. : milestone, 18601,
tracing (18.524 ms) : 18336, 18712
. : milestone, 18524,
section candidate
no_agent (18.869 ms) : 18678, 19061
. : milestone, 18869,
appsec (18.782 ms) : 18593, 18971
. : milestone, 18782,
code_origins (17.598 ms) : 17429, 17767
. : milestone, 17598,
iast (17.847 ms) : 17668, 18026
. : milestone, 17847,
profiling (19.933 ms) : 19732, 20133
. : milestone, 19933,
tracing (17.8 ms) : 17624, 17976
. : milestone, 17800,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 2 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.61.0-SNAPSHOT~f8c6313b14, baseline=1.61.0-SNAPSHOT~1916c9079d
dateFormat X
axisFormat %s
section baseline
no_agent (1.477 ms) : 1466, 1489
. : milestone, 1477,
appsec (3.718 ms) : 3502, 3934
. : milestone, 3718,
iast (2.247 ms) : 2178, 2316
. : milestone, 2247,
iast_GLOBAL (2.302 ms) : 2232, 2372
. : milestone, 2302,
profiling (2.51 ms) : 2346, 2675
. : milestone, 2510,
tracing (2.064 ms) : 2010, 2117
. : milestone, 2064,
section candidate
no_agent (1.472 ms) : 1461, 1484
. : milestone, 1472,
appsec (3.796 ms) : 3575, 4018
. : milestone, 3796,
iast (2.253 ms) : 2184, 2322
. : milestone, 2253,
iast_GLOBAL (2.294 ms) : 2225, 2363
. : milestone, 2294,
profiling (2.07 ms) : 2016, 2124
. : milestone, 2070,
tracing (2.063 ms) : 2009, 2117
. : milestone, 2063,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.61.0-SNAPSHOT~f8c6313b14, baseline=1.61.0-SNAPSHOT~1916c9079d
dateFormat X
axisFormat %s
section baseline
no_agent (15.523 s) : 15523000, 15523000
. : milestone, 15523000,
appsec (14.501 s) : 14501000, 14501000
. : milestone, 14501000,
iast (18.248 s) : 18248000, 18248000
. : milestone, 18248000,
iast_GLOBAL (17.811 s) : 17811000, 17811000
. : milestone, 17811000,
profiling (14.875 s) : 14875000, 14875000
. : milestone, 14875000,
tracing (15.021 s) : 15021000, 15021000
. : milestone, 15021000,
section candidate
no_agent (14.885 s) : 14885000, 14885000
. : milestone, 14885000,
appsec (14.661 s) : 14661000, 14661000
. : milestone, 14661000,
iast (18.325 s) : 18325000, 18325000
. : milestone, 18325000,
iast_GLOBAL (18.027 s) : 18027000, 18027000
. : milestone, 18027000,
profiling (14.964 s) : 14964000, 14964000
. : milestone, 14964000,
tracing (14.908 s) : 14908000, 14908000
. : milestone, 14908000,
|
Co-authored-by: dougqh <dougqh@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
memoryTestsuite ininternal-apithat compiles and runs with Java 11.AgentTracerSpanCreationMemoryTestunderinternal-api/src/memoryTest/java/datadog/trace/bootstrap/instrumentation/api/to verifyAgentTracer.startSpan()does not emit JFR allocation events in noop mode.jfrunitto the version catalog and wires it intointernal-apiviamemoryTestImplementation.Motivation
APMLP-509is focused on lowering Java tracer overhead. This change adds a regression guard ininternal-apiso span creation allocation behavior is continuously validated.Additional Notes
Testing/Validation
Linttool:ktlintformattedinternal-api/build.gradle.kts.checkstyleran forinternal-api/src/memoryTest/java/datadog/trace/bootstrap/instrumentation/api/AgentTracerSpanCreationMemoryTest.java.Formattool:spotlessApplycould not run because Gradle wrapper download failed in this sandbox (services.gradle.orgDNS resolution failure).Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: APMLP-509
Note: Once your PR is ready to merge, add it to the merge queue by commenting
/merge./merge -ccancels the queue request./merge -f --reason "reason"skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.PR by Bits - View session in Datadog
Comment @DataDog to request changes