Skip to content

Move SimpleUtf8Cache and GenerationalUtf8Cache to the communication module#10925

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit intomasterfrom
mcculls/reuse-utf8-caching
Mar 23, 2026
Merged

Move SimpleUtf8Cache and GenerationalUtf8Cache to the communication module#10925
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit intomasterfrom
mcculls/reuse-utf8-caching

Conversation

@mcculls
Copy link
Contributor

@mcculls mcculls commented Mar 22, 2026

Motivation

Move SimpleUtf8Cache and GenerationalUtf8Cache to the communication module so they can be reused for OTLP encoding.

Contributor Checklist

Jira ticket: [PROJ-IDENT]

Note: Once your PR is ready to merge, add it to the merge queue by commenting /merge. /merge -c cancels the queue request. /merge -f --reason "reason" skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.

@mcculls mcculls requested a review from a team as a code owner March 22, 2026 18:33
@mcculls mcculls added comp: core Tracer core tag: no release notes Changes to exclude from release notes labels Mar 22, 2026
@mcculls mcculls requested a review from amarziali March 22, 2026 18:33
@mcculls mcculls requested review from dougqh and mtoffl01 March 22, 2026 18:33
@pr-commenter
Copy link

pr-commenter bot commented Mar 22, 2026

Benchmarks

⚠️ Warning: Baseline build not found for merge-base commit. Comparing against the latest commit on master instead.

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mcculls/reuse-utf8-caching
git_commit_date 1774050014 1774204076
git_commit_sha c00f676 29877c4
release_version 1.61.0-SNAPSHOT~c00f676bb9 1.61.0-SNAPSHOT~29877c4bc5
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1774206134 1774206134
ci_job_id 1528813983 1528813983
ci_pipeline_id 103907502 103907502
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-0-g147hbqy 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-0-g147hbqy 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module Agent Agent
parent None None

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 62 metrics, 9 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.61.0-SNAPSHOT~29877c4bc5, baseline=1.61.0-SNAPSHOT~c00f676bb9

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.07 s) : 0, 1069851
Total [baseline] (11.111 s) : 0, 11111046
Agent [candidate] (1.054 s) : 0, 1053920
Total [candidate] (11.074 s) : 0, 11074358
section appsec
Agent [baseline] (1.243 s) : 0, 1243221
Total [baseline] (11.136 s) : 0, 11135706
Agent [candidate] (1.249 s) : 0, 1248563
Total [candidate] (11.258 s) : 0, 11258460
section iast
Agent [baseline] (1.226 s) : 0, 1225874
Total [baseline] (11.298 s) : 0, 11297645
Agent [candidate] (1.225 s) : 0, 1225269
Total [candidate] (11.336 s) : 0, 11335853
section profiling
Agent [baseline] (1.182 s) : 0, 1181560
Total [baseline] (10.959 s) : 0, 10958593
Agent [candidate] (1.183 s) : 0, 1182697
Total [candidate] (11.138 s) : 0, 11137966
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.07 s -
Agent appsec 1.243 s 173.37 ms (16.2%)
Agent iast 1.226 s 156.022 ms (14.6%)
Agent profiling 1.182 s 111.709 ms (10.4%)
Total tracing 11.111 s -
Total appsec 11.136 s 24.66 ms (0.2%)
Total iast 11.298 s 186.599 ms (1.7%)
Total profiling 10.959 s -152.453 ms (-1.4%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.054 s -
Agent appsec 1.249 s 194.643 ms (18.5%)
Agent iast 1.225 s 171.349 ms (16.3%)
Agent profiling 1.183 s 128.777 ms (12.2%)
Total tracing 11.074 s -
Total appsec 11.258 s 184.102 ms (1.7%)
Total iast 11.336 s 261.495 ms (2.4%)
Total profiling 11.138 s 63.608 ms (0.6%) 
gantt
    title petclinic - break down per module: candidate=1.61.0-SNAPSHOT~29877c4bc5, baseline=1.61.0-SNAPSHOT~c00f676bb9

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.227 ms) : 0, 1227
crashtracking [candidate] (1.192 ms) : 0, 1192
BytebuddyAgent [baseline] (636.535 ms) : 0, 636535
BytebuddyAgent [candidate] (627.807 ms) : 0, 627807
AgentMeter [baseline] (29.784 ms) : 0, 29784
AgentMeter [candidate] (29.242 ms) : 0, 29242
GlobalTracer [baseline] (259.641 ms) : 0, 259641
GlobalTracer [candidate] (256.05 ms) : 0, 256050
AppSec [baseline] (32.19 ms) : 0, 32190
AppSec [candidate] (31.541 ms) : 0, 31541
Debugger [baseline] (61.12 ms) : 0, 61120
Debugger [candidate] (60.135 ms) : 0, 60135
Remote Config [baseline] (597.097 µs) : 0, 597
Remote Config [candidate] (583.216 µs) : 0, 583
Telemetry [baseline] (8.131 ms) : 0, 8131
Telemetry [candidate] (7.952 ms) : 0, 7952
Flare Poller [baseline] (4.339 ms) : 0, 4339
Flare Poller [candidate] (3.538 ms) : 0, 3538
section appsec
crashtracking [baseline] (1.197 ms) : 0, 1197
crashtracking [candidate] (1.204 ms) : 0, 1204
BytebuddyAgent [baseline] (655.964 ms) : 0, 655964
BytebuddyAgent [candidate] (660.235 ms) : 0, 660235
AgentMeter [baseline] (12.086 ms) : 0, 12086
AgentMeter [candidate] (12.072 ms) : 0, 12072
GlobalTracer [baseline] (257.638 ms) : 0, 257638
GlobalTracer [candidate] (258.23 ms) : 0, 258230
IAST [baseline] (24.076 ms) : 0, 24076
IAST [candidate] (24.174 ms) : 0, 24174
AppSec [baseline] (177.441 ms) : 0, 177441
AppSec [candidate] (177.533 ms) : 0, 177533
Debugger [baseline] (65.991 ms) : 0, 65991
Debugger [candidate] (66.153 ms) : 0, 66153
Remote Config [baseline] (642.113 µs) : 0, 642
Remote Config [candidate] (628.022 µs) : 0, 628
Telemetry [baseline] (8.382 ms) : 0, 8382
Telemetry [candidate] (8.314 ms) : 0, 8314
Flare Poller [baseline] (3.626 ms) : 0, 3626
Flare Poller [candidate] (3.629 ms) : 0, 3629
section iast
crashtracking [baseline] (1.196 ms) : 0, 1196
crashtracking [candidate] (1.2 ms) : 0, 1200
BytebuddyAgent [baseline] (794.943 ms) : 0, 794943
BytebuddyAgent [candidate] (794.871 ms) : 0, 794871
AgentMeter [baseline] (11.381 ms) : 0, 11381
AgentMeter [candidate] (11.362 ms) : 0, 11362
GlobalTracer [baseline] (247.02 ms) : 0, 247020
GlobalTracer [candidate] (246.887 ms) : 0, 246887
IAST [baseline] (25.277 ms) : 0, 25277
IAST [candidate] (25.256 ms) : 0, 25256
AppSec [baseline] (26.412 ms) : 0, 26412
AppSec [candidate] (26.41 ms) : 0, 26410
Debugger [baseline] (70.6 ms) : 0, 70600
Debugger [candidate] (69.598 ms) : 0, 69598
Remote Config [baseline] (527.873 µs) : 0, 528
Remote Config [candidate] (522.364 µs) : 0, 522
Telemetry [baseline] (9.147 ms) : 0, 9147
Telemetry [candidate] (9.604 ms) : 0, 9604
Flare Poller [baseline] (3.305 ms) : 0, 3305
Flare Poller [candidate] (3.55 ms) : 0, 3550
section profiling
crashtracking [baseline] (1.167 ms) : 0, 1167
crashtracking [candidate] (1.176 ms) : 0, 1176
BytebuddyAgent [baseline] (681.662 ms) : 0, 681662
BytebuddyAgent [candidate] (681.413 ms) : 0, 681413
AgentMeter [baseline] (9.003 ms) : 0, 9003
AgentMeter [candidate] (8.982 ms) : 0, 8982
GlobalTracer [baseline] (215.134 ms) : 0, 215134
GlobalTracer [candidate] (215.753 ms) : 0, 215753
AppSec [baseline] (31.973 ms) : 0, 31973
AppSec [candidate] (32.155 ms) : 0, 32155
Debugger [baseline] (66.012 ms) : 0, 66012
Debugger [candidate] (65.285 ms) : 0, 65285
Remote Config [baseline] (556.008 µs) : 0, 556
Remote Config [candidate] (565.015 µs) : 0, 565
Telemetry [baseline] (7.63 ms) : 0, 7630
Telemetry [candidate] (8.543 ms) : 0, 8543
Flare Poller [baseline] (3.409 ms) : 0, 3409
Flare Poller [candidate] (3.494 ms) : 0, 3494
ProfilingAgent [baseline] (94.158 ms) : 0, 94158
ProfilingAgent [candidate] (94.489 ms) : 0, 94489
Profiling [baseline] (94.724 ms) : 0, 94724
Profiling [candidate] (95.058 ms) : 0, 95058
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.61.0-SNAPSHOT~29877c4bc5, baseline=1.61.0-SNAPSHOT~c00f676bb9

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.055 s) : 0, 1054748
Total [baseline] (8.872 s) : 0, 8872126
Agent [candidate] (1.055 s) : 0, 1054998
Total [candidate] (8.873 s) : 0, 8872936
section iast
Agent [baseline] (1.232 s) : 0, 1231950
Total [baseline] (9.58 s) : 0, 9579596
Agent [candidate] (1.227 s) : 0, 1227365
Total [candidate] (9.552 s) : 0, 9551597
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.055 s -
Agent iast 1.232 s 177.202 ms (16.8%)
Total tracing 8.872 s -
Total iast 9.58 s 707.469 ms (8.0%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.055 s -
Agent iast 1.227 s 172.367 ms (16.3%)
Total tracing 8.873 s -
Total iast 9.552 s 678.661 ms (7.6%) 
gantt
    title insecure-bank - break down per module: candidate=1.61.0-SNAPSHOT~29877c4bc5, baseline=1.61.0-SNAPSHOT~c00f676bb9

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.192 ms) : 0, 1192
crashtracking [candidate] (1.191 ms) : 0, 1191
BytebuddyAgent [baseline] (627.741 ms) : 0, 627741
BytebuddyAgent [candidate] (627.018 ms) : 0, 627018
AgentMeter [baseline] (29.352 ms) : 0, 29352
AgentMeter [candidate] (29.363 ms) : 0, 29363
GlobalTracer [baseline] (256.323 ms) : 0, 256323
GlobalTracer [candidate] (256.519 ms) : 0, 256519
AppSec [baseline] (31.723 ms) : 0, 31723
AppSec [candidate] (31.661 ms) : 0, 31661
Debugger [baseline] (59.614 ms) : 0, 59614
Debugger [candidate] (59.614 ms) : 0, 59614
Remote Config [baseline] (587.757 µs) : 0, 588
Remote Config [candidate] (586.899 µs) : 0, 587
Telemetry [baseline] (7.983 ms) : 0, 7983
Telemetry [candidate] (8.789 ms) : 0, 8789
Flare Poller [baseline] (4.215 ms) : 0, 4215
Flare Poller [candidate] (4.284 ms) : 0, 4284
section iast
crashtracking [baseline] (1.205 ms) : 0, 1205
crashtracking [candidate] (1.193 ms) : 0, 1193
BytebuddyAgent [baseline] (800.019 ms) : 0, 800019
BytebuddyAgent [candidate] (796.191 ms) : 0, 796191
AgentMeter [baseline] (11.589 ms) : 0, 11589
AgentMeter [candidate] (11.412 ms) : 0, 11412
GlobalTracer [baseline] (247.777 ms) : 0, 247777
GlobalTracer [candidate] (247.573 ms) : 0, 247573
AppSec [baseline] (27.329 ms) : 0, 27329
AppSec [candidate] (26.448 ms) : 0, 26448
Debugger [baseline] (67.139 ms) : 0, 67139
Debugger [candidate] (66.04 ms) : 0, 66040
Remote Config [baseline] (532.321 µs) : 0, 532
Remote Config [candidate] (521.442 µs) : 0, 521
Telemetry [baseline] (10.867 ms) : 0, 10867
Telemetry [candidate] (12.241 ms) : 0, 12241
Flare Poller [baseline] (3.793 ms) : 0, 3793
Flare Poller [candidate] (4.259 ms) : 0, 4259
IAST [baseline] (25.539 ms) : 0, 25539
IAST [candidate] (25.335 ms) : 0, 25335
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mcculls/reuse-utf8-caching
git_commit_date 1774050014 1774204076
git_commit_sha c00f676 29877c4
release_version 1.61.0-SNAPSHOT~c00f676bb9 1.61.0-SNAPSHOT~29877c4bc5
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1774206601 1774206601
ci_job_id 1528813985 1528813985
ci_pipeline_id 103907502 103907502
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-0-jjzs0kyg 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-0-jjzs0kyg 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 2 performance improvements and 1 performance regressions! Performance is the same for 17 metrics, 16 unstable metrics.

scenario Δ mean agg_http_req_duration_p50 Δ mean agg_http_req_duration_p95 Δ mean throughput candidate mean agg_http_req_duration_p50 candidate mean agg_http_req_duration_p95 candidate mean throughput baseline mean agg_http_req_duration_p50 baseline mean agg_http_req_duration_p95 baseline mean throughput
scenario:load:insecure-bank:profiling:high_load better
[-231.896µs; -87.059µs] or [-12.801%; -4.806%]		 unstable
[-1241.950µs; -256.509µs] or [-22.279%; -4.601%]		 unstable
[+4.701op/s; +509.237op/s] or [+0.240%; +25.972%]		 1.652ms 4.825ms 2217.656op/s 1.812ms 5.575ms 1960.688op/s
scenario:load:insecure-bank:iast_GLOBAL:high_load better
[-195.737µs; -94.256µs] or [-6.638%; -3.197%]		 same
[-341.113µs; +57.702µs] or [-4.187%; +0.708%]		 unstable
[-77.172op/s; +189.297op/s] or [-6.276%; +15.395%]		 2.804ms 8.006ms 1285.688op/s 2.949ms 8.147ms 1229.625op/s
scenario:load:petclinic:code_origins:high_load worse
[+0.647ms; +1.415ms] or [+3.704%; +8.100%]		 unsure
[+259.257µs; +1512.971µs] or [+0.894%; +5.217%]		 unstable
[-40.500op/s; +18.937op/s] or [-15.624%; +7.306%]		 18.497ms 29.890ms 248.438op/s 17.466ms 29.003ms 259.219op/s
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.61.0-SNAPSHOT~29877c4bc5, baseline=1.61.0-SNAPSHOT~c00f676bb9
    dateFormat X
    axisFormat %s
section baseline
no_agent (19.086 ms) : 18892, 19280
.   : milestone, 19086,
appsec (19.58 ms) : 19381, 19780
.   : milestone, 19580,
code_origins (18.002 ms) : 17824, 18179
.   : milestone, 18002,
iast (18.582 ms) : 18398, 18765
.   : milestone, 18582,
profiling (18.416 ms) : 18229, 18603
.   : milestone, 18416,
tracing (17.886 ms) : 17709, 18062
.   : milestone, 17886,
section candidate
no_agent (19.132 ms) : 18933, 19332
.   : milestone, 19132,
appsec (18.686 ms) : 18498, 18873
.   : milestone, 18686,
code_origins (18.787 ms) : 18600, 18974
.   : milestone, 18787,
iast (18.585 ms) : 18399, 18771
.   : milestone, 18585,
profiling (18.717 ms) : 18525, 18908
.   : milestone, 18717,
tracing (17.735 ms) : 17563, 17908
.   : milestone, 17735,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 19.086 ms [18.892 ms, 19.28 ms] -
appsec 19.58 ms [19.381 ms, 19.78 ms] 494.586 µs (2.6%)
code_origins 18.002 ms [17.824 ms, 18.179 ms] -1.084 ms (-5.7%)
iast 18.582 ms [18.398 ms, 18.765 ms] -503.979 µs (-2.6%)
profiling 18.416 ms [18.229 ms, 18.603 ms] -669.985 µs (-3.5%)
tracing 17.886 ms [17.709 ms, 18.062 ms] -1.2 ms (-6.3%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 19.132 ms [18.933 ms, 19.332 ms] -
appsec 18.686 ms [18.498 ms, 18.873 ms] -446.815 µs (-2.3%)
code_origins 18.787 ms [18.6 ms, 18.974 ms] -345.255 µs (-1.8%)
iast 18.585 ms [18.399 ms, 18.771 ms] -547.296 µs (-2.9%)
profiling 18.717 ms [18.525 ms, 18.908 ms] -415.907 µs (-2.2%)
tracing 17.735 ms [17.563 ms, 17.908 ms] -1.397 ms (-7.3%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.61.0-SNAPSHOT~29877c4bc5, baseline=1.61.0-SNAPSHOT~c00f676bb9
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.216 ms) : 1203, 1228
.   : milestone, 1216,
iast (3.353 ms) : 3309, 3397
.   : milestone, 3353,
iast_FULL (5.966 ms) : 5905, 6026
.   : milestone, 5966,
iast_GLOBAL (3.732 ms) : 3668, 3797
.   : milestone, 3732,
profiling (2.312 ms) : 2291, 2333
.   : milestone, 2312,
tracing (1.761 ms) : 1747, 1775
.   : milestone, 1761,
section candidate
no_agent (1.177 ms) : 1166, 1188
.   : milestone, 1177,
iast (3.289 ms) : 3245, 3334
.   : milestone, 3289,
iast_FULL (5.986 ms) : 5925, 6046
.   : milestone, 5986,
iast_GLOBAL (3.566 ms) : 3512, 3620
.   : milestone, 3566,
profiling (2.036 ms) : 2018, 2054
.   : milestone, 2036,
tracing (1.772 ms) : 1757, 1787
.   : milestone, 1772,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.216 ms [1.203 ms, 1.228 ms] -
iast 3.353 ms [3.309 ms, 3.397 ms] 2.137 ms (175.8%)
iast_FULL 5.966 ms [5.905 ms, 6.026 ms] 4.75 ms (390.7%)
iast_GLOBAL 3.732 ms [3.668 ms, 3.797 ms] 2.517 ms (207.0%)
profiling 2.312 ms [2.291 ms, 2.333 ms] 1.096 ms (90.1%)
tracing 1.761 ms [1.747 ms, 1.775 ms] 545.075 µs (44.8%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.177 ms [1.166 ms, 1.188 ms] -
iast 3.289 ms [3.245 ms, 3.334 ms] 2.113 ms (179.5%)
iast_FULL 5.986 ms [5.925 ms, 6.046 ms] 4.809 ms (408.7%)
iast_GLOBAL 3.566 ms [3.512 ms, 3.62 ms] 2.389 ms (203.0%)
profiling 2.036 ms [2.018 ms, 2.054 ms] 859.349 µs (73.0%)
tracing 1.772 ms [1.757 ms, 1.787 ms] 595.42 µs (50.6%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mcculls/reuse-utf8-caching
git_commit_date 1774050014 1774204076
git_commit_sha c00f676 29877c4
release_version 1.61.0-SNAPSHOT~c00f676bb9 1.61.0-SNAPSHOT~29877c4bc5
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1774206444 1774206444
ci_job_id 1528813987 1528813987
ci_pipeline_id 103907502 103907502
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-1-g9tj1dsk 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-1-g9tj1dsk 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.61.0-SNAPSHOT~29877c4bc5, baseline=1.61.0-SNAPSHOT~c00f676bb9
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.472 ms) : 1460, 1483
.   : milestone, 1472,
appsec (3.819 ms) : 3600, 4039
.   : milestone, 3819,
iast (2.266 ms) : 2196, 2336
.   : milestone, 2266,
iast_GLOBAL (2.302 ms) : 2232, 2373
.   : milestone, 2302,
profiling (2.096 ms) : 2039, 2153
.   : milestone, 2096,
tracing (2.073 ms) : 2019, 2127
.   : milestone, 2073,
section candidate
no_agent (1.472 ms) : 1460, 1483
.   : milestone, 1472,
appsec (3.8 ms) : 3579, 4021
.   : milestone, 3800,
iast (2.258 ms) : 2188, 2327
.   : milestone, 2258,
iast_GLOBAL (2.303 ms) : 2233, 2372
.   : milestone, 2303,
profiling (2.105 ms) : 2048, 2162
.   : milestone, 2105,
tracing (2.082 ms) : 2027, 2137
.   : milestone, 2082,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.472 ms [1.46 ms, 1.483 ms] -
appsec 3.819 ms [3.6 ms, 4.039 ms] 2.347 ms (159.5%)
iast 2.266 ms [2.196 ms, 2.336 ms] 794.309 µs (54.0%)
iast_GLOBAL 2.302 ms [2.232 ms, 2.373 ms] 830.705 µs (56.4%)
profiling 2.096 ms [2.039 ms, 2.153 ms] 624.495 µs (42.4%)
tracing 2.073 ms [2.019 ms, 2.127 ms] 601.214 µs (40.9%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.472 ms [1.46 ms, 1.483 ms] -
appsec 3.8 ms [3.579 ms, 4.021 ms] 2.328 ms (158.2%)
iast 2.258 ms [2.188 ms, 2.327 ms] 785.656 µs (53.4%)
iast_GLOBAL 2.303 ms [2.233 ms, 2.372 ms] 830.655 µs (56.4%)
profiling 2.105 ms [2.048 ms, 2.162 ms] 633.165 µs (43.0%)
tracing 2.082 ms [2.027 ms, 2.137 ms] 610.141 µs (41.5%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.61.0-SNAPSHOT~29877c4bc5, baseline=1.61.0-SNAPSHOT~c00f676bb9
    dateFormat X
    axisFormat %s
section baseline
no_agent (14.977 s) : 14977000, 14977000
.   : milestone, 14977000,
appsec (14.789 s) : 14789000, 14789000
.   : milestone, 14789000,
iast (18.456 s) : 18456000, 18456000
.   : milestone, 18456000,
iast_GLOBAL (17.686 s) : 17686000, 17686000
.   : milestone, 17686000,
profiling (15.413 s) : 15413000, 15413000
.   : milestone, 15413000,
tracing (14.659 s) : 14659000, 14659000
.   : milestone, 14659000,
section candidate
no_agent (15.505 s) : 15505000, 15505000
.   : milestone, 15505000,
appsec (14.629 s) : 14629000, 14629000
.   : milestone, 14629000,
iast (18.318 s) : 18318000, 18318000
.   : milestone, 18318000,
iast_GLOBAL (17.883 s) : 17883000, 17883000
.   : milestone, 17883000,
profiling (14.665 s) : 14665000, 14665000
.   : milestone, 14665000,
tracing (14.994 s) : 14994000, 14994000
.   : milestone, 14994000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.977 s [14.977 s, 14.977 s] -
appsec 14.789 s [14.789 s, 14.789 s] -188.0 ms (-1.3%)
iast 18.456 s [18.456 s, 18.456 s] 3.479 s (23.2%)
iast_GLOBAL 17.686 s [17.686 s, 17.686 s] 2.709 s (18.1%)
profiling 15.413 s [15.413 s, 15.413 s] 436.0 ms (2.9%)
tracing 14.659 s [14.659 s, 14.659 s] -318.0 ms (-2.1%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.505 s [15.505 s, 15.505 s] -
appsec 14.629 s [14.629 s, 14.629 s] -876.0 ms (-5.6%)
iast 18.318 s [18.318 s, 18.318 s] 2.813 s (18.1%)
iast_GLOBAL 17.883 s [17.883 s, 17.883 s] 2.378 s (15.3%)
profiling 14.665 s [14.665 s, 14.665 s] -840.0 ms (-5.4%)
tracing 14.994 s [14.994 s, 14.994 s] -511.0 ms (-3.3%)

amarziali
amarziali approved these changes Mar 23, 2026
View reviewed changes
Copy link
Contributor

@amarziali amarziali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not against this change. I'm wondering if, for the long run, moving it in a utility module under component would be better

PerfectSlayer
PerfectSlayer approved these changes Mar 23, 2026
View reviewed changes
Copy link
Contributor

@PerfectSlayer PerfectSlayer left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 praise: ‏Less things in dd-trace-core ❤️

@PerfectSlayer
Copy link
Contributor

PerfectSlayer commented Mar 23, 2026

I'm not against this change. I'm wondering if, for the long run, moving it in a utility module under component would be better

:communication is being actively refactor. So it makes sense to move it there while we are stripping it slowly but surely.

@mcculls
Copy link
Contributor Author

mcculls commented Mar 23, 2026

/merge

@gh-worker-devflow-routing-ef8351
Copy link

gh-worker-devflow-routing-ef8351 bot commented Mar 23, 2026 •
edited
Loading

View all feedbacks in Devflow UI.

2026-03-23 09:03:57 UTC ℹ️ Start processing command /merge

2026-03-23 09:04:01 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 3h (p90).

2026-03-23 10:54:15 UTC ℹ️ MergeQueue: Readding this merge request to the queue because another merge request processed with yours failed. No action is needed from your side.

2026-03-23 11:57:08 UTC ℹ️ MergeQueue: This merge request was merged

@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d bot merged commit b8015c2 into master Mar 23, 2026
741 of 747 checks passed
@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d bot deleted the mcculls/reuse-utf8-caching branch March 23, 2026 11:57
@github-actions github-actions bot added this to the 1.61.0 milestone Mar 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PerfectSlayer PerfectSlayer PerfectSlayer approved these changes

@amarziali amarziali amarziali approved these changes

@dougqh dougqh Awaiting requested review from dougqh

@mtoffl01 mtoffl01 Awaiting requested review from mtoffl01

Assignees

No one assigned

Labels

comp: core Tracer core tag: no release notes Changes to exclude from release notes type: refactoring

Projects

None yet

Milestone

1.61.0

Development

Successfully merging this pull request may close these issues.

3 participants

@mcculls @PerfectSlayer @amarziali