-
Notifications
You must be signed in to change notification settings - Fork 324
Move kotlinx coroutines advices to context tracking #10484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 63 metrics, 8 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.59.0-SNAPSHOT~5bc218146b, baseline=1.59.0-SNAPSHOT~02cc48359b
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.059 s) : 0, 1059431
Total [baseline] (10.996 s) : 0, 10996412
Agent [candidate] (1.057 s) : 0, 1056954
Total [candidate] (10.978 s) : 0, 10978009
section appsec
Agent [baseline] (1.229 s) : 0, 1229022
Total [baseline] (11.092 s) : 0, 11092069
Agent [candidate] (1.236 s) : 0, 1235955
Total [candidate] (11.104 s) : 0, 11104365
section iast
Agent [baseline] (1.24 s) : 0, 1239687
Total [baseline] (11.111 s) : 0, 11110745
Agent [candidate] (1.228 s) : 0, 1228464
Total [candidate] (11.174 s) : 0, 11174328
section profiling
Agent [baseline] (1.191 s) : 0, 1191071
Total [baseline] (10.945 s) : 0, 10944736
Agent [candidate] (1.182 s) : 0, 1182468
Total [candidate] (10.884 s) : 0, 10883584
gantt
title petclinic - break down per module: candidate=1.59.0-SNAPSHOT~5bc218146b, baseline=1.59.0-SNAPSHOT~02cc48359b
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.178 ms) : 0, 1178
crashtracking [candidate] (1.172 ms) : 0, 1172
BytebuddyAgent [baseline] (623.536 ms) : 0, 623536
BytebuddyAgent [candidate] (621.936 ms) : 0, 621936
AgentMeter [baseline] (28.731 ms) : 0, 28731
AgentMeter [candidate] (28.707 ms) : 0, 28707
GlobalTracer [baseline] (257.17 ms) : 0, 257170
GlobalTracer [candidate] (256.902 ms) : 0, 256902
AppSec [baseline] (32.906 ms) : 0, 32906
AppSec [candidate] (32.912 ms) : 0, 32912
Debugger [baseline] (62.054 ms) : 0, 62054
Debugger [candidate] (61.833 ms) : 0, 61833
Remote Config [baseline] (620.0 µs) : 0, 620
Remote Config [candidate] (610.073 µs) : 0, 610
Telemetry [baseline] (10.11 ms) : 0, 10110
Telemetry [candidate] (11.405 ms) : 0, 11405
Flare Poller [baseline] (7.653 ms) : 0, 7653
Flare Poller [candidate] (6.191 ms) : 0, 6191
section appsec
crashtracking [baseline] (1.178 ms) : 0, 1178
crashtracking [candidate] (1.18 ms) : 0, 1180
BytebuddyAgent [baseline] (650.208 ms) : 0, 650208
BytebuddyAgent [candidate] (654.408 ms) : 0, 654408
AgentMeter [baseline] (11.757 ms) : 0, 11757
AgentMeter [candidate] (11.886 ms) : 0, 11886
GlobalTracer [baseline] (256.827 ms) : 0, 256827
GlobalTracer [candidate] (258.346 ms) : 0, 258346
AppSec [baseline] (167.167 ms) : 0, 167167
AppSec [candidate] (167.502 ms) : 0, 167502
Debugger [baseline] (67.796 ms) : 0, 67796
Debugger [candidate] (68.189 ms) : 0, 68189
Remote Config [baseline] (654.496 µs) : 0, 654
Remote Config [candidate] (667.937 µs) : 0, 668
Telemetry [baseline] (9.269 ms) : 0, 9269
Telemetry [candidate] (9.339 ms) : 0, 9339
Flare Poller [baseline] (3.649 ms) : 0, 3649
Flare Poller [candidate] (3.682 ms) : 0, 3682
IAST [baseline] (25.377 ms) : 0, 25377
IAST [candidate] (25.484 ms) : 0, 25484
section iast
crashtracking [baseline] (1.188 ms) : 0, 1188
crashtracking [candidate] (1.181 ms) : 0, 1181
BytebuddyAgent [baseline] (801.415 ms) : 0, 801415
BytebuddyAgent [candidate] (791.204 ms) : 0, 791204
AgentMeter [baseline] (11.366 ms) : 0, 11366
AgentMeter [candidate] (11.236 ms) : 0, 11236
GlobalTracer [baseline] (249.978 ms) : 0, 249978
GlobalTracer [candidate] (248.392 ms) : 0, 248392
AppSec [baseline] (33.067 ms) : 0, 33067
AppSec [candidate] (29.677 ms) : 0, 29677
Debugger [baseline] (67.462 ms) : 0, 67462
Debugger [candidate] (71.74 ms) : 0, 71740
Remote Config [baseline] (551.299 µs) : 0, 551
Remote Config [candidate] (532.834 µs) : 0, 533
Telemetry [baseline] (8.566 ms) : 0, 8566
Telemetry [candidate] (8.649 ms) : 0, 8649
Flare Poller [baseline] (3.467 ms) : 0, 3467
Flare Poller [candidate] (3.548 ms) : 0, 3548
IAST [baseline] (27.118 ms) : 0, 27118
IAST [candidate] (26.918 ms) : 0, 26918
section profiling
ProfilingAgent [baseline] (99.537 ms) : 0, 99537
ProfilingAgent [candidate] (98.75 ms) : 0, 98750
crashtracking [baseline] (1.226 ms) : 0, 1226
crashtracking [candidate] (1.201 ms) : 0, 1201
BytebuddyAgent [baseline] (680.288 ms) : 0, 680288
BytebuddyAgent [candidate] (675.5 ms) : 0, 675500
AgentMeter [baseline] (8.763 ms) : 0, 8763
AgentMeter [candidate] (8.597 ms) : 0, 8597
GlobalTracer [baseline] (217.595 ms) : 0, 217595
GlobalTracer [candidate] (215.876 ms) : 0, 215876
AppSec [baseline] (32.568 ms) : 0, 32568
AppSec [candidate] (32.258 ms) : 0, 32258
Debugger [baseline] (67.905 ms) : 0, 67905
Debugger [candidate] (67.659 ms) : 0, 67659
Remote Config [baseline] (591.215 µs) : 0, 591
Remote Config [candidate] (589.963 µs) : 0, 590
Telemetry [baseline] (8.755 ms) : 0, 8755
Telemetry [candidate] (8.643 ms) : 0, 8643
Flare Poller [baseline] (3.794 ms) : 0, 3794
Flare Poller [candidate] (3.716 ms) : 0, 3716
Profiling [baseline] (100.1 ms) : 0, 100100
Profiling [candidate] (99.319 ms) : 0, 99319
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.59.0-SNAPSHOT~5bc218146b, baseline=1.59.0-SNAPSHOT~02cc48359b
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.053 s) : 0, 1053209
Total [baseline] (8.719 s) : 0, 8718554
Agent [candidate] (1.062 s) : 0, 1061623
Total [candidate] (8.734 s) : 0, 8733770
section iast
Agent [baseline] (1.237 s) : 0, 1236830
Total [baseline] (9.457 s) : 0, 9457141
Agent [candidate] (1.224 s) : 0, 1224167
Total [candidate] (9.374 s) : 0, 9373697
gantt
title insecure-bank - break down per module: candidate=1.59.0-SNAPSHOT~5bc218146b, baseline=1.59.0-SNAPSHOT~02cc48359b
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.177 ms) : 0, 1177
crashtracking [candidate] (1.182 ms) : 0, 1182
BytebuddyAgent [baseline] (620.813 ms) : 0, 620813
BytebuddyAgent [candidate] (625.711 ms) : 0, 625711
AgentMeter [baseline] (28.523 ms) : 0, 28523
AgentMeter [candidate] (28.901 ms) : 0, 28901
GlobalTracer [baseline] (256.62 ms) : 0, 256620
GlobalTracer [candidate] (257.813 ms) : 0, 257813
AppSec [baseline] (32.704 ms) : 0, 32704
AppSec [candidate] (33.158 ms) : 0, 33158
Debugger [baseline] (59.98 ms) : 0, 59980
Debugger [candidate] (61.236 ms) : 0, 61236
Remote Config [baseline] (609.846 µs) : 0, 610
Remote Config [candidate] (612.607 µs) : 0, 613
Telemetry [baseline] (9.785 ms) : 0, 9785
Telemetry [candidate] (10.029 ms) : 0, 10029
Flare Poller [baseline] (7.608 ms) : 0, 7608
Flare Poller [candidate] (7.566 ms) : 0, 7566
section iast
crashtracking [baseline] (1.191 ms) : 0, 1191
crashtracking [candidate] (1.179 ms) : 0, 1179
BytebuddyAgent [baseline] (797.062 ms) : 0, 797062
BytebuddyAgent [candidate] (790.11 ms) : 0, 790110
AgentMeter [baseline] (11.425 ms) : 0, 11425
AgentMeter [candidate] (11.119 ms) : 0, 11119
GlobalTracer [baseline] (250.024 ms) : 0, 250024
GlobalTracer [candidate] (247.49 ms) : 0, 247490
IAST [baseline] (27.288 ms) : 0, 27288
IAST [candidate] (26.854 ms) : 0, 26854
AppSec [baseline] (34.342 ms) : 0, 34342
AppSec [candidate] (33.737 ms) : 0, 33737
Debugger [baseline] (66.949 ms) : 0, 66949
Debugger [candidate] (65.72 ms) : 0, 65720
Remote Config [baseline] (563.517 µs) : 0, 564
Remote Config [candidate] (549.241 µs) : 0, 549
Telemetry [baseline] (8.802 ms) : 0, 8802
Telemetry [candidate] (8.54 ms) : 0, 8540
Flare Poller [baseline] (3.64 ms) : 0, 3640
Flare Poller [candidate] (3.52 ms) : 0, 3520
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 1 performance regressions! Performance is the same for 18 metrics, 16 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~5bc218146b, baseline=1.59.0-SNAPSHOT~02cc48359b
dateFormat X
axisFormat %s
section baseline
no_agent (19.171 ms) : 18971, 19371
. : milestone, 19171,
appsec (18.352 ms) : 18170, 18533
. : milestone, 18352,
code_origins (18.095 ms) : 17916, 18275
. : milestone, 18095,
iast (18.824 ms) : 18636, 19012
. : milestone, 18824,
profiling (18.813 ms) : 18625, 19002
. : milestone, 18813,
tracing (17.887 ms) : 17711, 18063
. : milestone, 17887,
section candidate
no_agent (18.17 ms) : 17984, 18357
. : milestone, 18170,
appsec (18.384 ms) : 18197, 18570
. : milestone, 18384,
code_origins (17.638 ms) : 17463, 17812
. : milestone, 17638,
iast (17.923 ms) : 17745, 18102
. : milestone, 17923,
profiling (18.633 ms) : 18444, 18823
. : milestone, 18633,
tracing (17.979 ms) : 17797, 18161
. : milestone, 17979,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~5bc218146b, baseline=1.59.0-SNAPSHOT~02cc48359b
dateFormat X
axisFormat %s
section baseline
no_agent (1.163 ms) : 1152, 1174
. : milestone, 1163,
iast (3.273 ms) : 3230, 3316
. : milestone, 3273,
iast_FULL (5.875 ms) : 5816, 5934
. : milestone, 5875,
iast_GLOBAL (3.41 ms) : 3358, 3462
. : milestone, 3410,
profiling (2.039 ms) : 2021, 2056
. : milestone, 2039,
tracing (1.81 ms) : 1794, 1826
. : milestone, 1810,
section candidate
no_agent (1.178 ms) : 1167, 1190
. : milestone, 1178,
iast (3.175 ms) : 3134, 3216
. : milestone, 3175,
iast_FULL (6.002 ms) : 5941, 6062
. : milestone, 6002,
iast_GLOBAL (3.569 ms) : 3507, 3632
. : milestone, 3569,
profiling (2.123 ms) : 2104, 2141
. : milestone, 2123,
tracing (1.894 ms) : 1878, 1911
. : milestone, 1894,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~5bc218146b, baseline=1.59.0-SNAPSHOT~02cc48359b
dateFormat X
axisFormat %s
section baseline
no_agent (15.64 s) : 15640000, 15640000
. : milestone, 15640000,
appsec (14.957 s) : 14957000, 14957000
. : milestone, 14957000,
iast (18.185 s) : 18185000, 18185000
. : milestone, 18185000,
iast_GLOBAL (17.653 s) : 17653000, 17653000
. : milestone, 17653000,
profiling (15.067 s) : 15067000, 15067000
. : milestone, 15067000,
tracing (14.902 s) : 14902000, 14902000
. : milestone, 14902000,
section candidate
no_agent (15.306 s) : 15306000, 15306000
. : milestone, 15306000,
appsec (14.821 s) : 14821000, 14821000
. : milestone, 14821000,
iast (18.383 s) : 18383000, 18383000
. : milestone, 18383000,
iast_GLOBAL (17.812 s) : 17812000, 17812000
. : milestone, 17812000,
profiling (15.112 s) : 15112000, 15112000
. : milestone, 15112000,
tracing (14.914 s) : 14914000, 14914000
. : milestone, 14914000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~5bc218146b, baseline=1.59.0-SNAPSHOT~02cc48359b
dateFormat X
axisFormat %s
section baseline
no_agent (1.478 ms) : 1467, 1490
. : milestone, 1478,
appsec (3.739 ms) : 3516, 3962
. : milestone, 3739,
iast (2.264 ms) : 2195, 2333
. : milestone, 2264,
iast_GLOBAL (2.298 ms) : 2229, 2368
. : milestone, 2298,
profiling (2.095 ms) : 2039, 2151
. : milestone, 2095,
tracing (2.062 ms) : 2009, 2116
. : milestone, 2062,
section candidate
no_agent (1.473 ms) : 1462, 1485
. : milestone, 1473,
appsec (3.69 ms) : 3474, 3907
. : milestone, 3690,
iast (2.253 ms) : 2184, 2322
. : milestone, 2253,
iast_GLOBAL (2.294 ms) : 2226, 2363
. : milestone, 2294,
profiling (2.079 ms) : 2024, 2134
. : milestone, 2079,
tracing (2.056 ms) : 2002, 2109
. : milestone, 2056,
|
PerfectSlayer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❔ question: Should this be ignored from the release notes?
What Does This Do
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]