fix: Use a real true value for headers #4161
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Send "t" for the truth-y value for these http headers. No functional behavior change here. I picked "t" since it's small so there's a super micro optimization for ya (saved 4 bytes per payload 😎 )
Motivation
We use
strconv.ParseBoolin the trace-agent to read these headers, while it's true that we default to "true" when there's any non-empty value here that can't be parsed we do also log a debug message about it when we fail to parse a non-empty value. This is a super minor nitpick but it can make debug trace-agent logs very noisy when talking to the go tracer.Reviewer's Checklist
./scripts/lint.shlocally.Unsure? Have a question? Request a review!