Skip to content

Conversation

ojproductions
Copy link
Contributor

@ojproductions ojproductions commented Oct 8, 2025

What does this PR do?

Fixes the Serverless Service Representation (SSR) for Go.
In serverless environments, sets peer.service tag for AWS managed service spans to {service type}.{region}.amazonaws.com:

  • SQS: sqs.us-east-1.amazonaws.com
  • SNS: sns.us-east-1.amazonaws.com
  • Kinesis: kinesis.us-east-1.amazonaws.com
  • Eventbridge: events.us-east-1.amazonaws.com
  • s3: bucket-name.s3.us-east-1.amazonaws.com
  • Dynamodb: dynamodb.us-east-1.amazonaws.com

Sets peer.service.source to peer.service for these serverless cases.
Adds LambdaFunctionName as field in tracer config to detect serverless cases.

Motivation

Prior to changes:
Screenshot 2025-10-14 at 2 21 12 PM

After changes: View represents customers' mental model of systems better.
Screenshot 2025-10-08 at 5 06 27 PM

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • New code is free of linting errors. You can check this by running ./scripts/lint.sh locally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@rithikanarayan rithikanarayan changed the title Fix Serverless Service Representation Implement Serverless Service Representation Oct 8, 2025
@rithikanarayan rithikanarayan changed the title Implement Serverless Service Representation Fix(ddtrace/tracer) Implement Serverless Service Representation Oct 8, 2025
@rithikanarayan rithikanarayan changed the title Fix(ddtrace/tracer) Implement Serverless Service Representation fix(ddtrace/tracer): Implement Serverless Service Representation Oct 8, 2025
@pr-commenter
Copy link

pr-commenter bot commented Oct 8, 2025

Benchmarks

Benchmark execution time: 2025-10-22 16:36:32

Comparing candidate commit e42f255 in PR branch APMSVLS-39 with baseline commit d6f7d92 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 24 metrics, 0 unstable metrics.

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Oct 8, 2025

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: e42f255 | Docs | Was this helpful? Give us feedback!

@ojproductions ojproductions force-pushed the APMSVLS-39 branch 2 times, most recently from 54824fb to 10016d7 Compare October 16, 2025 22:11
@ojproductions ojproductions marked this pull request as ready for review October 17, 2025 13:06
@ojproductions ojproductions requested review from a team as code owners October 17, 2025 13:06
Copy link
Contributor

@zarirhamza zarirhamza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, just some code quality changes

Copy link
Contributor

@zarirhamza zarirhamza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - nice change on the serverless check to improve performance

Copy link
Member

@darccio darccio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@genesor genesor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rithikanarayan
Copy link
Contributor

/merge

@dd-devflow-routing-codex
Copy link

dd-devflow-routing-codex bot commented Oct 22, 2025

View all feedbacks in Devflow UI.

2025-10-22 17:13:25 UTC ℹ️ Start processing command /merge


2025-10-22 17:13:30 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 18m (p90).


2025-10-22 17:28:30 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 4f683d0 into main Oct 22, 2025
280 of 286 checks passed
@dd-mergequeue dd-mergequeue bot deleted the APMSVLS-39 branch October 22, 2025 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants