-
Notifications
You must be signed in to change notification settings - Fork 484
fix(ddtrace/tracer): Implement Serverless Service Representation #4043
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
54824fb
to
10016d7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good, just some code quality changes
10016d7
to
ffcc27f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - nice change on the serverless check to improve performance
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, but consider @purple4reina's feedback in https://github.com/DataDog/dd-trace-go/pull/4043/files#r2449442341.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
View all feedbacks in Devflow UI.
The expected merge time in
|
What does this PR do?
Fixes the Serverless Service Representation (SSR) for Go.
In serverless environments, sets peer.service tag for AWS managed service spans to {service type}.{region}.amazonaws.com:
Sets peer.service.source to peer.service for these serverless cases.
Adds LambdaFunctionName as field in tracer config to detect serverless cases.
Motivation
Prior to changes:

After changes: View represents customers' mental model of systems better.

Reviewer's Checklist
./scripts/lint.sh
locally.Unsure? Have a question? Request a review!