-
Notifications
You must be signed in to change notification settings - Fork 484
draft: implement v1 trace protocol serialization #3947
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
hannahkm
wants to merge
60
commits into
hannahkm/msgp-payload-interface
Choose a base branch
from
hannahkm/implement-v1-serialization
base: hannahkm/msgp-payload-interface
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
draft: implement v1 trace protocol serialization #3947
hannahkm
wants to merge
60
commits into
hannahkm/msgp-payload-interface
from
hannahkm/implement-v1-serialization
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added msgp struct tags to fields in payloadV1 and traceChunk for serialization. - Introduced EncodeMsg methods for payloadV1 and spanListV1 to support msgp encoding. - Updated field types in traceChunk to enhance compatibility with msgp serialization.
BenchmarksBenchmark execution time: 2025-10-22 19:15:11 Comparing candidate commit ff24c1f in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 24 metrics, 0 unstable metrics. |
Contributor
darccio
reviewed
Sep 19, 2025
7 tasks
… buffer on failure
…utes, spans, etc.
…t-v1-serialization
can this be done more efficiently?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Implements the v1 trace protocol. Includes commits cherry-picked from #3932 since I closed my previous PR.
Motivation
https://datadoghq.atlassian.net/browse/LANGPLAT-750
Reviewer's Checklist
./scripts/lint.sh
locally.Unsure? Have a question? Request a review!