Fix null ref in IpcTcpProcessMessageIntegration #8023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing This PR (8023) and master. ✅ No regressions detected - check the details below Full Metrics ComparisonFakeDbCommand
HttpMessageHandler
Comparison explanationExecution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). Duration chartsFakeDbCommand (.NET Framework 4.8)gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8023) - mean (69ms) : 67, 70
master - mean (68ms) : 67, 70
section Bailout
This PR (8023) - mean (72ms) : 71, 73
master - mean (72ms) : 71, 74
section CallTarget+Inlining+NGEN
This PR (8023) - mean (1,008ms) : 965, 1052
master - mean (1,007ms) : 968, 1047
FakeDbCommand (.NET Core 3.1)gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8023) - mean (106ms) : 103, 110
master - mean (106ms) : 103, 109
section Bailout
This PR (8023) - mean (107ms) : 106, 108
master - mean (107ms) : 105, 108
section CallTarget+Inlining+NGEN
This PR (8023) - mean (746ms) : 692, 800
master - mean (743ms) : 680, 805
FakeDbCommand (.NET 6)gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8023) - mean (94ms) : 92, 96
master - mean (93ms) : 91, 96
section Bailout
This PR (8023) - mean (95ms) : 93, 97
master - mean (94ms) : 93, 95
section CallTarget+Inlining+NGEN
This PR (8023) - mean (716ms) : 682, 750
master - mean (715ms) : 682, 748
FakeDbCommand (.NET 8)gantt
title Execution time (ms) FakeDbCommand (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8023) - mean (92ms) : 90, 94
master - mean (92ms) : 90, 94
section Bailout
This PR (8023) - mean (93ms) : 92, 94
master - mean (93ms) : 92, 95
section CallTarget+Inlining+NGEN
This PR (8023) - mean (632ms) : 617, 647
master - mean (629ms) : 615, 644
HttpMessageHandler (.NET Framework 4.8)gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8023) - mean (195ms) : 190, 200
master - mean (194ms) : 190, 198
section Bailout
This PR (8023) - mean (198ms) : 194, 201
master - mean (198ms) : 194, 201
section CallTarget+Inlining+NGEN
This PR (8023) - mean (1,126ms) : 1057, 1196
master - mean (1,123ms) : 1045, 1201
HttpMessageHandler (.NET Core 3.1)gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8023) - mean (278ms) : 272, 284
master - mean (277ms) : 270, 283
section Bailout
This PR (8023) - mean (278ms) : 274, 282
master - mean (277ms) : 274, 280
section CallTarget+Inlining+NGEN
This PR (8023) - mean (933ms) : 889, 977
master - mean (926ms) : 877, 975
HttpMessageHandler (.NET 6)gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8023) - mean (272ms) : 265, 279
master - mean (271ms) : 266, 276
section Bailout
This PR (8023) - mean (272ms) : 266, 278
master - mean (270ms) : 267, 274
section CallTarget+Inlining+NGEN
This PR (8023) - mean (930ms) : 897, 964
master - mean (931ms) : 905, 958
HttpMessageHandler (.NET 8)gantt
title Execution time (ms) HttpMessageHandler (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8023) - mean (270ms) : 265, 275
master - mean (269ms) : 265, 273
section Bailout
This PR (8023) - mean (270ms) : 267, 274
master - mean (270ms) : 267, 274
section CallTarget+Inlining+NGEN
This PR (8023) - mean (825ms) : 803, 846
master - mean (826ms) : 805, 847
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
andrewlock
approved these changes
Dec 31, 2025
andrewlock
approved these changes
Dec 31, 2025
Member
andrewlock
left a comment
andrewlock
left a comment
There was a problem hiding this comment.
Thanks, LGTM. I see a few more cases of this in the routing integration, wonder if we need to update those too?
BenchmarksBenchmark execution time: 2025-12-31 15:16:44 Comparing candidate commit 2441613 in PR branch Found 7 performance improvements and 8 performance regressions! Performance is the same for 155 metrics, 16 unstable metrics. scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleMoreComplexBody net472
scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody netcoreapp3.1
scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces net6.0
scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice net6.0
scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice netcoreapp3.1
scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool net472
scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool net6.0
scenario:Benchmarks.Trace.DbCommandBenchmark.ExecuteNonQuery net6.0
scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch net472
scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark net6.0
scenario:Benchmarks.Trace.Log4netBenchmark.EnrichedLog net472
scenario:Benchmarks.Trace.SerilogBenchmark.EnrichedLog netcoreapp3.1
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Fixes a
NullReferenceExceptioninIpcTcpProcessMessageIntegration.Reason for change
Previously the code was just doing this:
tracer.InternalActiveScope is var scopeAnd then we were calling
scope.Span.Contextbut theSpanproperty can benull.Implementation details
Swapped to the property pattern
{ }which should address it.Test coverage
I didn't update any tests
Other details