FFL-908 Implement Flags OpenFeature provider for React Native #1106

yugisu-flux · 2026-01-15T16:41:36Z

What does this PR do?

Implement a Datadog Flags OpenFeature provider for React Native
Update the example apps to use the new OpenFeature provider
Refactor the Flags SDK: improve the documentation, remove some usage rough edges, update some data models

What's left:

Update the Old Architecture example app
Add a README to the OpenFeature provider's folder
Update LICENSE-3rdparty.csv

Motivation

Datadog Flags SDKs for all platforms are supposed to be consumable through OpenFeature SDKs.

https://datadoghq.atlassian.net/browse/FFL-908

Additional Notes

Anything else we should know when reviewing?

Review checklist (to be filled by reviewers)

Feature or bugfix MUST have appropriate tests
Make sure you discussed the feature or bugfix with the maintaining team in an Issue
Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)
If this PR is auto-generated, please make sure also to manually update the code related to the change

…-implement-flags-react-native-open-feature-provider

typotter

Nothing major, but some things to consider. 1 blocker (calling DDFlags.enable in the initialize method)

typotter · 2026-01-16T15:42:35Z

example-new-architecture/App.tsx

+          <ActivityIndicator />
+        </SafeAreaView>
+      }>
+      <OpenFeatureProvider suspendUntilReady>


🧑‍🍳

typotter · 2026-01-16T15:43:23Z

example-new-architecture/App.tsx

+          <Section title={greetingFlag.value.greeting}>
+            The title of this section is based on the <Text style={styles.highlight}>{greetingFlag.flagKey}</Text> feature flag.{'\n\n'}
+
+            If it's different from "Default greeting", then it is coming from the feature flag evaluation.


👍
consider adding the details.evaluation_reason here as well.

typotter · 2026-01-16T15:45:04Z

packages/core/src/flags/types.ts

 import type { FlagsClient } from './FlagsClient';

-export type DdFlagsType = {
+export interface DdFlagsType {


typotter · 2026-01-16T15:47:22Z

packages/core/src/flags/types.ts

+export type PrimitiveValue = null | boolean | string | number;
+type JsonObject = { [key: string]: JsonValue };
+type JsonArray = JsonValue[];
+/**
+ * Represents a JSON node value.
+ */
+export type JsonValue = PrimitiveValue | JsonObject | JsonArray;


🧑‍🍳

typotter · 2026-01-16T15:51:48Z

packages/core/src/flags/types.ts

     * This is typically a user ID, session ID, or device ID. The targeting key is used
     * by the feature flag service to determine which variation to serve.
+     *
+     * Pass an empty string if you don't have such an identifier.


a null (or undefined) value for the targetingKey is a valid state. Recommending to pass an empty string is good advice, mind you, so I agree with the suggestion.

The nuance is that the targeting key is only needed if there is experimental/traffic sharding in the matching flag allocation. In the future we may also allow for custom targeting using field(s) from the evaluation context.

typotter · 2026-01-16T15:55:59Z

packages/react-native-openfeature-provider/package.json

@@ -0,0 +1,86 @@
+{
+    "name": "@datadog/openfeature-react-native",


Suggested change

"name": "@datadog/openfeature-react-native",

"name": "@datadog/mobile-react-native-openfeature",

based on the naming pattern of other packages in the repo.

typotter · 2026-01-16T16:08:26Z

packages/react-native-openfeature-provider/src/provider.ts

+    }
+
+    async initialize(context: OFEvaluationContext = {}): Promise<void> {
+        await DdFlags.enable(this.options);


I don't think init should enable the DDFlags. We are enabling in the sample app, where the other SDK features are also enabled. Trying to initialize before the module is enabled is an error state in the mobile sdk spec. The doc details how to recover/proceed in such cases.

typotter · 2026-01-16T16:17:46Z

packages/react-native-openfeature-provider/src/provider.ts

+    private options: DatadogProviderOptions;
+    private flagsClient: FlagsClient | undefined;
+
+    constructor(options: DatadogProviderOptions = {}) {


In the android SDK, we wrote a constructor that takes a FlagsClient to wrap instead of passing around the clientName. Not suggesting to change it here, but something to consider

typotter · 2026-01-16T16:34:46Z

packages/react-native-openfeature-provider/src/provider.ts

+    }
+}
+
+const toDdContext = (context: OFEvaluationContext): DdEvaluationContext => {


Is it worth it to add tests for these converters?

typotter · 2026-01-16T16:45:10Z

packages/core/src/flags/types.ts

-     * Controls whether the feature flag evaluation feature is enabled.
-     */
-    enabled: boolean;
+export interface FlagsConfiguration {


Breaking change?

not a breaking change! (flags not merged to develop yet, right?)

typotter · 2026-01-16T16:51:05Z

packages/react-native-openfeature-provider/src/provider.ts

+        reason,
+        variant,
+        flagMetadata: allocationKey ? { allocationKey } : undefined,
+        errorCode: errorCode as ErrorCode | undefined,


This cast will become unsafe if the DD and OF errorCodes diverge. Consider an explicit converter/map or some other means of type safety

typotter · 2026-01-16T16:52:01Z

packages/react-native-openfeature-provider/src/provider.ts

+    clientName?: string;
+}
+
+export class DatadogProvider implements Provider {


Is there anything to do on shutdown here? The Provider interface also has an onClose method for when the provider is shutdown

typotter · 2026-01-16T16:52:51Z

packages/core/src/flags/types.ts

 /**
 * An error tha occurs during feature flag evaluation.


(while you're here)

Suggested change

/**

* An error tha occurs during feature flag evaluation.

/**

* An error that occurs during feature flag evaluation.

typotter · 2026-01-16T16:54:29Z

packages/core/src/flags/types.ts

-};
+}
+
+export type PrimitiveValue = null | boolean | string | number;


Do these types need to be exported from the module also?

typotter · 2026-01-16T16:57:35Z

packages/core/src/flags/internal.ts

+
+        if (!isPrimitiveValue) {
+            InternalLog.log(
+                `Non-primitive context value under "${key}" is not supported. Omitting this atribute from the evaluation context.`,


Suggested change

`Non-primitive context value under "${key}" is not supported. Omitting this atribute from the evaluation context.`,

`Non-primitive context value under "${key}" is not supported. Omitting this attribute from the evaluation context.`,

typotter · 2026-01-16T17:03:06Z

packages/react-native-openfeature-provider/src/provider.ts

+        newContext: OFEvaluationContext
+    ): Promise<void> {
+        if (!this.flagsClient) {
+            throw new Error(


Should this be an OpenFeature ProviderNotReadyError?

yugisu-flux added 2 commits January 15, 2026 18:18

Implement OpenFeature provider for React Native

75a485c

Update tests

8c63004

yugisu-flux requested review from dd-oleksii, marco-saia-datadog and sbarrio January 15, 2026 16:41

yugisu-flux self-assigned this Jan 15, 2026

yugisu-flux requested a review from a team as a code owner January 15, 2026 16:41

yugisu-flux requested a review from typotter January 15, 2026 16:44

Merge remote-tracking branch 'origin/feature/flags' into dima/FFL-908…

d5fcf47

…-implement-flags-react-native-open-feature-provider

typotter requested changes Jan 16, 2026

View reviewed changes

typotter reviewed Jan 16, 2026

View reviewed changes

		@@ -0,0 +1,86 @@
		{
		"name": "@datadog/openfeature-react-native",

	"name": "@datadog/openfeature-react-native",
	"name": "@datadog/mobile-react-native-openfeature",

	`Non-primitive context value under "${key}" is not supported. Omitting this atribute from the evaluation context.`,
	`Non-primitive context value under "${key}" is not supported. Omitting this attribute from the evaluation context.`,

FFL-908 Implement Flags OpenFeature provider for React Native #1106

Are you sure you want to change the base?

FFL-908 Implement Flags OpenFeature provider for React Native #1106

Uh oh!

Conversation

yugisu-flux commented Jan 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Motivation

Additional Notes

Review checklist (to be filled by reviewers)

Uh oh!

typotter left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

yugisu-flux commented Jan 15, 2026 •

edited

Loading