Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ssh2 to a version whose dependencies build on M1 #508

Merged
merged 1 commit into from
Mar 29, 2022

Conversation

technicalpickles
Copy link
Contributor

@technicalpickles technicalpickles commented Mar 24, 2022

What and why?

Our app has one optional dependency (cpu-features) that fails to build on M1, and I've been able to prod along fixed releases to eventually arrive here.

Previous efforts:

How?

This updates the ssh2 version to 1.8.0. I was also considering using ^1.4.0 to allow all 1.x releases.

Review checklist

  • Feature or bugfix MUST have appropriate tests (unit, integration)
  • [Synthetics] New releases of datadog-ci MUST be followed by a synthetics-ci-github-action release

@m-rousse
Copy link
Contributor

Hi @technicalpickles,
Thanks for your contribution!
You mention using version 1.18.0 in the description however the diff shows version 1.8.0 - just to make sure this is indeed version 1.8.0 that is expected?
Also, could you run yarn to update the lockfile and also commit the changes to yarn.lock?

@technicalpickles
Copy link
Contributor Author

@m-rousse thanks! It was supposed to be 1.8.0. I pushed up a change with the yarn.lock.

.node-version Outdated Show resolved Hide resolved
@technicalpickles
Copy link
Contributor Author

Sorry about that, I had changed that locally and didn't mean to commit.

I rebased, and pushed up a clean commit.

Copy link
Contributor

@m-rousse m-rousse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@m-rousse m-rousse merged commit 0b517f0 into DataDog:master Mar 29, 2022
@m-rousse
Copy link
Contributor

Thanks for the contribution @technicalpickles, it will be included in the next release of the package.

@ncreated ncreated mentioned this pull request Mar 29, 2022
@technicalpickles technicalpickles deleted the update-ssh2 branch March 29, 2022 14:14
@technicalpickles
Copy link
Contributor Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants