[SYNTH-16456] Make server result optional in Result
#1483
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
The source of truth for a result is the batch and not the server result (which we poll with the
/poll_results
endpoint).The server result corresponding to a batch result may happen to never be available, and in that case datadog-ci should fall back to the source of truth (the batch) instead of failing.
When such thing happens for a result, a warning log is printed (
The information for result {resultId} of test {publicId} was incomplete at the end of the batch.
) and theResult.result
property will beundefined
.How?
Result.result
optionalReview checklist