Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revamp SFN->SFN context injection #1471

Merged
merged 1 commit into from
Sep 27, 2024
Merged

Conversation

lym953
Copy link
Contributor

@lym953 lym953 commented Sep 26, 2024

What and why?

Revamps Step Function -> Step Function context injection:

  1. Change States.JsonMerge($$, $, false) to $$['Execution', 'State', 'StateMachine'], so the unnecessary Task won't be passed
  2. Revamp the case numbers. Currently the case numbers (1, 2.1, 2.2, 2.3, 3, 4.1, 4.2, 4.3) are in sync with the case numbers for SFN->Lambda context injection. However the cases for SFN->SFN is simpler because we are using a custom field name CONTEXT, which users are unlikely to use, so we can just not handle the rare case the CONTEXT field is set.
  3. Add test cases
  4. Add doc

Design doc: Fixing Step Function Instrumentation

Testing

Passed existing and new tests.

Review checklist

  • Feature or bugfix MUST have appropriate tests (unit, integration)

@lym953 lym953 requested review from a team as code owners September 26, 2024 18:10
@lym953 lym953 added serverless Related to [lambda, stepfunctions, cloud-run] enhancement New feature or request labels Sep 26, 2024
Copy link
Contributor

@avedmala avedmala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🚢

@datadog-datadog-prod-us1
Copy link

Datadog Report

Branch report: yiming.luo/fix-step-func-17
Commit report: 62a66ae
Test service: datadog-ci-tests

✅ 0 Failed, 404 Passed, 0 Skipped, 1m 28.4s Total duration (2m 5.59s time saved)

@lym953 lym953 merged commit d9bfb00 into master Sep 27, 2024
18 checks passed
@lym953 lym953 deleted the yiming.luo/fix-step-func-17 branch September 27, 2024 19:29
@Drarig29 Drarig29 mentioned this pull request Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request serverless Related to [lambda, stepfunctions, cloud-run]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants