Skip to content

[RUM] Clarify sample_rate rounding precision in retention filter spec #4298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
api-clients-generation-pipeline wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[RUM] Clarify sample_rate rounding precision in retention filter spec #4298

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
100 changes: 3 additions & 97 deletions .generator/schemas/v2/openapi.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71337,32 +71337,6 @@ components:
required:
- data
type: object
MonitorConfigPolicyDowntimePolicy:
additionalProperties: false
description: Downtime duration attributes of a monitor configuration policy.
properties:
max_duration_ms:
description: The maximum allowed downtime duration, in milliseconds.
example: 3600000
format: int64
minimum: 1
type: integer
required:
- max_duration_ms
type: object
MonitorConfigPolicyDowntimePolicyCreateRequest:
additionalProperties: false
description: Downtime duration attributes of a monitor configuration policy.
properties:
max_duration_ms:
description: The maximum allowed downtime duration, in milliseconds.
example: 3600000
format: int64
minimum: 1
type: integer
required:
- max_duration_ms
type: object
MonitorConfigPolicyEditData:
description: A monitor configuration policy data.
properties:
Expand Down Expand Up @@ -71400,12 +71374,10 @@ components:
description: Configuration for the policy.
oneOf:
- $ref: "#/components/schemas/MonitorConfigPolicyTagPolicy"
- $ref: "#/components/schemas/MonitorConfigPolicyDowntimePolicy"
MonitorConfigPolicyPolicyCreateRequest:
description: Configuration for the policy.
oneOf:
- $ref: "#/components/schemas/MonitorConfigPolicyTagPolicyCreateRequest"
- $ref: "#/components/schemas/MonitorConfigPolicyDowntimePolicyCreateRequest"
MonitorConfigPolicyResourceType:
default: monitor-config-policy
description: Monitor configuration policy resource type.
Expand Down Expand Up @@ -71434,7 +71406,6 @@ components:
$ref: "#/components/schemas/MonitorConfigPolicyResourceType"
type: object
MonitorConfigPolicyTagPolicy:
additionalProperties: false
description: Tag attributes of a monitor configuration policy.
properties:
tag_key:
Expand All @@ -71456,7 +71427,6 @@ components:
type: array
type: object
MonitorConfigPolicyTagPolicyCreateRequest:
additionalProperties: false
description: Tag attributes of a monitor configuration policy.
properties:
tag_key:
Expand All @@ -71483,18 +71453,13 @@ components:
type: object
MonitorConfigPolicyType:
default: tag
description: |-
The monitor configuration policy type.
`tag` enforces required tags on monitors.
`downtime` sets a maximum downtime duration for the organization.
description: The monitor configuration policy type.
enum:
- tag
- downtime
example: "tag"
type: string
x-enum-varnames:
- TAG
- DOWNTIME
MonitorDowntimeMatchResourceType:
default: downtime_match
description: Monitor Downtime Match resource type.
Expand Down Expand Up @@ -95702,7 +95667,7 @@ components:
example: true
type: boolean
trace_sample_rate:
description: The sample rate for the APM cross-product retention filter, between 0 and 100.
description: The sample rate for the APM cross-product retention filter, between 0 and 100. Values returned by the API are rounded to two decimal places.
example: 25.0
format: double
maximum: 100
Expand Down Expand Up @@ -96353,7 +96318,7 @@ components:
$ref: "#/components/schemas/RumRetentionFilterData"
type: object
RumRetentionFilterSampleRate:
description: The sample rate for a RUM retention filter, between 0.1 and 100.
description: The sample rate for a RUM retention filter, between 0.1 and 100. Values are truncated to one decimal place.
example: 50.5
format: double
maximum: 100
Expand Down Expand Up @@ -182142,16 +182107,6 @@ paths:
policy_type: tag
id: "00000000-0000-1234-0000-000000000000"
type: monitor-config-policy
downtime:
summary: Downtime duration policy
value:
data:
- attributes:
policy:
max_duration_ms: 3600000
policy_type: downtime
id: "00000000-0000-1234-0000-000000000000"
type: monitor-config-policy
schema:
$ref: "#/components/schemas/MonitorConfigPolicyListResponse"
description: OK
Expand Down Expand Up @@ -182194,15 +182149,6 @@ paths:
- staging
policy_type: tag
type: monitor-config-policy
downtime:
summary: Downtime duration policy
value:
data:
attributes:
policy:
max_duration_ms: 3600000
policy_type: downtime
type: monitor-config-policy
schema:
$ref: "#/components/schemas/MonitorConfigPolicyCreateRequest"
description: Create a monitor configuration policy request body.
Expand All @@ -182225,16 +182171,6 @@ paths:
policy_type: tag
id: "00000000-0000-1234-0000-000000000000"
type: monitor-config-policy
downtime:
summary: Downtime duration policy
value:
data:
attributes:
policy:
max_duration_ms: 3600000
policy_type: downtime
id: "00000000-0000-1234-0000-000000000000"
type: monitor-config-policy
schema:
$ref: "#/components/schemas/MonitorConfigPolicyResponse"
description: OK
Expand Down Expand Up @@ -182331,16 +182267,6 @@ paths:
policy_type: tag
id: "00000000-0000-1234-0000-000000000000"
type: monitor-config-policy
downtime:
summary: Downtime duration policy
value:
data:
attributes:
policy:
max_duration_ms: 3600000
policy_type: downtime
id: "00000000-0000-1234-0000-000000000000"
type: monitor-config-policy
schema:
$ref: "#/components/schemas/MonitorConfigPolicyResponse"
description: OK
Expand Down Expand Up @@ -182398,16 +182324,6 @@ paths:
policy_type: tag
id: 00000000-0000-1234-0000-000000000000
type: monitor-config-policy
downtime:
summary: Downtime duration policy
value:
data:
attributes:
policy:
max_duration_ms: 3600000
policy_type: downtime
id: 00000000-0000-1234-0000-000000000000
type: monitor-config-policy
schema:
$ref: "#/components/schemas/MonitorConfigPolicyEditRequest"
description: Description of the update.
Expand All @@ -182430,16 +182346,6 @@ paths:
policy_type: tag
id: "00000000-0000-1234-0000-000000000000"
type: monitor-config-policy
downtime:
summary: Downtime duration policy
value:
data:
attributes:
policy:
max_duration_ms: 3600000
policy_type: downtime
id: "00000000-0000-1234-0000-000000000000"
type: monitor-config-policy
schema:
$ref: "#/components/schemas/MonitorConfigPolicyResponse"
description: OK
Expand Down
44 changes: 0 additions & 44 deletions examples/v2/monitors/CreateMonitorConfigPolicy_1934105875.java
View file
Open in desktop

This file was deleted.

3 changes: 1 addition & 2 deletions src/main/java/com/datadog/api/client/v2/model/MonitorConfigPolicyAttributeCreateRequest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,8 +78,7 @@ public MonitorConfigPolicyAttributeCreateRequest policyType(MonitorConfigPolicyT
}

/**
* The monitor configuration policy type. <code>tag</code> enforces required tags on monitors.
* <code>downtime</code> sets a maximum downtime duration for the organization.
* The monitor configuration policy type.
*
* @return policyType
*/
Expand Down
3 changes: 1 addition & 2 deletions src/main/java/com/datadog/api/client/v2/model/MonitorConfigPolicyAttributeEditRequest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,8 +76,7 @@ public MonitorConfigPolicyAttributeEditRequest policyType(MonitorConfigPolicyTyp
}

/**
* The monitor configuration policy type. <code>tag</code> enforces required tags on monitors.
* <code>downtime</code> sets a maximum downtime duration for the organization.
* The monitor configuration policy type.
*
* @return policyType
*/
Expand Down
3 changes: 1 addition & 2 deletions src/main/java/com/datadog/api/client/v2/model/MonitorConfigPolicyAttributeResponse.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,8 +63,7 @@ public MonitorConfigPolicyAttributeResponse policyType(MonitorConfigPolicyType p
}

/**
* The monitor configuration policy type. <code>tag</code> enforces required tags on monitors.
* <code>downtime</code> sets a maximum downtime duration for the organization.
* The monitor configuration policy type.
*
* @return policyType
*/
Expand Down
90 changes: 0 additions & 90 deletions src/main/java/com/datadog/api/client/v2/model/MonitorConfigPolicyDowntimePolicy.java
View file
Open in desktop

This file was deleted.

Loading
Loading