Skip to content

fix(aix): harden embedded OpenSSL build flags - #53885

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 3 commits into
mainfrom
pgimalac/aix-openssl-hardening-flags
Jul 21, 2026
Merged

fix(aix): harden embedded OpenSSL build flags#53885
gh-worker-dd-mergequeue-cf854d[bot] merged 3 commits into
mainfrom
pgimalac/aix-openssl-hardening-flags

Conversation

@pgimalac

Copy link
Copy Markdown
Member

What does this PR do?

Builds the AIX embedded OpenSSL with the same hardening flags used by the Linux omnibus/bazel build.

Motivation

The AIX OpenSSL build previously used default settings, unlike Linux's deps/openssl.BUILD.bazel DEFAULT_CONFIG which strips legacy/weak algorithms (IDEA, MDC2, RC5, SSLv3) and the GOST engine, and loads zlib dynamically instead of linking it at build time. This was an unintentional divergence, not a deliberate AIX adaptation.

Describe how you validated your changes

A full AIX build was made and validated on an AIX host.

Additional Notes

Match the Linux omnibus/bazel build (deps/openssl.BUILD.bazel
DEFAULT_CONFIG): disable legacy/weak algorithms (IDEA, MDC2, RC5,
SSLv3) and the GOST engine, and load zlib dynamically instead of
linking it at build time.
@pgimalac pgimalac added qa/done QA done before merge and regressions are covered by tests changelog/no-changelog No changelog entry needed labels Jul 21, 2026
@dd-octo-sts dd-octo-sts Bot added the internal Identify a non-fork PR label Jul 21, 2026
@github-actions github-actions Bot added the short review PR is simple enough to be reviewed quickly label Jul 21, 2026
chatgpt-codex-connector[bot]

This comment was marked as outdated.

@dd-octo-sts

dd-octo-sts Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Files inventory check summary

File checks results against ancestor f06fb43d:

Results for datadog-agent_7.83.0~devel.git.246.a432ae2.pipeline.125868087-1_amd64.deb:

No change detected

pgimalac added 2 commits July 21, 2026 14:36
… AIX)

AIX only ships shared libraries as members inside .a archives, and
OpenSSL's zlib dlopen is generic Unix code that never uses AIX's
RTLD_MEMBER flag needed to open them. zlib-dynamic silently never
loads zlib here (verified: OpenSSL treats a failed DSO_load as
"zlib unavailable", not fatal, so this wasn't causing any visible
failure) - no-zlib is honest about it instead. No functional change:
TLS compression is disabled by default anyway.
@pgimalac
pgimalac marked this pull request as ready for review July 21, 2026 16:09
@pgimalac
pgimalac requested review from a team as code owners July 21, 2026 16:09
@pgimalac
pgimalac requested a review from jinh-labs July 21, 2026 16:09
@pgimalac

Copy link
Copy Markdown
Member Author

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Jul 21, 2026

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-07-21 20:53:15 UTC ℹ️ Start processing command /merge


2026-07-21 20:53:19 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 1h (p90).


2026-07-21 21:35:05 UTC ℹ️ MergeQueue: Readding this merge request to the queue because another merge request processed with yours failed. No action is needed from your side.


2026-07-21 22:23:22 UTC ℹ️ MergeQueue: This merge request was merged

@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot merged commit 04e94f0 into main Jul 21, 2026
255 of 263 checks passed
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot deleted the pgimalac/aix-openssl-hardening-flags branch July 21, 2026 22:23
@github-actions github-actions Bot added this to the 7.83.0 milestone Jul 21, 2026
@cit-pr-commenter-54b7da

Copy link
Copy Markdown

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: f8c42185-c078-4218-b8ee-6cbb38251943

Baseline: d7c6227
Comparison: 04e94f0
Diff

❌ Experiments with retried target crashes

This is a critical error. One or more replicates failed with a non-zero exit code. These replicates may have been retried. See Replicate Execution Details for more information.

  • quality_gate_idle_all_features

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
quality_gate_security_mean_fs_load memory utilization +0.25 [+0.21, +0.28] 1 Logs bounds checks dashboard
quality_gate_private_action_runner memory utilization +0.14 [+0.02, +0.26] 1 Logs bounds checks dashboard
quality_gate_security_no_fs_load memory utilization +0.08 [-0.01, +0.17] 1 Logs bounds checks dashboard
quality_gate_security_idle memory utilization +0.07 [+0.01, +0.13] 1 Logs bounds checks dashboard
quality_gate_metrics_logs memory utilization -0.12 [-0.37, +0.12] 1 Logs bounds checks dashboard
quality_gate_idle_all_features memory utilization -0.19 [-0.29, -0.10] 1 Logs bounds checks dashboard
quality_gate_idle memory utilization -0.22 [-0.27, -0.16] 1 Logs bounds checks dashboard
quality_gate_logs % cpu utilization -0.74 [-1.74, +0.26] 1 Logs bounds checks dashboard

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed observed_value links
quality_gate_idle intake_connections 10/10 3 ≤ 4 bounds checks dashboard
quality_gate_idle memory_usage 10/10 148.55MiB ≤ 154MiB bounds checks dashboard
quality_gate_idle total_bytes_received 10/10 730.73KiB ≤ 819.20KiB bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 3 ≤ 4 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 494.61MiB ≤ 495MiB bounds checks dashboard
quality_gate_idle_all_features total_bytes_received 10/10 1.10MiB ≤ 1.25MiB bounds checks dashboard
quality_gate_logs intake_connections 10/10 4 ≤ 6 bounds checks dashboard
quality_gate_logs memory_usage 10/10 188.05MiB ≤ 195MiB bounds checks dashboard
quality_gate_logs missed_bytes 10/10 0B = 0B bounds checks dashboard
quality_gate_logs total_bytes_received 10/10 264.23MiB ≤ 292MiB bounds checks dashboard
quality_gate_metrics_logs cpu_usage 10/10 384.20 ≤ 2000 bounds checks dashboard
quality_gate_metrics_logs intake_connections 10/10 3 ≤ 6 bounds checks dashboard
quality_gate_metrics_logs memory_usage 10/10 412.31MiB ≤ 430MiB bounds checks dashboard
quality_gate_metrics_logs missed_bytes 10/10 0B = 0B bounds checks dashboard
quality_gate_metrics_logs total_bytes_received 10/10 0.93GiB ≤ 1.04GiB bounds checks dashboard
quality_gate_private_action_runner memory_usage 10/10 72.34MiB ≤ 75MiB bounds checks dashboard
quality_gate_security_idle cpu_usage 10/10 30.83 ≤ 100 bounds checks dashboard
quality_gate_security_idle memory_usage 10/10 300.50MiB ≤ 330MiB bounds checks dashboard
quality_gate_security_mean_fs_load cpu_usage 10/10 63.89 ≤ 200 bounds checks dashboard
quality_gate_security_mean_fs_load memory_usage 10/10 280.58MiB ≤ 310MiB bounds checks dashboard
quality_gate_security_no_fs_load cpu_usage 10/10 24.09 ≤ 100 bounds checks dashboard
quality_gate_security_no_fs_load memory_usage 10/10 284.31MiB ≤ 320MiB bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

Replicate Execution Details

We run multiple replicates for each experiment/variant. However, we allow replicates to be automatically retried if there are any failures, up to 8 times, at which point the replicate is marked dead and we are unable to run analysis for the entire experiment. We call each of these attempts at running replicates a replicate execution. This section lists all replicate executions that failed due to the target crashing or being oom killed.

Note: In the below tables we bucket failures by experiment, variant, and failure type. For each of these buckets we list out the replicate indexes that failed with an annotation signifying how many times said replicate failed with the given failure mode. In the below example the baseline variant of the experiment named experiment_with_failures had two replicates that failed by oom kills. Replicate 0, which failed 8 executions, and replicate 1 which failed 6 executions, all with the same failure mode.

Experiment Variant Replicates Failure Logs Debug Dashboard
experiment_with_failures baseline 0 (x8) 1 (x6) Oom killed Debug Dashboard

The debug dashboard links will take you to a debugging dashboard specifically designed to investigate replicate execution failures.

❌ Retried Normal Replicate Execution Failures (non-profiling)

Experiment Variant Replicates Failure Debug Dashboard
quality_gate_idle_all_features baseline 0 (x2), 7 Oom killed Debug Dashboard
quality_gate_idle_all_features comparison 3, 4, 0 Oom killed Debug Dashboard

❌ Retried Profiling Replicate Execution Failures (ddprof)

Note: Profiling replicas may still be executing. See the debug dashboard for up to date status.

Experiment Variant Replicates Failure Debug Dashboard
quality_gate_idle_all_features baseline 10 Oom killed Debug Dashboard
quality_gate_idle_all_features comparison 10 Oom killed Debug Dashboard
quality_gate_logs baseline 10 Oom killed Debug Dashboard
quality_gate_metrics_logs baseline 10 Oom killed Debug Dashboard
quality_gate_security_mean_fs_load baseline 10 Crashed (exit code: 134) Debug Dashboard

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_security_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_idle, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_mean_fs_load, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_mean_fs_load, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_private_action_runner, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_no_fs_load, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_no_fs_load, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/no-changelog No changelog entry needed internal Identify a non-fork PR qa/done QA done before merge and regressions are covered by tests short review PR is simple enough to be reviewed quickly team/agent-build team/agent-runtimes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants