pkg/collector/corechecks/cluster/ksm: optimize ownerTags

[AlexanderYastrebov]

What does this PR do?

• optimize allocations
• check ReplicaSet name pattern used by modern Kubernetes first
• remove redundant Job index pattern check
  (name can not contain '+', earlier dash index ensures suffix
  does not start with '-' and strconv.Atoi only allows '[0-9]')

goos: darwin
goarch: arm64
pkg: github.com/DataDog/datadog-agent/pkg/collector/corechecks/cluster/ksm
cpu: Apple M4 Max
                        │    HEAD~1    │                HEAD                 │
                        │    sec/op    │   sec/op     vs base                │
OwnerTags/ReplicaSet-16   106.70n ± 1%   80.68n ± 1%  -24.38% (p=0.000 n=10)
OwnerTags/Job-16           96.45n ± 1%   59.68n ± 1%  -38.13% (p=0.000 n=10)
geomean                    101.4n        69.39n       -31.60%

                        │   HEAD~1    │                HEAD                │
                        │    B/op     │    B/op     vs base                │
OwnerTags/ReplicaSet-16   104.00 ± 0%   88.00 ± 0%  -15.38% (p=0.000 n=10)
OwnerTags/Job-16           88.00 ± 0%   72.00 ± 0%  -18.18% (p=0.000 n=10)
geomean                    95.67        79.60       -16.79%

                        │   HEAD~1   │                HEAD                │
                        │ allocs/op  │ allocs/op   vs base                │
OwnerTags/ReplicaSet-16   4.000 ± 0%   3.000 ± 0%  -25.00% (p=0.000 n=10)
OwnerTags/Job-16          4.000 ± 0%   3.000 ± 0%  -25.00% (p=0.000 n=10)
geomean                   4.000        3.000       -25.00%

Motivation

Follow up on #43407

Describe how you validated your changes

% go test ./pkg/collector/corechecks/cluster/ksm/ ./pkg/util/kubernetes/ -tags=kubeapiserver,test -count=1 
ok      github.com/DataDog/datadog-agent/pkg/collector/corechecks/cluster/ksm   0.984s
ok      github.com/DataDog/datadog-agent/pkg/util/kubernetes    0.963s

Additional Notes

[agent-platform-auto-pr]

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor fcb5852

Successful checks

Info

	Quality gate	Delta	On disk size (MiB)	Delta	On wire size (MiB)
✅	agent_deb_amd64	DataNotFound	$${705.02}$$ < $${717.44}$$	DataNotFound	$${172.92}$$ < $${177.37}$$
✅	agent_deb_amd64_fips	DataNotFound	$${699.86}$$ < $${711.66}$$	DataNotFound	$${171.67}$$ < $${174.84}$$
✅	agent_heroku_amd64	DataNotFound	$${326.33}$$ < $${337.57}$$	DataNotFound	$${87.33}$$ < $${90.78}$$
✅	agent_msi	DataNotFound	$${981.55}$$ < $${1015.38}$$	DataNotFound	$${142.09}$$ < $${149.42}$$
✅	agent_rpm_amd64	DataNotFound	$${705.01}$$ < $${717.41}$$	DataNotFound	$${175.92}$$ < $${178.01}$$
✅	agent_rpm_amd64_fips	DataNotFound	$${699.84}$$ < $${711.64}$$	DataNotFound	$${173.98}$$ < $${177.26}$$
✅	agent_rpm_arm64	DataNotFound	$${690.69}$$ < $${702.19}$$	DataNotFound	$${159.71}$$ < $${163.22}$$
✅	agent_rpm_arm64_fips	DataNotFound	$${686.5}$$ < $${697.6}$$	DataNotFound	$${159.07}$$ < $${162.68}$$
✅	agent_suse_amd64	DataNotFound	$${705.01}$$ < $${717.41}$$	DataNotFound	$${175.92}$$ < $${178.01}$$
✅	agent_suse_amd64_fips	DataNotFound	$${699.84}$$ < $${711.64}$$	DataNotFound	$${173.98}$$ < $${177.26}$$
✅	agent_suse_arm64	DataNotFound	$${690.69}$$ < $${702.19}$$	DataNotFound	$${159.71}$$ < $${163.22}$$
✅	agent_suse_arm64_fips	DataNotFound	$${686.5}$$ < $${697.6}$$	DataNotFound	$${159.07}$$ < $${162.68}$$
✅	docker_agent_amd64	DataNotFound	$${767.36}$$ < $${769.92}$$	DataNotFound	$${260.59}$$ < $${261.52}$$
✅	docker_agent_arm64	DataNotFound	$${777.3}$$ < $${779.46}$$	DataNotFound	$${250.77}$$ < $${251.72}$$
✅	docker_agent_jmx_amd64	DataNotFound	$${958.24}$$ < $${960.8}$$	DataNotFound	$${329.22}$$ < $${330.15}$$
✅	docker_agent_jmx_arm64	DataNotFound	$${956.9}$$ < $${958.93}$$	DataNotFound	$${315.4}$$ < $${316.35}$$
✅	docker_cluster_agent_amd64	DataNotFound	$${178.85}$$ < $${207.49}$$	DataNotFound	$${63.16}$$ < $${70.2}$$
✅	docker_cluster_agent_arm64	DataNotFound	$${196.33}$$ < $${223.38}$$	DataNotFound	$${59.88}$$ < $${66.42}$$
✅	docker_cws_instrumentation_amd64	DataNotFound	$${7.07}$$ < $${7.12}$$	DataNotFound	$${2.95}$$ < $${3.29}$$
✅	docker_cws_instrumentation_arm64	DataNotFound	$${6.69}$$ < $${6.92}$$	DataNotFound	$${2.7}$$ < $${3.07}$$
✅	docker_dogstatsd_amd64	DataNotFound	$${38.58}$$ < $${39.3}$$	DataNotFound	$${14.91}$$ < $${15.76}$$
✅	docker_dogstatsd_arm64	DataNotFound	$${37.24}$$ < $${37.94}$$	DataNotFound	$${14.36}$$ < $${14.83}$$
✅	dogstatsd_deb_amd64	DataNotFound	$${29.8}$$ < $${30.53}$$	DataNotFound	$${7.86}$$ < $${8.75}$$
✅	dogstatsd_deb_arm64	DataNotFound	$${28.31}$$ < $${29.11}$$	DataNotFound	$${6.8}$$ < $${7.71}$$
✅	dogstatsd_rpm_amd64	DataNotFound	$${29.8}$$ < $${30.53}$$	DataNotFound	$${7.87}$$ < $${8.76}$$
✅	dogstatsd_suse_amd64	DataNotFound	$${29.8}$$ < $${30.53}$$	DataNotFound	$${7.87}$$ < $${8.76}$$
✅	iot_agent_deb_amd64	DataNotFound	$${42.55}$$ < $${43.19}$$	DataNotFound	$${11.12}$$ < $${11.98}$$
✅	iot_agent_deb_arm64	DataNotFound	$${40.29}$$ < $${40.92}$$	DataNotFound	$${9.57}$$ < $${10.45}$$
✅	iot_agent_deb_armhf	DataNotFound	$${40.2}$$ < $${40.86}$$	DataNotFound	$${9.68}$$ < $${10.56}$$
✅	iot_agent_rpm_amd64	DataNotFound	$${42.56}$$ < $${43.19}$$	DataNotFound	$${11.13}$$ < $${12.0}$$
✅	iot_agent_suse_amd64	DataNotFound	$${42.56}$$ < $${43.19}$$	DataNotFound	$${11.13}$$ < $${12.0}$$

[cit-pr-commenter]

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 03806487-906a-44f6-b49c-a13972a2ff20

Baseline: cf0c253
Comparison: 5da8635
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	docker_containers_cpu	% cpu utilization	+2.22	[-0.78, +5.23]	1	Logs

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	docker_containers_cpu	% cpu utilization	+2.22	[-0.78, +5.23]	1	Logs
➖	otlp_ingest_logs	memory utilization	+0.48	[+0.39, +0.57]	1	Logs
➖	quality_gate_idle	memory utilization	+0.42	[+0.37, +0.47]	1	Logs bounds checks dashboard
➖	tcp_syslog_to_blackhole	ingress throughput	+0.39	[+0.34, +0.45]	1	Logs
➖	ddot_logs	memory utilization	+0.37	[+0.31, +0.43]	1	Logs
➖	quality_gate_metrics_logs	memory utilization	+0.26	[+0.06, +0.47]	1	Logs bounds checks dashboard
➖	quality_gate_logs	% cpu utilization	+0.26	[-1.19, +1.71]	1	Logs bounds checks dashboard
➖	uds_dogstatsd_20mb_12k_contexts_20_senders	memory utilization	+0.14	[+0.09, +0.20]	1	Logs
➖	otlp_ingest_metrics	memory utilization	+0.13	[-0.01, +0.27]	1	Logs
➖	ddot_metrics_sum_cumulative	memory utilization	+0.09	[-0.05, +0.24]	1	Logs
➖	ddot_metrics	memory utilization	+0.08	[-0.14, +0.30]	1	Logs
➖	file_to_blackhole_1000ms_latency	egress throughput	+0.01	[-0.39, +0.42]	1	Logs
➖	file_to_blackhole_500ms_latency	egress throughput	+0.01	[-0.36, +0.38]	1	Logs
➖	uds_dogstatsd_to_api_v3	ingress throughput	+0.01	[-0.12, +0.14]	1	Logs
➖	file_to_blackhole_0ms_latency	egress throughput	+0.00	[-0.36, +0.36]	1	Logs
➖	uds_dogstatsd_to_api	ingress throughput	-0.00	[-0.13, +0.12]	1	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	-0.00	[-0.08, +0.07]	1	Logs
➖	file_to_blackhole_100ms_latency	egress throughput	-0.05	[-0.10, +0.00]	1	Logs
➖	ddot_metrics_sum_delta	memory utilization	-0.08	[-0.28, +0.13]	1	Logs
➖	file_tree	memory utilization	-0.10	[-0.15, -0.06]	1	Logs
➖	docker_containers_memory	memory utilization	-0.16	[-0.24, -0.07]	1	Logs
➖	quality_gate_idle_all_features	memory utilization	-0.27	[-0.32, -0.23]	1	Logs bounds checks dashboard
➖	ddot_metrics_sum_cumulativetodelta_exporter	memory utilization	-0.34	[-0.57, -0.10]	1	Logs

Bounds Checks: ✅ Passed

perf	experiment	bounds_check_name	replicates_passed	links
✅	docker_containers_cpu	simple_check_run	10/10
✅	docker_containers_memory	memory_usage	10/10
✅	docker_containers_memory	simple_check_run	10/10
✅	file_to_blackhole_0ms_latency	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency	lost_bytes	10/10
✅	file_to_blackhole_1000ms_latency	memory_usage	10/10
✅	file_to_blackhole_100ms_latency	lost_bytes	10/10
✅	file_to_blackhole_100ms_latency	memory_usage	10/10
✅	file_to_blackhole_500ms_latency	lost_bytes	10/10
✅	file_to_blackhole_500ms_latency	memory_usage	10/10
✅	quality_gate_idle	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_idle	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_logs	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_logs	lost_bytes	10/10	bounds checks dashboard
✅	quality_gate_logs	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_metrics_logs	cpu_usage	10/10	bounds checks dashboard
✅	quality_gate_metrics_logs	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_metrics_logs	lost_bytes	10/10	bounds checks dashboard
✅	quality_gate_metrics_logs	memory_usage	10/10	bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

• quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.