Skip to content

Conversation

@gjulianm
Copy link
Contributor

@gjulianm gjulianm commented Nov 28, 2025

What does this PR do?

This PR fixes a bug with the retrieval of the sp_process_metrics_request_timeout setting, which was querying SystemProbe config instead of the agent config, where it is defined.

Motivation

Fix configuration

Describe how you validated your changes

Additional Notes

@gjulianm gjulianm self-assigned this Nov 28, 2025
@github-actions github-actions bot added team/ebpf-platform short review PR is simple enough to be reviewed quickly labels Nov 28, 2025
@agent-platform-auto-pr
Copy link
Contributor

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 5a22e48

Successful checks

Info

Quality gate Delta On disk size (MiB) Delta On wire size (MiB)
agent_deb_amd64 $${-0}$$ $${705.36}$$ < $${717.44}$$ $${+0.03}$$ $${172.87}$$ < $${177.37}$$
agent_deb_amd64_fips $${-0}$$ $${700.2}$$ < $${711.66}$$ $${-0.01}$$ $${171.74}$$ < $${174.84}$$
agent_heroku_amd64 $${-0}$$ $${326.74}$$ < $${337.57}$$ $${+0}$$ $${87.24}$$ < $${90.78}$$
agent_msi $${-0}$$ $${981.13}$$ < $${1015.38}$$ $${-0}$$ $${142.05}$$ < $${149.42}$$
agent_rpm_amd64 $${-0}$$ $${705.35}$$ < $${717.41}$$ $${+0.02}$$ $${175.91}$$ < $${178.01}$$
agent_rpm_amd64_fips $${-0}$$ $${700.19}$$ < $${711.64}$$ $${+0.02}$$ $${174.01}$$ < $${177.26}$$
agent_rpm_arm64 $${+0}$$ $${690.72}$$ < $${702.19}$$ $${+0.02}$$ $${159.76}$$ < $${163.22}$$
agent_rpm_arm64_fips $${+0}$$ $${686.59}$$ < $${697.6}$$ $${-0}$$ $${159.12}$$ < $${162.68}$$
agent_suse_amd64 $${-0}$$ $${705.35}$$ < $${717.41}$$ $${+0.02}$$ $${175.91}$$ < $${178.01}$$
agent_suse_amd64_fips $${-0}$$ $${700.19}$$ < $${711.64}$$ $${+0.02}$$ $${174.01}$$ < $${177.26}$$
agent_suse_arm64 $${+0}$$ $${690.72}$$ < $${702.19}$$ $${+0.02}$$ $${159.76}$$ < $${163.22}$$
agent_suse_arm64_fips $${+0}$$ $${686.59}$$ < $${697.6}$$ $${-0}$$ $${159.12}$$ < $${162.68}$$
docker_agent_amd64 $${-0}$$ $${767.71}$$ < $${769.92}$$ $${+0}$$ $${260.71}$$ < $${261.52}$$
docker_agent_arm64 $${+0}$$ $${777.4}$$ < $${779.46}$$ $${-0}$$ $${250.9}$$ < $${251.72}$$
docker_agent_jmx_amd64 $${-0}$$ $${958.59}$$ < $${960.8}$$ $${+0}$$ $${329.35}$$ < $${330.15}$$
docker_agent_jmx_arm64 $${+0}$$ $${957.0}$$ < $${958.93}$$ $${+0}$$ $${315.52}$$ < $${316.35}$$
docker_cluster_agent_amd64 $${-0}$$ $${178.32}$$ < $${207.49}$$ $${+0}$$ $${63.0}$$ < $${70.2}$$
docker_cluster_agent_arm64 $${-0}$$ $${195.83}$$ < $${223.38}$$ $${+0}$$ $${59.74}$$ < $${66.42}$$
docker_cws_instrumentation_amd64 $${-0}$$ $${7.07}$$ < $${7.12}$$ $${-0}$$ $${2.95}$$ < $${3.29}$$
docker_cws_instrumentation_arm64 $${-0}$$ $${6.69}$$ < $${6.92}$$ $${-0}$$ $${2.7}$$ < $${3.07}$$
docker_dogstatsd_amd64 $${-0}$$ $${38.57}$$ < $${39.3}$$ $${+0}$$ $${14.9}$$ < $${15.76}$$
docker_dogstatsd_arm64 $${0}$$ $${37.24}$$ < $${37.94}$$ $${-0}$$ $${14.36}$$ < $${14.83}$$
dogstatsd_deb_amd64 $${-0}$$ $${29.79}$$ < $${30.53}$$ $${-0}$$ $${7.86}$$ < $${8.75}$$
dogstatsd_deb_arm64 $${-0}$$ $${28.3}$$ < $${29.11}$$ $${+0}$$ $${6.8}$$ < $${7.71}$$
dogstatsd_rpm_amd64 $${-0}$$ $${29.79}$$ < $${30.53}$$ $${+0}$$ $${7.87}$$ < $${8.76}$$
dogstatsd_suse_amd64 $${-0}$$ $${29.79}$$ < $${30.53}$$ $${+0}$$ $${7.87}$$ < $${8.76}$$
iot_agent_deb_amd64 $${-0}$$ $${42.54}$$ < $${43.19}$$ $${-0}$$ $${11.11}$$ < $${11.98}$$
iot_agent_deb_arm64 $${-0}$$ $${40.28}$$ < $${40.92}$$ $${+0}$$ $${9.57}$$ < $${10.45}$$
iot_agent_deb_armhf $${-0}$$ $${40.19}$$ < $${40.86}$$ $${+0}$$ $${9.68}$$ < $${10.56}$$
iot_agent_rpm_amd64 $${-0}$$ $${42.54}$$ < $${43.19}$$ $${+0}$$ $${11.13}$$ < $${12.0}$$
iot_agent_suse_amd64 $${-0}$$ $${42.54}$$ < $${43.19}$$ $${+0}$$ $${11.13}$$ < $${12.0}$$

@cit-pr-commenter
Copy link

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 772ed1fc-eb2f-4825-af7e-647ac2226d6a

Baseline: 5a22e48
Comparison: 4a55e61
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_cpu % cpu utilization +1.18 [-1.75, +4.11] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
quality_gate_logs % cpu utilization +2.75 [+1.28, +4.22] 1 Logs bounds checks dashboard
tcp_syslog_to_blackhole ingress throughput +2.27 [+2.20, +2.35] 1 Logs
docker_containers_cpu % cpu utilization +1.18 [-1.75, +4.11] 1 Logs
uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization +0.61 [+0.56, +0.66] 1 Logs
quality_gate_metrics_logs memory utilization +0.59 [+0.38, +0.81] 1 Logs bounds checks dashboard
ddot_logs memory utilization +0.17 [+0.11, +0.24] 1 Logs
quality_gate_idle memory utilization +0.17 [+0.12, +0.22] 1 Logs bounds checks dashboard
docker_containers_memory memory utilization +0.08 [-0.01, +0.16] 1 Logs
file_to_blackhole_100ms_latency egress throughput +0.01 [-0.04, +0.06] 1 Logs
uds_dogstatsd_to_api_v3 ingress throughput +0.01 [-0.12, +0.13] 1 Logs
ddot_metrics memory utilization +0.01 [-0.21, +0.23] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.00 [-0.12, +0.13] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.08, +0.07] 1 Logs
otlp_ingest_metrics memory utilization -0.01 [-0.15, +0.13] 1 Logs
file_to_blackhole_1000ms_latency egress throughput -0.01 [-0.43, +0.41] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.05 [-0.45, +0.34] 1 Logs
file_to_blackhole_500ms_latency egress throughput -0.11 [-0.48, +0.26] 1 Logs
ddot_metrics_sum_cumulativetodelta_exporter memory utilization -0.20 [-0.44, +0.04] 1 Logs
ddot_metrics_sum_delta memory utilization -0.26 [-0.46, -0.06] 1 Logs
ddot_metrics_sum_cumulative memory utilization -0.38 [-0.52, -0.23] 1 Logs
file_tree memory utilization -0.42 [-0.47, -0.37] 1 Logs
quality_gate_idle_all_features memory utilization -0.60 [-0.65, -0.54] 1 Logs bounds checks dashboard
otlp_ingest_logs memory utilization -0.68 [-0.78, -0.59] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
docker_containers_cpu simple_check_run 10/10
docker_containers_memory memory_usage 10/10
docker_containers_memory simple_check_run 10/10
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency lost_bytes 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_logs memory_usage 10/10 bounds checks dashboard
quality_gate_metrics_logs cpu_usage 10/10 bounds checks dashboard
quality_gate_metrics_logs intake_connections 10/10 bounds checks dashboard
quality_gate_metrics_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_metrics_logs memory_usage 10/10 bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.

@gjulianm gjulianm added qa/done QA done before merge and regressions are covered by tests changelog/no-changelog labels Dec 1, 2025 — with Graphite App
@gjulianm gjulianm marked this pull request as ready for review December 1, 2025 13:55
@gjulianm gjulianm requested a review from a team as a code owner December 1, 2025 13:55
@gjulianm gjulianm added ask-review Ask required teams to review this PR backport/7.74.x labels Dec 1, 2025 — with Graphite App
Copy link
Contributor Author

gjulianm commented Dec 1, 2025

/merge

@dd-devflow-routing-codex
Copy link

dd-devflow-routing-codex bot commented Dec 1, 2025

View all feedbacks in Devflow UI.

2025-12-01 13:57:11 UTC ℹ️ Start processing command /merge


2025-12-01 13:57:16 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 42m (p90).


2025-12-01 14:15:18 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 2791ead into main Dec 1, 2025
325 of 327 checks passed
@dd-mergequeue dd-mergequeue bot deleted the guillermo.julian/fix-incorrect-setting branch December 1, 2025 14:15
@github-actions github-actions bot added this to the 7.75.0 milestone Dec 1, 2025
dd-octo-sts bot pushed a commit that referenced this pull request Dec 1, 2025
#43644)

### What does this PR do?

This PR fixes a bug with the retrieval of the sp_process_metrics_request_timeout setting, which was querying SystemProbe config instead of the agent config, where it is defined.

### Motivation

Fix configuration

### Describe how you validated your changes

### Additional Notes

Co-authored-by: guillermo.julian <[email protected]>
(cherry picked from commit 2791ead)
dd-mergequeue bot pushed a commit that referenced this pull request Dec 2, 2025
…ics_request_timeout (#43675)

Backport 2791ead from #43644.

___

### What does this PR do?

This PR fixes a bug with the retrieval of the sp_process_metrics_request_timeout setting, which was querying SystemProbe config instead of the agent config, where it is defined.

### Motivation

Fix configuration

### Describe how you validated your changes

### Additional Notes

Co-authored-by: chouetz <[email protected]>
Co-authored-by: gjulianm <[email protected]>
Co-authored-by: spencer.gilbert <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ask-review Ask required teams to review this PR backport/7.74.x changelog/no-changelog qa/done QA done before merge and regressions are covered by tests short review PR is simple enough to be reviewed quickly team/ebpf-platform

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants