Skip to content

Conversation

@alopezz
Copy link
Contributor

@alopezz alopezz commented Nov 28, 2025

What does this PR do?

It restores #43340 and fixes it by restoring the omnibus code path for fips mode Windows Agent.

Motivation

#incident-46365

https://gitlab.ddbuild.io/DataDog/datadog-agent/-/jobs/1261560018

I didn't look close enough at how the fips build is meant to work and the job didn't run on the PR.

Describe how you validated your changes

I've manually run the jobs that failed last time.

Additional Notes

@alopezz alopezz requested a review from a team as a code owner November 28, 2025 13:46
@alopezz alopezz changed the title Keep building python the same old way for fips agent Keep building python the same old way for Windows fips agent Nov 28, 2025
@github-actions github-actions bot added team/agent-build short review PR is simple enough to be reviewed quickly labels Nov 28, 2025
@alopezz alopezz force-pushed the alopez/fix-windows-fips branch from 74e7f38 to 1ff8ed1 Compare November 28, 2025 13:59
### What does this PR do?

Integrates Bazel-built Python with actual Agent builds on Windows.

### Motivation

[ABLD-179](https://datadoghq.atlassian.net/browse/ABLD-179)

### Describe how you validated your changes

Passing build and E2E tests should provide solid evidence.

I also installed the built package in a VM and made some basic smoke testing, including running Python standalone as well as running a Python integration (http_check).

### Additional Notes

This also introduces some significant disk savings (as seen in the static quality gates report), which comes from:
- We were shipping redundant copies of the opensll dll's (under bin/). After this PR, we won't.
- We were shipping openssl headers. After this PR, we won't. We're not aware of any actual runtime use for these.

[ABLD-179]: https://datadoghq.atlassian.net/browse/ABLD-179?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ

Co-authored-by: alex.lopez <[email protected]>
@alopezz alopezz force-pushed the alopez/fix-windows-fips branch from 1ff8ed1 to 9e107e8 Compare November 28, 2025 14:16
@github-actions github-actions bot added medium review PR review might take time and removed short review PR is simple enough to be reviewed quickly labels Nov 28, 2025
@alopezz alopezz changed the title Keep building python the same old way for Windows fips agent Restore python bazel build while fixing FIPS issue Nov 28, 2025
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Nov 28, 2025

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 2e84108

Successful checks

Info

Quality gate Delta On disk size (MiB) Delta On wire size (MiB)
agent_deb_amd64 DataNotFound $${705.02}$$ < $${717.44}$$ DataNotFound $${172.88}$$ < $${177.37}$$
agent_deb_amd64_fips DataNotFound $${699.86}$$ < $${711.66}$$ DataNotFound $${171.7}$$ < $${174.84}$$
agent_heroku_amd64 DataNotFound $${326.33}$$ < $${337.57}$$ DataNotFound $${87.33}$$ < $${90.78}$$
agent_msi DataNotFound $${969.06}$$ < $${1015.38}$$ DataNotFound $${141.42}$$ < $${149.42}$$
agent_rpm_amd64 DataNotFound $${705.01}$$ < $${717.41}$$ DataNotFound $${175.9}$$ < $${178.01}$$
agent_rpm_amd64_fips DataNotFound $${699.84}$$ < $${711.64}$$ DataNotFound $${173.97}$$ < $${177.26}$$
agent_rpm_arm64 DataNotFound $${690.69}$$ < $${702.19}$$ DataNotFound $${159.7}$$ < $${163.22}$$
agent_rpm_arm64_fips DataNotFound $${686.5}$$ < $${697.6}$$ DataNotFound $${159.06}$$ < $${162.68}$$
agent_suse_amd64 DataNotFound $${705.01}$$ < $${717.41}$$ DataNotFound $${175.9}$$ < $${178.01}$$
agent_suse_amd64_fips DataNotFound $${699.84}$$ < $${711.64}$$ DataNotFound $${173.97}$$ < $${177.26}$$
agent_suse_arm64 DataNotFound $${690.69}$$ < $${702.19}$$ DataNotFound $${159.7}$$ < $${163.22}$$
agent_suse_arm64_fips DataNotFound $${686.5}$$ < $${697.6}$$ DataNotFound $${159.06}$$ < $${162.68}$$
docker_agent_amd64 DataNotFound $${767.36}$$ < $${769.92}$$ DataNotFound $${260.59}$$ < $${261.52}$$
docker_agent_arm64 DataNotFound $${777.3}$$ < $${779.46}$$ DataNotFound $${250.78}$$ < $${251.72}$$
docker_agent_jmx_amd64 DataNotFound $${958.24}$$ < $${960.8}$$ DataNotFound $${329.23}$$ < $${330.15}$$
docker_agent_jmx_arm64 DataNotFound $${956.9}$$ < $${958.93}$$ DataNotFound $${315.41}$$ < $${316.35}$$
docker_cluster_agent_amd64 DataNotFound $${178.85}$$ < $${207.49}$$ DataNotFound $${63.16}$$ < $${70.2}$$
docker_cluster_agent_arm64 DataNotFound $${196.33}$$ < $${223.38}$$ DataNotFound $${59.88}$$ < $${66.42}$$
docker_cws_instrumentation_amd64 DataNotFound $${7.07}$$ < $${7.12}$$ DataNotFound $${2.95}$$ < $${3.29}$$
docker_cws_instrumentation_arm64 DataNotFound $${6.69}$$ < $${6.92}$$ DataNotFound $${2.7}$$ < $${3.07}$$
docker_dogstatsd_amd64 DataNotFound $${38.58}$$ < $${39.3}$$ DataNotFound $${14.91}$$ < $${15.76}$$
docker_dogstatsd_arm64 DataNotFound $${37.24}$$ < $${37.94}$$ DataNotFound $${14.35}$$ < $${14.83}$$
dogstatsd_deb_amd64 DataNotFound $${29.8}$$ < $${30.53}$$ DataNotFound $${7.86}$$ < $${8.75}$$
dogstatsd_deb_arm64 DataNotFound $${28.31}$$ < $${29.11}$$ DataNotFound $${6.8}$$ < $${7.71}$$
dogstatsd_rpm_amd64 DataNotFound $${29.8}$$ < $${30.53}$$ DataNotFound $${7.87}$$ < $${8.76}$$
dogstatsd_suse_amd64 DataNotFound $${29.8}$$ < $${30.53}$$ DataNotFound $${7.87}$$ < $${8.76}$$
iot_agent_deb_amd64 DataNotFound $${42.55}$$ < $${43.19}$$ DataNotFound $${11.11}$$ < $${11.98}$$
iot_agent_deb_arm64 DataNotFound $${40.29}$$ < $${40.92}$$ DataNotFound $${9.57}$$ < $${10.45}$$
iot_agent_deb_armhf DataNotFound $${40.2}$$ < $${40.86}$$ DataNotFound $${9.68}$$ < $${10.56}$$
iot_agent_rpm_amd64 DataNotFound $${42.56}$$ < $${43.19}$$ DataNotFound $${11.13}$$ < $${12.0}$$
iot_agent_suse_amd64 DataNotFound $${42.56}$$ < $${43.19}$$ DataNotFound $${11.13}$$ < $${12.0}$$

@cit-pr-commenter
Copy link

cit-pr-commenter bot commented Nov 28, 2025

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 5bdd4a42-eda1-40c5-aec6-441dd7d3cfbf

Baseline: fcb5852
Comparison: c507f39
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_cpu % cpu utilization -2.25 [-5.22, +0.72] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
quality_gate_logs % cpu utilization +1.11 [-0.35, +2.57] 1 Logs bounds checks dashboard
file_tree memory utilization +0.68 [+0.63, +0.73] 1 Logs
tcp_syslog_to_blackhole ingress throughput +0.63 [+0.57, +0.69] 1 Logs
otlp_ingest_metrics memory utilization +0.23 [+0.09, +0.37] 1 Logs
otlp_ingest_logs memory utilization +0.22 [+0.13, +0.30] 1 Logs
quality_gate_idle memory utilization +0.14 [+0.09, +0.19] 1 Logs bounds checks dashboard
file_to_blackhole_500ms_latency egress throughput +0.05 [-0.33, +0.42] 1 Logs
file_to_blackhole_1000ms_latency egress throughput +0.04 [-0.37, +0.45] 1 Logs
file_to_blackhole_0ms_latency egress throughput +0.03 [-0.36, +0.42] 1 Logs
ddot_metrics_sum_delta memory utilization +0.02 [-0.17, +0.21] 1 Logs
uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization +0.01 [-0.05, +0.07] 1 Logs
ddot_metrics memory utilization +0.00 [-0.21, +0.22] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.07, +0.07] 1 Logs
uds_dogstatsd_to_api_v3 ingress throughput +0.00 [-0.12, +0.12] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.00 [-0.05, +0.05] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.00 [-0.13, +0.12] 1 Logs
quality_gate_idle_all_features memory utilization -0.04 [-0.09, +0.01] 1 Logs bounds checks dashboard
ddot_metrics_sum_cumulativetodelta_exporter memory utilization -0.22 [-0.46, +0.02] 1 Logs
ddot_logs memory utilization -0.31 [-0.37, -0.25] 1 Logs
docker_containers_memory memory utilization -0.35 [-0.44, -0.26] 1 Logs
ddot_metrics_sum_cumulative memory utilization -0.69 [-0.83, -0.54] 1 Logs
quality_gate_metrics_logs memory utilization -0.94 [-1.16, -0.73] 1 Logs bounds checks dashboard
docker_containers_cpu % cpu utilization -2.25 [-5.22, +0.72] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
docker_containers_cpu simple_check_run 10/10
docker_containers_memory memory_usage 10/10
docker_containers_memory simple_check_run 10/10
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency lost_bytes 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_logs memory_usage 10/10 bounds checks dashboard
quality_gate_metrics_logs cpu_usage 10/10 bounds checks dashboard
quality_gate_metrics_logs intake_connections 10/10 bounds checks dashboard
quality_gate_metrics_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_metrics_logs memory_usage 10/10 bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.

@alopezz alopezz added qa/done QA done before merge and regressions are covered by tests ask-review Ask required teams to review this PR labels Nov 28, 2025
@alopezz
Copy link
Contributor Author

alopezz commented Dec 1, 2025

/merge

@dd-devflow-routing-codex
Copy link

dd-devflow-routing-codex bot commented Dec 1, 2025

View all feedbacks in Devflow UI.

2025-12-01 10:46:33 UTC ℹ️ Start processing command /merge


2025-12-01 10:46:40 UTC ℹ️ MergeQueue: waiting for PR to be ready

This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2025-12-01 13:26:05 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in main is approximately 42m (p90).


2025-12-01 13:46:03 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 50a6606 into main Dec 1, 2025
425 checks passed
@dd-mergequeue dd-mergequeue bot deleted the alopez/fix-windows-fips branch December 1, 2025 13:46
@github-actions github-actions bot added this to the 7.75.0 milestone Dec 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ask-review Ask required teams to review this PR changelog/no-changelog medium review PR review might take time qa/done QA done before merge and regressions are covered by tests team/agent-build

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants