Skip to content

Conversation

@theop-dd
Copy link
Contributor

What does this PR do?

This PR improves the definition of some fields of the setsockopt event type.

Motivation

Some definitions lacked important information—for example, that certain fields are only present when setsockopt is invoked with specific options or in specific contexts.

Describe how you validated your changes

Additional Notes

@theop-dd theop-dd requested a review from a team as a code owner November 28, 2025 09:17
@github-actions github-actions bot added component/system-probe team/agent-security short review PR is simple enough to be reviewed quickly labels Nov 28, 2025
@theop-dd theop-dd added changelog/no-changelog category/bugfix qa/done QA done before merge and regressions are covered by tests labels Nov 28, 2025
@theop-dd theop-dd force-pushed the theop-dd/improve-setsockopt-doc branch from c0f4b89 to a490e87 Compare November 28, 2025 09:36
@theop-dd theop-dd requested a review from a team as a code owner November 28, 2025 09:36
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Nov 28, 2025

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 5acfb51

Successful checks

Info

Quality gate Delta On disk size (MiB) Delta On wire size (MiB)
agent_deb_amd64 $${+0}$$ $${705.02}$$ < $${717.44}$$ $${+0.02}$$ $${172.96}$$ < $${177.37}$$
agent_deb_amd64_fips $${+0}$$ $${699.86}$$ < $${711.66}$$ $${+0.03}$$ $${171.72}$$ < $${174.84}$$
agent_heroku_amd64 $${0}$$ $${326.33}$$ < $${337.57}$$ $${-0}$$ $${87.34}$$ < $${90.78}$$
agent_msi $${0}$$ $${969.06}$$ < $${1015.38}$$ $${-0}$$ $${141.41}$$ < $${149.42}$$
agent_rpm_amd64 $${+0}$$ $${705.01}$$ < $${717.41}$$ $${+0.01}$$ $${175.92}$$ < $${178.01}$$
agent_rpm_amd64_fips $${+0}$$ $${699.85}$$ < $${711.64}$$ $${-0.05}$$ $${173.92}$$ < $${177.26}$$
agent_rpm_arm64 $${-0}$$ $${690.69}$$ < $${702.19}$$ $${-0.01}$$ $${159.7}$$ < $${163.22}$$
agent_rpm_arm64_fips $${-0}$$ $${686.5}$$ < $${697.6}$$ $${+0.03}$$ $${159.1}$$ < $${162.68}$$
agent_suse_amd64 $${+0}$$ $${705.01}$$ < $${717.41}$$ $${+0.01}$$ $${175.92}$$ < $${178.01}$$
agent_suse_amd64_fips $${+0}$$ $${699.85}$$ < $${711.64}$$ $${-0.05}$$ $${173.92}$$ < $${177.26}$$
agent_suse_arm64 $${-0}$$ $${690.69}$$ < $${702.19}$$ $${-0.01}$$ $${159.7}$$ < $${163.22}$$
agent_suse_arm64_fips $${-0}$$ $${686.5}$$ < $${697.6}$$ $${+0.03}$$ $${159.1}$$ < $${162.68}$$
docker_agent_amd64 $${+0}$$ $${767.36}$$ < $${769.92}$$ $${+0}$$ $${260.59}$$ < $${261.52}$$
docker_agent_arm64 $${-0}$$ $${777.3}$$ < $${779.46}$$ $${-0}$$ $${250.78}$$ < $${251.72}$$
docker_agent_jmx_amd64 $${+0}$$ $${958.24}$$ < $${960.8}$$ $${-0}$$ $${329.22}$$ < $${330.15}$$
docker_agent_jmx_arm64 $${-0}$$ $${956.9}$$ < $${958.93}$$ $${-0}$$ $${315.4}$$ < $${316.35}$$
docker_cluster_agent_amd64 $${+0}$$ $${178.85}$$ < $${207.49}$$ $${+0}$$ $${63.16}$$ < $${70.2}$$
docker_cluster_agent_arm64 $${-0}$$ $${196.33}$$ < $${223.38}$$ $${-0}$$ $${59.88}$$ < $${66.42}$$
docker_cws_instrumentation_amd64 $${0}$$ $${7.07}$$ < $${7.12}$$ $${-0}$$ $${2.95}$$ < $${3.29}$$
docker_cws_instrumentation_arm64 $${0}$$ $${6.69}$$ < $${6.92}$$ $${-0}$$ $${2.7}$$ < $${3.07}$$
docker_dogstatsd_amd64 $${+0}$$ $${38.58}$$ < $${39.3}$$ $${-0}$$ $${14.91}$$ < $${15.76}$$
docker_dogstatsd_arm64 $${+0}$$ $${37.24}$$ < $${37.94}$$ $${+0}$$ $${14.35}$$ < $${14.83}$$
dogstatsd_deb_amd64 $${0}$$ $${29.8}$$ < $${30.53}$$ $${-0}$$ $${7.86}$$ < $${8.75}$$
dogstatsd_deb_arm64 $${0}$$ $${28.31}$$ < $${29.11}$$ $${+0}$$ $${6.8}$$ < $${7.71}$$
dogstatsd_rpm_amd64 $${0}$$ $${29.8}$$ < $${30.53}$$ $${+0}$$ $${7.87}$$ < $${8.76}$$
dogstatsd_suse_amd64 $${0}$$ $${29.8}$$ < $${30.53}$$ $${+0}$$ $${7.87}$$ < $${8.76}$$
iot_agent_deb_amd64 $${0}$$ $${42.55}$$ < $${43.19}$$ $${-0}$$ $${11.11}$$ < $${11.98}$$
iot_agent_deb_arm64 $${0}$$ $${40.29}$$ < $${40.92}$$ $${-0}$$ $${9.57}$$ < $${10.45}$$
iot_agent_deb_armhf $${0}$$ $${40.2}$$ < $${40.86}$$ $${-0}$$ $${9.68}$$ < $${10.56}$$
iot_agent_rpm_amd64 $${0}$$ $${42.56}$$ < $${43.19}$$ $${-0}$$ $${11.13}$$ < $${12.0}$$
iot_agent_suse_amd64 $${0}$$ $${42.56}$$ < $${43.19}$$ $${-0}$$ $${11.13}$$ < $${12.0}$$

@cit-pr-commenter
Copy link

cit-pr-commenter bot commented Nov 28, 2025

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 2772e77b-3983-4ce2-9957-61da55913aa8

Baseline: 5acfb51
Comparison: 164f707
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_cpu % cpu utilization -0.96 [-3.89, +1.97] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
quality_gate_logs % cpu utilization +1.53 [+0.08, +2.98] 1 Logs bounds checks dashboard
tcp_syslog_to_blackhole ingress throughput +1.26 [+1.20, +1.33] 1 Logs
quality_gate_idle memory utilization +0.28 [+0.23, +0.33] 1 Logs bounds checks dashboard
file_tree memory utilization +0.19 [+0.15, +0.24] 1 Logs
ddot_metrics_sum_delta memory utilization +0.17 [-0.04, +0.38] 1 Logs
ddot_metrics_sum_cumulativetodelta_exporter memory utilization +0.17 [-0.07, +0.40] 1 Logs
ddot_metrics memory utilization +0.16 [-0.04, +0.37] 1 Logs
ddot_metrics_sum_cumulative memory utilization +0.15 [+0.00, +0.30] 1 Logs
docker_containers_memory memory utilization +0.13 [+0.05, +0.22] 1 Logs
uds_dogstatsd_to_api_v3 ingress throughput -0.00 [-0.14, +0.13] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.08, +0.08] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.00 [-0.13, +0.12] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.02 [-0.07, +0.03] 1 Logs
file_to_blackhole_1000ms_latency egress throughput -0.04 [-0.44, +0.36] 1 Logs
quality_gate_idle_all_features memory utilization -0.05 [-0.10, -0.00] 1 Logs bounds checks dashboard
file_to_blackhole_0ms_latency egress throughput -0.06 [-0.44, +0.32] 1 Logs
file_to_blackhole_500ms_latency egress throughput -0.08 [-0.45, +0.29] 1 Logs
uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization -0.15 [-0.20, -0.10] 1 Logs
otlp_ingest_logs memory utilization -0.19 [-0.30, -0.09] 1 Logs
ddot_logs memory utilization -0.28 [-0.34, -0.22] 1 Logs
quality_gate_metrics_logs memory utilization -0.58 [-0.78, -0.37] 1 Logs bounds checks dashboard
otlp_ingest_metrics memory utilization -0.80 [-0.94, -0.66] 1 Logs
docker_containers_cpu % cpu utilization -0.96 [-3.89, +1.97] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
docker_containers_cpu simple_check_run 10/10
docker_containers_memory memory_usage 10/10
docker_containers_memory simple_check_run 10/10
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency lost_bytes 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_logs memory_usage 10/10 bounds checks dashboard
quality_gate_metrics_logs cpu_usage 10/10 bounds checks dashboard
quality_gate_metrics_logs intake_connections 10/10 bounds checks dashboard
quality_gate_metrics_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_metrics_logs memory_usage 10/10 bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.

Comment on lines 2193 to 2196
| [`setsockopt.filter_hash`](#setsockopt-filter_hash-doc) | Hash of the currently attached filter using sha256. Only available if the optname is SO_ATTACH_FILTER |
| [`setsockopt.filter_instructions`](#setsockopt-filter_instructions-doc) | Instructions of the currently attached filter. Only available if the optname is SO_ATTACH_FILTER |
| [`setsockopt.filter_len`](#setsockopt-filter_len-doc) | Length of the currently attached filter. Only available if the optname is SO_ATTACH_FILTER |
| [`setsockopt.is_filter_truncated`](#setsockopt-is_filter_truncated-doc) | Indicates that the currently attached filter is truncated. Only available if the optname is SO_ATTACH_FILTER |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| [`setsockopt.filter_hash`](#setsockopt-filter_hash-doc) | Hash of the currently attached filter using sha256. Only available if the optname is SO_ATTACH_FILTER |
| [`setsockopt.filter_instructions`](#setsockopt-filter_instructions-doc) | Instructions of the currently attached filter. Only available if the optname is SO_ATTACH_FILTER |
| [`setsockopt.filter_len`](#setsockopt-filter_len-doc) | Length of the currently attached filter. Only available if the optname is SO_ATTACH_FILTER |
| [`setsockopt.is_filter_truncated`](#setsockopt-is_filter_truncated-doc) | Indicates that the currently attached filter is truncated. Only available if the optname is SO_ATTACH_FILTER |
| [`setsockopt.filter_hash`](#setsockopt-filter_hash-doc) | Hash of the currently attached filter using sha256. Only available if the optname is `SO_ATTACH_FILTER` |
| [`setsockopt.filter_instructions`](#setsockopt-filter_instructions-doc) | Instructions of the currently attached filter. Only available if the optname is `SO_ATTACH_FILTER` |
| [`setsockopt.filter_len`](#setsockopt-filter_len-doc) | Length of the currently attached filter. Only available if the optname is `SO_ATTACH_FILTER` |
| [`setsockopt.is_filter_truncated`](#setsockopt-is_filter_truncated-doc) | Indicates that the currently attached filter is truncated. Only available if the optname is `SO_ATTACH_FILTER` |

I think the name might be easier to pick out with some different formatting

| [`setsockopt.socket_protocol`](#setsockopt-socket_protocol-doc) | Socket protocol |
| [`setsockopt.socket_type`](#setsockopt-socket_type-doc) | Socket type |
| [`setsockopt.used_immediates`](#setsockopt-used_immediates-doc) | List of immediate values used in the filter |
| [`setsockopt.used_immediates`](#setsockopt-used_immediates-doc) | List of immediate values used in the currently attached filter. Only available if the optname is SO_ATTACH_FILTER |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| [`setsockopt.used_immediates`](#setsockopt-used_immediates-doc) | List of immediate values used in the currently attached filter. Only available if the optname is SO_ATTACH_FILTER |
| [`setsockopt.used_immediates`](#setsockopt-used_immediates-doc) | List of immediate values used in the currently attached filter. Only available if the optname is `SO_ATTACH_FILTER` |

Type: string

Definition: Hash of the socket filter using sha256
Definition: Hash of the currently attached filter using sha256. Only available if the optname is SO_ATTACH_FILTER
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Definition: Hash of the currently attached filter using sha256. Only available if the optname is SO_ATTACH_FILTER
Definition: Hash of the currently attached filter using sha256. Only available if the optname is `SO_ATTACH_FILTER`

Type: string

Definition: Filter instructions
Definition: Instructions of the currently attached filter. Only available if the optname is SO_ATTACH_FILTER
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Definition: Instructions of the currently attached filter. Only available if the optname is SO_ATTACH_FILTER
Definition: Instructions of the currently attached filter. Only available if the optname is `SO_ATTACH_FILTER`

Type: int

Definition: Length of the filter
Definition: Length of the currently attached filter. Only available if the optname is SO_ATTACH_FILTER
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Definition: Length of the currently attached filter. Only available if the optname is SO_ATTACH_FILTER
Definition: Length of the currently attached filter. Only available if the optname is `SO_ATTACH_FILTER`

"link": "setsockopt-filter_hash-doc",
"type": "string",
"definition": "Hash of the socket filter using sha256",
"definition": "Hash of the currently attached filter using sha256. Only available if the optname is SO_ATTACH_FILTER",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"definition": "Hash of the currently attached filter using sha256. Only available if the optname is SO_ATTACH_FILTER",
"definition": "Hash of the currently attached filter using sha256. Only available if the optname is `SO_ATTACH_FILTER`",

"link": "setsockopt-filter_instructions-doc",
"type": "string",
"definition": "Filter instructions",
"definition": "Instructions of the currently attached filter. Only available if the optname is SO_ATTACH_FILTER",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"definition": "Instructions of the currently attached filter. Only available if the optname is SO_ATTACH_FILTER",
"definition": "Instructions of the currently attached filter. Only available if the optname is `SO_ATTACH_FILTER`",

"link": "setsockopt-filter_len-doc",
"type": "int",
"definition": "Length of the filter",
"definition": "Length of the currently attached filter. Only available if the optname is SO_ATTACH_FILTER",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"definition": "Length of the currently attached filter. Only available if the optname is SO_ATTACH_FILTER",
"definition": "Length of the currently attached filter. Only available if the optname is `SO_ATTACH_FILTER`",

"link": "setsockopt-is_filter_truncated-doc",
"type": "bool",
"definition": "Indicates that the filter is truncated",
"definition": "Indicates that the currently attached filter is truncated. Only available if the optname is SO_ATTACH_FILTER",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"definition": "Indicates that the currently attached filter is truncated. Only available if the optname is SO_ATTACH_FILTER",
"definition": "Indicates that the currently attached filter is truncated. Only available if the optname is `SO_ATTACH_FILTER`",

"link": "setsockopt-used_immediates-doc",
"type": "int",
"definition": "List of immediate values used in the filter",
"definition": "List of immediate values used in the currently attached filter. Only available if the optname is SO_ATTACH_FILTER",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"definition": "List of immediate values used in the currently attached filter. Only available if the optname is SO_ATTACH_FILTER",
"definition": "List of immediate values used in the currently attached filter. Only available if the optname is `SO_ATTACH_FILTER`",

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right. Since these files are auto-generated, I'll check if I can make it how you suggested :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's done! I will merge.

@github-actions github-actions bot added long review PR is complex, plan time to review it and removed short review PR is simple enough to be reviewed quickly labels Nov 28, 2025
@theop-dd theop-dd force-pushed the theop-dd/improve-setsockopt-doc branch 2 times, most recently from 587e3ee to 1bc3c25 Compare December 1, 2025 15:47
@theop-dd
Copy link
Contributor Author

theop-dd commented Dec 1, 2025

/trigger-ci

@dd-devflow-routing-codex
Copy link

View all feedbacks in Devflow UI.

2025-12-01 16:38:18 UTC ℹ️ Start processing command /trigger-ci
If you need support, contact us on Slack #devflow!


2025-12-01 16:41:22 UTC 🚨 Devflow

Post "https://gitlab.ddbuild.io/api/v4/projects/DataDog%2Fdatadog-agent/pipeline": net/http: request canceled (Client.Timeout exceeded while awaiting headers)

Details
child workflow execution error (type: devtools.Devtools_TriggerCiFromPr, workflowID: 0505148a-22ea-4117-b045-587637135836_36, runID: 15af2c66-c221-4889-a8e6-3d5bb2b82651, initiatedEventID: 36, startedEventID: 37): child workflow execution error (type: devtools.Devtools_TriggerCi, workflowID: 15af2c66-c221-4889-a8e6-3d5bb2b82651_14, runID: e5ed3ea4-da48-4f4e-a19c-0da339da1606, initiatedEventID: 14, startedEventID: 15): activity error (type: gitlab.GitlabService_CreatePipeline, scheduledEventID: 26, startedEventID: 27, identity: ): activity ScheduleToClose timeout (type: ScheduleToClose): Post "https://gitlab.ddbuild.io/api/v4/projects/DataDog%2Fdatadog-agent/pipeline": net/http: request canceled (Client.Timeout exceeded while awaiting headers) (type: Error, retryable: true): net/http: request canceled (Client.Timeout exceeded while awaiting headers) (type: timeoutError, retryable: true)

If you need support, contact us on Slack #devflow with those details!

@theop-dd theop-dd force-pushed the theop-dd/improve-setsockopt-doc branch from 1bc3c25 to 164f707 Compare December 2, 2025 08:45
@theop-dd
Copy link
Contributor Author

theop-dd commented Dec 2, 2025

/merge

@dd-devflow-routing-codex
Copy link

dd-devflow-routing-codex bot commented Dec 2, 2025

View all feedbacks in Devflow UI.

2025-12-02 12:52:21 UTC ℹ️ Start processing command /merge


2025-12-02 12:52:25 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 44m (p90).


2025-12-02 13:18:06 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit f3a293b into main Dec 2, 2025
333 checks passed
@dd-mergequeue dd-mergequeue bot deleted the theop-dd/improve-setsockopt-doc branch December 2, 2025 13:18
@github-actions github-actions bot added this to the 7.75.0 milestone Dec 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category/bugfix changelog/no-changelog component/system-probe long review PR is complex, plan time to review it qa/done QA done before merge and regressions are covered by tests team/agent-security

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants