Rearrange struct fields to save memory

[zhuminyi]

What does this PR do?

Motivation

Run fieldalignment

# [github.com/DataDog/datadog-agent/comp/core/workloadmeta/def]
comp/core/workloadmeta/def/params.go:9:13: struct with 16 pointer bytes could be 8
comp/core/workloadmeta/def/types.go:237:17: struct with 48 pointer bytes could be 40
comp/core/workloadmeta/def/types.go:317:21: struct with 120 pointer bytes could be 104
comp/core/workloadmeta/def/types.go:347:20: struct with 32 pointer bytes could be 24
comp/core/workloadmeta/def/types.go:425:25: struct with 72 pointer bytes could be 56
comp/core/workloadmeta/def/types.go:483:19: struct with 168 pointer bytes could be 160
comp/core/workloadmeta/def/types.go:531:16: struct with 560 pointer bytes could be 544
comp/core/workloadmeta/def/types.go:661:31: struct with 24 pointer bytes could be 16
comp/core/workloadmeta/def/types.go:695:20: struct with 360 pointer bytes could be 336
comp/core/workloadmeta/def/types.go:826:25: struct with 88 pointer bytes could be 80
comp/core/workloadmeta/def/types.go:873:27: struct with 144 pointer bytes could be 136
comp/core/workloadmeta/def/types.go:969:14: struct with 312 pointer bytes could be 304
comp/core/workloadmeta/def/types.go:1061:29: struct with 248 pointer bytes could be 224
comp/core/workloadmeta/def/types.go:1077:26: struct with 72 pointer bytes could be 48
comp/core/workloadmeta/def/types.go:1086:11: struct with 64 pointer bytes could be 56
comp/core/workloadmeta/def/types.go:1189:14: struct with 88 pointer bytes could be 72
comp/core/workloadmeta/def/types.go:1278:21: struct with 40 pointer bytes could be 24
comp/core/workloadmeta/def/types.go:1285:12: struct with 24 pointer bytes could be 16
comp/core/workloadmeta/def/types.go:1334:18: struct with 32 pointer bytes could be 16
comp/core/workloadmeta/def/filter_test.go:18:13: struct with 104 pointer bytes could be 96
comp/core/workloadmeta/def/filter_test.go:63:13: struct with 32 pointer bytes could be 24
comp/core/workloadmeta/def/filter_test.go:160:13: struct with 24 pointer bytes could be 16
comp/core/workloadmeta/def/filter_test.go:256:13: struct with 40 pointer bytes could be 32

Describe how you validated your changes

Create a benchmark test

Take collector event for example: 16 bytes saved
comp/core/workloadmeta/def/types.go:1278:21: struct with 40 pointer bytes could be 24
go test -bench=. -benchtime= 200000x
Old

goos: darwin
goarch: arm64
pkg: github.com/DataDog/datadog-agent/comp/core/workloadmeta/def
cpu: Apple M1 Max
BenchmarkProcessCollectorEvent/Run_collector_event_bench_test_on_container-10            200000             18007 ns/op
BenchmarkProcessCollectorEvent/Run_collector_event_bench_test_on_kubernetes-10           200000             17095 ns/op
BenchmarkProcessCollectorEvent/Run_collector_event_bench_test_on_processes-10            200000             16513 ns/op
BenchmarkProcessEntity/Run_process_entity_bench_test_on_container-10                      200000             47944 ns/op
BenchmarkProcessEntity/Run_process_entity_bench_test_on_-10                               200000             47806 ns/op
BenchmarkProcessEntity/Run_process_entity_bench_test_on_process-10                        200000              6810 ns/op
PASS
ok      github.com/DataDog/datadog-agent/comp/core/workloadmeta/def     31.394s

New

goos: darwin
goarch: arm64
pkg: github.com/DataDog/datadog-agent/comp/core/workloadmeta/def
cpu: Apple M1 Max
BenchmarkProcessCollectorEvent/Run_collector_event_bench_test_on_container-10            200000             12384 ns/op
BenchmarkProcessCollectorEvent/Run_collector_event_bench_test_on_kubernetes-10           200000             10668 ns/op
BenchmarkProcessCollectorEvent/Run_collector_event_bench_test_on_processes-10            200000             10491 ns/op
BenchmarkProcessEntity/Run_process_entity_bench_test_on_container-10                      200000             40858 ns/op
BenchmarkProcessEntity/Run_process_entity_bench_test_on_-10                               200000             41816 ns/op
BenchmarkProcessEntity/Run_process_entity_bench_test_on_process-10                        200000              6147 ns/op
PASS
ok      github.com/DataDog/datadog-agent/comp/core/workloadmeta/def     25.037s

Possible Drawbacks / Trade-offs

Additional Notes

[agent-platform-auto-pr]

Uncompressed package size comparison

Comparison with ancestor 7396f6c4e5ccd20f8c8af631d519a9c14067af7f

Diff per package

package	diff	status	size	ancestor	threshold
datadog-agent-amd64-deb	0.00MB	✅	1191.05MB	1191.04MB	140.00MB
datadog-agent-x86_64-rpm	0.00MB	✅	1200.37MB	1200.36MB	140.00MB
datadog-agent-x86_64-suse	0.00MB	✅	1200.37MB	1200.36MB	140.00MB
datadog-dogstatsd-amd64-deb	0.00MB	✅	78.54MB	78.54MB	10.00MB
datadog-heroku-agent-amd64-deb	0.00MB	✅	505.28MB	505.27MB	70.00MB
datadog-dogstatsd-x86_64-rpm	0.00MB	✅	78.62MB	78.62MB	10.00MB
datadog-dogstatsd-x86_64-suse	0.00MB	✅	78.62MB	78.62MB	10.00MB
datadog-iot-agent-x86_64-rpm	0.00MB	✅	113.41MB	113.41MB	10.00MB
datadog-iot-agent-x86_64-suse	0.00MB	✅	113.41MB	113.41MB	10.00MB
datadog-agent-arm64-deb	0.00MB	✅	935.37MB	935.37MB	140.00MB
datadog-agent-aarch64-rpm	0.00MB	✅	944.67MB	944.67MB	140.00MB
datadog-dogstatsd-arm64-deb	0.00MB	✅	55.75MB	55.75MB	10.00MB
datadog-iot-agent-amd64-deb	0.00MB	✅	113.34MB	113.34MB	10.00MB
datadog-iot-agent-arm64-deb	0.00MB	✅	108.81MB	108.81MB	10.00MB
datadog-iot-agent-aarch64-rpm	-0.00MB	✅	108.88MB	108.88MB	10.00MB

Decision

✅ Passed

[agent-platform-auto-pr]

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=51960599 --os-family=ubuntu

Note: This applies to commit fddbc2e

[cit-pr-commenter]

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 2b26468a-b4cb-4821-a68d-d1c45339cd5f

Baseline: 7396f6c
Comparison: 838821f
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	+0.69	[-0.00, +1.37]	1	Logs
➖	file_to_blackhole_1000ms_latency	egress throughput	+0.14	[-0.66, +0.93]	1	Logs
➖	file_to_blackhole_0ms_latency_http1	egress throughput	+0.11	[-0.66, +0.89]	1	Logs
➖	file_to_blackhole_100ms_latency	egress throughput	+0.07	[-0.68, +0.82]	1	Logs
➖	quality_gate_idle_all_features	memory utilization	+0.06	[-0.02, +0.15]	1	Logs bounds checks dashboard
➖	file_to_blackhole_0ms_latency	egress throughput	+0.04	[-0.80, +0.89]	1	Logs
➖	file_to_blackhole_300ms_latency	egress throughput	+0.03	[-0.61, +0.67]	1	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	+0.00	[-0.01, +0.02]	1	Logs
➖	file_to_blackhole_0ms_latency_http2	egress throughput	-0.00	[-0.86, +0.85]	1	Logs
➖	uds_dogstatsd_to_api	ingress throughput	-0.01	[-0.12, +0.11]	1	Logs
➖	file_to_blackhole_1000ms_latency_linear_load	egress throughput	-0.16	[-0.62, +0.31]	1	Logs
➖	file_to_blackhole_500ms_latency	egress throughput	-0.18	[-0.95, +0.59]	1	Logs
➖	quality_gate_logs	% cpu utilization	-0.21	[-3.45, +3.03]	1	Logs
➖	quality_gate_idle	memory utilization	-0.67	[-0.71, -0.64]	1	Logs bounds checks dashboard
➖	file_tree	memory utilization	-0.68	[-0.80, -0.55]	1	Logs
➖	tcp_syslog_to_blackhole	ingress throughput	-1.51	[-1.58, -1.45]	1	Logs

Bounds Checks: ✅ Passed

perf	experiment	bounds_check_name	replicates_passed	links
✅	file_to_blackhole_0ms_latency	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency	memory_usage	10/10
✅	file_to_blackhole_0ms_latency_http1	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency_http1	memory_usage	10/10
✅	file_to_blackhole_0ms_latency_http2	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency_http2	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency_linear_load	memory_usage	10/10
✅	file_to_blackhole_100ms_latency	lost_bytes	10/10
✅	file_to_blackhole_100ms_latency	memory_usage	10/10
✅	file_to_blackhole_300ms_latency	lost_bytes	10/10
✅	file_to_blackhole_300ms_latency	memory_usage	10/10
✅	file_to_blackhole_500ms_latency	lost_bytes	10/10
✅	file_to_blackhole_500ms_latency	memory_usage	10/10
✅	quality_gate_idle	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_logs	lost_bytes	10/10
✅	quality_gate_logs	memory_usage	10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

• quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.