Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding e2e test to check that IPC cert is used by the Agent IPC servers #32570

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

misteriaud
Copy link
Contributor

What does this PR do?

Motivation

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

Copy link

cit-pr-commenter bot commented Dec 30, 2024

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 7d682aaf-fde4-42b1-bc41-0689c1b35a35

Baseline: 20c010f
Comparison: cb4d415
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
tcp_syslog_to_blackhole ingress throughput +0.93 [+0.87, +0.99] 1 Logs
file_tree memory utilization +0.84 [+0.71, +0.96] 1 Logs
uds_dogstatsd_to_api_cpu % cpu utilization +0.82 [+0.14, +1.50] 1 Logs
file_to_blackhole_0ms_latency_http2 egress throughput +0.07 [-0.75, +0.90] 1 Logs
file_to_blackhole_500ms_latency egress throughput +0.06 [-0.72, +0.84] 1 Logs
file_to_blackhole_300ms_latency egress throughput +0.05 [-0.59, +0.69] 1 Logs
file_to_blackhole_100ms_latency egress throughput +0.00 [-0.68, +0.69] 1 Logs
file_to_blackhole_0ms_latency_http1 egress throughput +0.00 [-0.84, +0.85] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.00 [-0.10, +0.10] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput -0.00 [-0.47, +0.47] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.01 [-0.02, +0.01] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.01 [-0.81, +0.79] 1 Logs
quality_gate_idle_all_features memory utilization -0.08 [-0.16, +0.01] 1 Logs bounds checks dashboard
quality_gate_idle memory utilization -0.15 [-0.18, -0.11] 1 Logs bounds checks dashboard
file_to_blackhole_1000ms_latency egress throughput -0.23 [-1.01, +0.55] 1 Logs
quality_gate_logs % cpu utilization -3.19 [-6.34, -0.03] 1 Logs

Bounds Checks: ❌ Failed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_0ms_latency_http2 lost_bytes 8/10
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Dec 31, 2024

[Fast Unit Tests Report]

On pipeline 51955134 (CI Visibility). The following jobs did not run any unit tests:

Jobs:
  • tests_deb-arm64-py3
  • tests_deb-x64-py3
  • tests_flavor_dogstatsd_deb-x64
  • tests_flavor_heroku_deb-x64
  • tests_flavor_iot_deb-x64
  • tests_rpm-arm64-py3
  • tests_rpm-x64-py3
  • tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help

@agent-platform-auto-pr
Copy link
Contributor

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=51951592 --os-family=ubuntu

Note: This applies to commit 7e15410

@agent-platform-auto-pr
Copy link
Contributor

Uncompressed package size comparison

Comparison with ancestor 20c010fda49b74b0c99a64b8f50e5219061008d8

Diff per package
package diff status size ancestor threshold
datadog-agent-aarch64-rpm 0.00MB 944.67MB 944.66MB 140.00MB
datadog-agent-arm64-deb 0.00MB 935.37MB 935.37MB 140.00MB
datadog-dogstatsd-amd64-deb 0.00MB 78.54MB 78.54MB 10.00MB
datadog-dogstatsd-x86_64-rpm 0.00MB 78.62MB 78.62MB 10.00MB
datadog-dogstatsd-x86_64-suse 0.00MB 78.62MB 78.62MB 10.00MB
datadog-dogstatsd-arm64-deb 0.00MB 55.75MB 55.75MB 10.00MB
datadog-heroku-agent-amd64-deb 0.00MB 505.27MB 505.27MB 70.00MB
datadog-iot-agent-amd64-deb 0.00MB 113.34MB 113.34MB 10.00MB
datadog-iot-agent-x86_64-rpm 0.00MB 113.41MB 113.41MB 10.00MB
datadog-iot-agent-x86_64-suse 0.00MB 113.41MB 113.41MB 10.00MB
datadog-iot-agent-arm64-deb 0.00MB 108.81MB 108.81MB 10.00MB
datadog-iot-agent-aarch64-rpm 0.00MB 108.88MB 108.88MB 10.00MB
datadog-agent-x86_64-rpm -0.00MB 1200.39MB 1200.39MB 140.00MB
datadog-agent-x86_64-suse -0.00MB 1200.39MB 1200.39MB 140.00MB
datadog-agent-amd64-deb -0.00MB 1191.07MB 1191.07MB 140.00MB

Decision

✅ Passed

@misteriaud misteriaud added changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation labels Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog medium review PR review might take time qa/no-code-change No code change in Agent code requiring validation team/agent-shared-components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant