Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨[RUM-6798] Collect resource content type #3108

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

RomanGaignault
Copy link
Contributor

@RomanGaignault RomanGaignault commented Nov 5, 2024

Motivation

Content type is newly available on resource performance entry: PerformanceResourceTiming: contentType property - Web APIs | MDN

Changes

We could add it as a @resource.content_type field

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

@RomanGaignault RomanGaignault requested a review from a team as a code owner November 5, 2024 11:26
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.15%. Comparing base (4deadef) to head (d6dab8d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3108      +/-   ##
==========================================
- Coverage   93.63%   93.15%   -0.49%     
==========================================
  Files         276      276              
  Lines        7620     7623       +3     
  Branches     1711     1713       +2     
==========================================
- Hits         7135     7101      -34     
- Misses        485      522      +37     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RomanGaignault
Copy link
Contributor Author

/to-staging

@dd-devflow
Copy link

dd-devflow bot commented Nov 5, 2024

🚂 Branch Integration: starting soon, median merge time is 12m

Commit d6dab8d97a will soon be integrated into staging-45.

Use /to-staging -c to cancel this operation!

dd-mergequeue bot added a commit that referenced this pull request Nov 5, 2024
Integrated commit sha: d6dab8d

Co-authored-by: roman.gaignault <[email protected]>
@dd-devflow
Copy link

dd-devflow bot commented Nov 5, 2024

🚂 Branch Integration: This commit was successfully integrated

Commit d6dab8d97a has been merged into staging-45 in merge commit 266543ce58.

Check out the triggered pipeline on Gitlab 🦊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants