🐛 [RUM-6226][rum-react] improve routes wildcard substitution #3105
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In #3023, we implemented wildcard substition in react-router paths. For example, on a route like
/foo/*
, a path/foo/bar
would produce a view name/foo/bar
.It turns out we have an internal application which uses nested routes with wildcards, ex:
{ path: '*', children: [{ path: '*' }] }
. This is probably not popular use case, but still, it exists. The issue with the previous implementation is that it duplicated the path in the view name (a path/foo
would produce a view name/foo/foo
).Changes
This PR fixes this issue and consolidates the tests with more edge cases related to wildcards.
Testing
I have gone over the contributing documentation.