⬇️ [RUMF-1329] downgrade woke to a working version #1630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can't build our CI image with the latest version of `woke` because of get-woke/woke#195 . I didn't find an alternative to woke. I tried a bit to fix the issue, but: * I'm not fluent with go, and the fix is non-trivial * the issue seems to be in a woke dependency (`go-git`), and woke is using a fork of a fork of this dependency, making it hazardous to fix.
amortemousque
approved these changes
Jul 6, 2022
liywjl
approved these changes
Jul 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We can't build our CI image with the latest version of
wokebecause of get-woke/woke#195 .I didn't find an alternative to woke.
I tried a bit to fix the issue, but:
I'm not fluent with go, and the fix is non-trivial
the issue seems to be in a woke dependency (
go-git), and woke is using a fork of a fork of this dependency, making it hazardous to fix.Changes
Downgrade woke
Testing
I have gone over the contributing documentation.