Adjust retries for EBS attachment checks - #30
Merged
Conversation
Code Coverage DiffThis PR does not change the code coverage |
eakman-datadog
left a comment
eakman-datadog
left a comment
There was a problem hiding this comment.
@antonipp This seems okay to me. Could we try just deploying it to the terrapin clusters though and confirming we see an improvement?
eakman-datadog
self-requested a review
August 14, 2026 13:21
eakman-datadog
approved these changes
Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We noticed that EBS volume attachments are slower than the "1-4 seconds" that the polling was designed for. The current polling schedule is
t = 0, 1.0, 2.8, 6.04, 11.87, 22.37s, ...which makes us waste time since the attachment times we have now are:This PR makes the retries a bit tighter to reduce the time it takes to detect an attached volume. This will slightly increase the amount of
DescribeVolumesrequests.