[CXP-3538] Add zombieChildrenCount and zombieNetRate fields to Process proto#481
Merged
Conversation
wiyu
changed the title
kkhor-datadog
approved these changes
May 15, 2026
kkhor-datadog
left a comment
kkhor-datadog
left a comment
There was a problem hiding this comment.
double for zombieNetRate because the net rate can be negative
I don't know what this means, there is no unsigned equivalent of the double data type
Contributor
Author
@kkhor-datadog - Maybe not the best wording from claude, but double was chosen as the value can be negative (in the case of zombies being reaped) and this may have a decimal digit. |
Adds two new fields to the Process message in proto/process/agent.proto to support per-parent zombie aggregation (CXP-3538, RFC-driven, parent epic CXP-3442). Schema-only change — fields default to zero until a follow-up agent story populates them. Backward-compatible: older consumers ignore the new fields, newer consumers see zero defaults. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
uint32 zombieChildrenCount = 28anddouble zombieNetRate = 29to theProcessmessage inproto/process/agent.proto.process/agent.pb.goandprocess/agent.proto_builder.goviainv codegen.all.Context
JIRA: CXP-3538
The process-agent today emits one record per zombie process. We plan on replacing that with per-parent aggregation: for each parent we report how many zombie children it has (
zombieChildrenCount) and the net rate at which zombies are accumulating under it (zombieNetRate). Landing the schema here first so a release can be cut before the agent change starts depending on it.Notes
doubleforzombieNetRatebecause the net rate can be negative (creations − reapings).Test plan
inv codegen.allregenerates cleanly, no unexpected file changesgo build ./process/... ./proto/... ./pb/... ./gogen/...succeedsgo test ./process/...passes🤖 Generated with Claude Code