Add discoveryServiceMapEnabled field to AgentConfiguration proto by BarFinsdd · Pull Request #471 · DataDog/agent-payload

BarFinsdd · 2026-04-14T14:23:35Z

What does this PR do?

Adds a new discoveryServiceMapEnabled (field 7) boolean to the AgentConfiguration proto message in process/connections.proto. This allows the agent to signal whether the Discovery service map feature is enabled in its
configuration.

Motivation

Enables the agent to communicate whether the Discovery dependency map (service map) feature is turned on, so downstream consumers (e.g. the backend/process-agent) can act on that configuration flag. This is the proto
groundwork for the Discovery service map POC.

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

Reviewer's Checklist

Reviewers: please see the review guidelines.

brycekahle

It seems fine, but I'm curious if you need a flag at all? Is there going to be additional data in the payload? Would the existence of that data indicate the feature is enabled?

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 76133a4c54

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-04-28T13:52:22Z

+	// Populated by discovery service map mode in lieu of DDSketches and
+	// firstLatencySample, since discovery mode does not retain a sketch
+	// or per-request samples.
+	AvgLatency float64 `protobuf:"fixed64,5,opt,name=avgLatency,proto3" json:"avgLatency,omitempty"`


Regenerate descriptor metadata for new avgLatency field

Adding AvgLatency here without updating the embedded fileDescriptor_69b34851fbf62631 leaves HTTPStats_Data.Descriptor() out of sync with the struct and marshal/unmarshal logic. Any reflection-based consumer (e.g., descriptor-driven tooling, dynamic protobuf handling, or schema introspection) will not see avgLatency and can silently ignore/drop it even though generated encode/decode methods now use field 5; this commit should include a full proto regeneration so descriptor metadata matches the new field.

Useful? React with 👍 / 👎.

DanielLavie · 2026-05-10T09:30:01Z

It seems fine, but I'm curious if you need a flag at all? Is there going to be additional data in the payload? Would the existence of that data indicate the feature is enabled?

@brycekahle This flag means we won’t bill for USM and will process the data through the new discovery service map pipeline

BarFinsdd · 2026-05-12T09:09:53Z

/merge

gh-worker-devflow-routing-ef8351 · 2026-05-12T09:09:59Z

View all feedbacks in Devflow UI.

2026-05-12 09:09:59 UTC ℹ️ Start processing command /merge

2026-05-12 09:10:06 UTC ℹ️ MergeQueue: waiting for PR to be ready

This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals. View in MergeQueue UI.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2026-05-12 10:10:28 UTC ⚠️ MergeQueue: This merge request was unqueued

bar.fins@datadoghq.com unqueued this merge request

BarFinsdd · 2026-05-12T10:10:15Z

/merge -c

gh-worker-devflow-routing-ef8351 · 2026-05-12T10:10:22Z

View all feedbacks in Devflow UI.

2026-05-12 10:10:22 UTC ℹ️ Start processing command /merge -c

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Discovery service map mode does not retain DDSketches or per-request samples; it tracks only counts and a running latency sum. Add a dedicated avgLatency field (nanoseconds) so downstream consumers can distinguish discovery-mode averages from the legacy firstLatencySample single-sample optimization. Field 5 on HTTPStats.Data, double, fixed64. Generated code edited by hand (proto codegen toolchain isn't available on Windows). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Discovery service map mode previously shipped a precomputed mean (LatencySum/Count) on the wire. That prevents the backend from correctly aggregating across hosts (an average of averages requires weighting by sample count, and we lose that information once the mean is computed client-side per flush window). Switch the proto field to carry the raw running latency sum. The backend (NSX) computes the mean as latencySum/count when emitting dd.apm.usm_service_map.latency_ns, matching the resolved design in the USM Discovery Mode RFC, Appendix B. Field number unchanged (5) so wire encoding is identical; only the field name and the agent's interpretation of it change. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 595b669d7d

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-05-12T10:58:20Z

+	// and firstLatencySample. The mean is computed at the backend as
+	// latencySum / count; shipping the raw sum (instead of a precomputed
+	// mean) preserves correct cross-host aggregation.
+	LatencySum float64 `protobuf:"fixed64,5,opt,name=latencySum,proto3" json:"latencySum,omitempty"`


Regenerate the descriptor with the latencySum name

Fresh evidence after the rename: decompressing fileDescriptor_69b34851fbf62631 in this file still shows field 5 as avgLatency and contains no latencySum, while the generated struct/marshal/unmarshal code now uses LatencySum with protobuf name latencySum. Reflection-based consumers using HTTPStats_Data.Descriptor() will therefore see the wrong schema name for field 5 and can ignore or mis-handle the new metric; please regenerate the protobuf output so the embedded descriptor matches the proto and generated methods.

Useful? React with 👍 / 👎.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1f6234f814

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-05-12T11:07:20Z

+        rm -rf $GOPATH/src/github.com/DataDog/agent-payload
+        ln -sf {root_dir} $GOPATH/src/github.com/DataDog/agent-payload


Avoid deleting the checked-out repository during codegen

In the codegen workflow I checked, the job runs from /home/runner/work/agent-payload/agent-payload/go/src/github.com/DataDog/agent-payload with GOPATH=/home/runner/work/agent-payload/agent-payload/go (.github/workflows/test.yml), so $GOPATH/src/github.com/DataDog/agent-payload is the current checkout and also {root_dir}. This new rm -rf therefore deletes the repository before recreating a symlink to the same now-deleted path, causing the subsequent mkdir, protoc, and final git diff steps to operate on a missing/self-referential checkout; it also breaks the documented local setup where the repo is already checked out inside GOPATH.

Useful? React with 👍 / 👎.

…dep-map-poc # Conflicts: # process/agent.pb.go # process/connections.pb.go

BarFinsdd · 2026-05-12T11:13:19Z

/merge

gh-worker-devflow-routing-ef8351 · 2026-05-12T11:13:24Z

View all feedbacks in Devflow UI.

2026-05-12 11:13:23 UTC ℹ️ Start processing command /merge

2026-05-12 11:13:27 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 3m (p90).

2026-05-12 11:15:26 UTC 🚨 MergeQueue: This merge request is in error because of DDCI

DDCI pipeline didn't start (sourcing_failed)... Please retry.

DDCI Change Request: 8823896131387910928
You can get help from #ci-infra-support

BarFinsdd self-assigned this Apr 14, 2026

BarFinsdd requested review from a team as code owners April 14, 2026 14:23

BarFinsdd requested a review from matthewleese April 14, 2026 14:23

matthewleese approved these changes Apr 14, 2026

View reviewed changes

BarFinsdd force-pushed the bar.fins/discovery-dep-map-poc branch 2 times, most recently from 0233288 to c9b279f Compare April 21, 2026 10:14

brycekahle approved these changes Apr 24, 2026

View reviewed changes

BarFinsdd requested review from a team as code owners April 28, 2026 13:48

chatgpt-codex-connector Bot reviewed Apr 28, 2026

View reviewed changes

daniel-taf approved these changes May 5, 2026

View reviewed changes

kkhor-datadog approved these changes May 5, 2026

View reviewed changes

aureleoules approved these changes May 6, 2026

View reviewed changes

DanielLavie approved these changes May 10, 2026

View reviewed changes

gh-worker-dd-devflow-36fce6 Bot added the mergequeue-status: waiting label May 12, 2026

gh-worker-dd-devflow-36fce6 Bot added mergequeue-status: removed and removed mergequeue-status: waiting labels May 12, 2026

BarFinsdd and others added 5 commits May 12, 2026 13:14

Add discoveryServiceMapEnabled field to AgentConfiguration proto

0874186

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Run codegen for discoveryServiceMapEnabled field in AgentConfiguration

1c3fa7d

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Regenerate process/agent.pb.go

79c15fe

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

BarFinsdd force-pushed the bar.fins/discovery-dep-map-poc branch from 8f6dc28 to 595b669 Compare May 12, 2026 10:54

chatgpt-codex-connector Bot reviewed May 12, 2026

View reviewed changes

BarFinsdd requested a review from a team as a code owner May 12, 2026 11:04

BarFinsdd requested a review from nathan-b May 12, 2026 11:04

BarFinsdd force-pushed the bar.fins/discovery-dep-map-poc branch from 1f6234f to 595b669 Compare May 12, 2026 11:06

chatgpt-codex-connector Bot reviewed May 12, 2026

View reviewed changes

Merge remote-tracking branch 'origin/master' into bar.fins/discovery-…

e634912

…dep-map-poc # Conflicts: # process/agent.pb.go # process/connections.pb.go

BarFinsdd force-pushed the bar.fins/discovery-dep-map-poc branch from 624fb85 to e634912 Compare May 12, 2026 11:10

gh-worker-dd-devflow-36fce6 Bot added mergequeue-status: queued mergequeue-status: in_progress mergequeue-status: error and removed mergequeue-status: removed mergequeue-status: queued mergequeue-status: in_progress labels May 12, 2026

BarFinsdd merged commit 2c12a0a into master May 12, 2026
8 of 9 checks passed

		rm -rf $GOPATH/src/github.com/DataDog/agent-payload
		ln -sf {root_dir} $GOPATH/src/github.com/DataDog/agent-payload

Conversation

BarFinsdd commented Apr 14, 2026

What does this PR do?

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

Reviewer's Checklist

Uh oh!

brycekahle left a comment

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Apr 28, 2026

Choose a reason for hiding this comment

Uh oh!

DanielLavie commented May 10, 2026

Uh oh!

BarFinsdd commented May 12, 2026

Uh oh!

gh-worker-devflow-routing-ef8351 Bot commented May 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

BarFinsdd commented May 12, 2026

Uh oh!

gh-worker-devflow-routing-ef8351 Bot commented May 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot May 12, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot May 12, 2026

Choose a reason for hiding this comment

Uh oh!

BarFinsdd commented May 12, 2026

Uh oh!

gh-worker-devflow-routing-ef8351 Bot commented May 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

gh-worker-devflow-routing-ef8351 Bot commented May 12, 2026 •

edited

Loading

gh-worker-devflow-routing-ef8351 Bot commented May 12, 2026 •

edited

Loading

gh-worker-devflow-routing-ef8351 Bot commented May 12, 2026 •

edited

Loading