Skip to content

conform.yaml: update to coreboot guidelines #614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: dasharo-24.02.1
Choose a base branch
from
Draft

conform.yaml: update to coreboot guidelines #614

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .conform.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,11 @@ policies:
- type: commit
spec:
header:
length: 80
length: 75
imperative: false
invalidLastCharacters: .
body:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can the length be specified separately for body? There is also a limit for it, and it used to be 72 (see e.g. https://review.coreboot.org/c/coreboot/+/82041/8..9//COMMIT_MSG#b12), I don't know if it changed recently or not.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be new: https://review.coreboot.org/c/coreboot/+/85915

Copy link
Contributor Author

@macpijan macpijan Feb 7, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At present, the body is just checked if it exists. There is no enforcement on the line length whatsoever, it seems. So this would also need to be implemented.

required: false
required: true
dco: true
gpg:
required: true
Expand Down