-
Notifications
You must be signed in to change notification settings - Fork 2
Migrate docs to mkdocs #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Comparing the overall look and feel After: In my opinion it looks so much worse... It was @macpijan idea/request to migrate to mkdocs: #5 (comment) so maybe he can review as well. |
|
@miczyg1 I agree, it's much less readable. |
|
@macpijan Have you looked at this? |
|
@macpijan we would like to have the release by the end of the week. We would appreciate your review and opinion about mkdocs vs sphinix. I would also prefer mkdocs, but the question is how to make it look reasonable. |
Have you researched alternative themes or mkdocs @PLangowski ? |
|
@miczyg1
Still not great, but better than the previous one IMO. If we don't choose this, then I'm afraid we will have to look for/create our own custom theme. |
Much better than the previous one.
I guess we will have to stick with this. Unless @macpijan will retract with his request to migrate to mkdocs. |
|
@PLangowski Please link issue to PR if you work on one. I assume it's this one: Dasharo/dasharo-issues#451 If you go through it's content, the readthedocs template is explicitly mentioned, so I am not sure why we are discovering it again. I would stick to this if we had done the migration work already. |
Signed-off-by: Pawel Langowski <[email protected]>
Thanks for clarifying @macpijan Now that I look on mkdocstrings parsers, Sphinx style has the poorest support: https://mkdocstrings.github.io/griffe/reference/docstrings/#parsers-features |
|
@miczyg1
Either way, we can plan a full migration for |
I don't know how much time do you have left but I still don't think I can sign-off the mkdocs migration in its current state. To me it is incomplete. I can merge this PR, but the mkdocs migration will not be finished IMO. @pietrushnic cc |



No description provided.