Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mediaPlayer.addTextTrack() #3573

Open
wants to merge 9 commits into
base: development
Choose a base branch
from
Open

Add mediaPlayer.addTextTrack() #3573

wants to merge 9 commits into from

Commits on Mar 13, 2021

  1. Add MediaPlayer.addTextTrack-method 

    This method allows for loading captions from a file not listed in the
manifest.
    @malthejorgensen
    malthejorgensen committed Mar 13, 2021
    Configuration menu
    Copy the full SHA
    03317ed View commit details
    Browse the repository at this point in the history

  2. Don't override current captions -- add a new track

    @malthejorgensen
    malthejorgensen committed Mar 13, 2021
    Configuration menu
    Copy the full SHA
    b1672ba View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2021

  1. addTextTrack: Add mediaInfo-argument

    @malthejorgensen
    malthejorgensen committed Mar 16, 2021
    Configuration menu
    Copy the full SHA
    400c5a8 View commit details
    Browse the repository at this point in the history

  2. Add TextTracks.getNumberOfTextTracks() 

    Needed for MediaPlayer.addTextTrack()
    @malthejorgensen
    malthejorgensen committed Mar 16, 2021
    Configuration menu
    Copy the full SHA
    b32c526 View commit details
    Browse the repository at this point in the history

  3. Remove unused comments

    @malthejorgensen
    malthejorgensen committed Mar 16, 2021
    Configuration menu
    Copy the full SHA
    599d31a View commit details
    Browse the repository at this point in the history

  4. CaptionsLoader: Remove unused baseUri

    @malthejorgensen
    malthejorgensen committed Mar 16, 2021
    Configuration menu
    Copy the full SHA
    e369a9b View commit details
    Browse the repository at this point in the history

  5. external-caption-vtt sample: Use relative URL

    @malthejorgensen
    malthejorgensen committed Mar 16, 2021
    Configuration menu
    Copy the full SHA
    e65cc56 View commit details
    Browse the repository at this point in the history

Commits on Apr 2, 2021

  1. CaptionsLoader.js: Remove unused comment

    @malthejorgensen
    malthejorgensen committed Apr 2, 2021
    Configuration menu
    Copy the full SHA
    97006db View commit details
    Browse the repository at this point in the history

  2. External captions: Reuse TextSourceBuffer.createTextTrackFromMediaInfo 

    Move `EXTERNAL_CAPTIONS_LOADED`-event listener into TextSourceBuffer
and to allow reusing `createTextTrackFromMediaInfo`.
This requires passing `mediaInfo` to CaptionsLoader and adding the
passed MediaInfo to `TextSourceBuffer.mediaInfos`.

Also removes `TextTracks.getNumberOfTextTracks()` which is no longer
needed.
    @malthejorgensen
    malthejorgensen committed Apr 2, 2021
    Configuration menu
    Copy the full SHA
    39773bb View commit details
    Browse the repository at this point in the history