Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ClerkJWT] Deserialize any remaining fields in jwt #63

Merged
merged 1 commit into from
Aug 28, 2024
Merged

[ClerkJWT] Deserialize any remaining fields in jwt #63

merged 1 commit into from
Aug 28, 2024

Conversation

kageiit
Copy link
Contributor

@kageiit kageiit commented Aug 27, 2024 •
edited
Loading

Addresses #56 (comment)

This is useful for custom templates/compatibility with future updates to the clerk jwt schema

@kageiit kageiit mentioned this pull request Aug 27, 2024
Merged
DarrenBaldwin07
DarrenBaldwin07 approved these changes Aug 28, 2024
View reviewed changes
Copy link
Owner

@DarrenBaldwin07 DarrenBaldwin07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Forgot that serde's default behavior is to just discard unknown fields when deserializing. We are just about to need this at Tembo so perfect timing 😄

@DarrenBaldwin07 DarrenBaldwin07 merged commit c6c585e into DarrenBaldwin07:main Aug 28, 2024
1 check passed
GodTamIt added a commit to GodTamIt/clerk-rs that referenced this pull request Aug 28, 2024
@GodTamIt
Make ClerkJwt::other field public
8c521f3 
This makes the changes from DarrenBaldwin07#63 usable
@GodTamIt GodTamIt mentioned this pull request Aug 28, 2024
Merged
DarrenBaldwin07 pushed a commit that referenced this pull request Aug 28, 2024
@GodTamIt
Make ClerkJwt::other field public (#64)
30decf4 
This makes the changes from #63 usable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DarrenBaldwin07 DarrenBaldwin07 DarrenBaldwin07 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kageiit @DarrenBaldwin07