Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix crash, webp support #762

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

Kronos2308
Copy link

@Kronos2308 Kronos2308 commented Nov 12, 2024

Simple code to support .webp format
Download and install: 8/12/24
app-debug.zip
to fix the issue temporary

Thanks to #756
It is an interesting application.
I only have Notepad++, so I work with that.
you just need to add one more extension WEBP("webp")
but the app is programmed to work with extensions of 3 characters jpg png gif,
webp has 4 characters so I just touched the part that arbitrarily takes the final 3 characters for something more flexible and then you just have to modify the regex, with which you search the files
and the functions that converted the extension into a character and the character into an extension
simply follow the functions from the inside out

@riyekawai
Copy link

bro你真是赛博活菩萨
当代活耶稣

@renalicia
Copy link

how do I add the extension?

@Kronos2308
Copy link
Author

By installing app-debug.zip

@renalicia
Copy link

I believe this alternative is good and offers a better gallery. However, there is one thing missing: whenever I reach the bottom of what I read, I usually see suggestions for related titles, but this alternative does not have that feature. I think that is the only thing lacking at the moment. As for the rest, I haven't encountered any errors.

@Kronos2308
Copy link
Author

Kronos2308 commented Nov 12, 2024

It's probably part of the same error.Even though I added the extension to almost the entire app, it's just a patch. I don't fully understand how the entire app works.
I try to made work the basics
Stop crashing, display icons on main screen and load images to read
Downloads , favorites
The cash what's fixed by #756
From there I have to add some code to handle webp extension,

@renalicia
Copy link

It's probably part of the same error. Even though I added the extension to almost the entire app, it's just a patch. I don't fully understand how the entire app works.

I just checked it again and it's now appearing. Thank you for the work.

@ClemCa
Copy link

ClemCa commented Nov 13, 2024

Do you know of any way to deal with the android sandboxing so the debug version gets to access the release version's downloads? Because they have different signatures, they also have different folders. I tried messing with the dev compatibility flags but I couldn't find anything that could help me with that. I remembered slightly there were ways to deal with that in previous android versions, but I'm unsure if it still exists (without literally having the app ask for admin status)

@Kronos2308
Copy link
Author

I am using root but
You can simply just move the folder to the debug app location or you can set the same folder on settings

@ClemCa
Copy link

ClemCa commented Nov 13, 2024

Using the same path in settings, I found that either app can't see the other's files. There's no conflict too, I tried downloading on one and it didn't corrupt the other's download manifest. They are truly sandboxed by some insane magic I don't get. I might try to check the files out to see how they made this work.

@Kronos2308
Copy link
Author

Using the same path in settings, I found that either app can't see the other's files. There's no conflict too, I tried downloading on one and it didn't corrupt the other's download manifest. They are truly sandboxed by some insane magic I don't get. I might try to check the files out to see how they made this work.

But you can just rename the android data app id with the id of the debug if you not have permission you can use adb shell cp /releasedata/* /debugdata/ -r

@renalicia
Copy link

About the downloads. I connected my phone to my pc to easily access my files and moved the files to the Debug version. It's hard to move the files on phone only so i suggest you guys to try using pc or laptop instead to move the files

@2944755662
Copy link

妙手回春啊大夫

@2944755662
Copy link

谢谢您治好我弟弟,差点我的弟弟连口水都流不出来了

@chidoin
Copy link

chidoin commented Nov 17, 2024

Thank you so much

@mengmeng810416
Copy link

这个安装包提示要卸载旧的安装包,我下载的那些该怎么办啊,求大佬教教怎么只卸载安装包不删除下载的图片

@mengmeng810416
Copy link

好吧,原来只能把下载的导到电脑上,再装回来了。
话说让我试试另一个人的3.0.6版本的那位,我试了,挺好使,新本子也不崩溃了,但是为啥无法下载本子啊,只走流量本子下不动

@mengmeng810416
Copy link

而且要想导老版本数据好像也只能导电脑上,这个app的导入导出数据功能只能把收藏夹,未下载的本子,状态显示那些导入导出,不能把已下载的本子导出啊

@Heluojiang
Copy link

而且要想导老版本数据好像也只能导电脑上,这个app的导入导出数据功能只能把收藏夹,未下载的本子,状态显示那些导入导出,不能把已下载的本子导出啊

You can do this in the following way: Find the folder you downloaded in Settings-Folder Location, then open the new app and set it to the same directory path. This should solve the problem that your downloads cannot be seen; in addition, if you need to sync favorites and status viewers, you need to use Settings-Other Settings-Export Data and select Settings-Other Settings-Export Data on the new app and select the corresponding file to import

你可以通过如下方式:在设置-文件夹位置中找到你下载的文件夹,然后打开新的app设置成相同的目录路径,这应该可以解决你的下载无法看见的问题;另外如果你需要同步收藏和状态查看器,你需要使用设置-其他设置-导出数据并在新app上选择设置-其他设置-导出数据并选择对应文件导入

@Heluojiang
Copy link

Using the same path in settings, I found that either app can't see the other's files. There's no conflict too, I tried downloading on one and it didn't corrupt the other's download manifest. They are truly sandboxed by some insane magic I don't get. I might try to check the files out to see how they made this work.

You can do this in the following way: Find the folder you downloaded in Settings-Folder Location, then open the new app and set it to the same directory path. This should solve the problem that your downloads cannot be seen; in addition, if you need to sync favorites and status viewers, you need to use Settings-Other Settings-Export Data and select Settings-Other Settings-Export Data on the new app and select the corresponding file to import

damianjester added a commit to damianjester/NClient that referenced this pull request Dec 5, 2024
@Heluojiang
Copy link

Do you want to commit to https://github.com/maxwai/NClientV3?It seems keep alive together

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants