add property-based and stress tests

Daoortor · Dec 9, 2024 · a7315ec · a7315ec
1 parent 07ea477
commit a7315ec
Show file tree

Hide file tree

Showing 4 changed files with 91 additions and 1 deletion.
diff --git a/core/src/pathfinder.cpp b/core/src/pathfinder.cpp
@@ -70,7 +70,7 @@ std::optional<Journey> pathfind(const TransportSystem &transportSystem, const QS
                     dpEntry *currentStopOpt = &prevLayer[currentStopIndexInStops];
                     dpEntry *targetOpt = &prevLayer[targetIndex];
                     // Relax dp; target pruning - ignore routes after earliest known arrival time at target
-                    if (currentStopTime->arrivalTime < std::min(currentStopOpt->optimalTime, targetOpt->optimalTime)) {
+                    if (currentStopTime->arrivalTime < std::min(currentStopOpt->optimalTime, targetOpt->optimalTime) && boardedStop != currentStop) {
                         curLayer[currentStopIndexInStops] = {
                             currentStopTime->arrivalTime,
                             nullptr,

diff --git a/test/main.cpp b/test/main.cpp
@@ -77,6 +77,31 @@ TEST_CASE("Pathfinder test") {
                 }
             ).check();
         }
+
+        SUBCASE("Triangle inequality") {
+            const int N_TESTS = 10;
+
+            for (int i = 0; i < N_TESTS; i++) {
+                std::uniform_int_distribution<> randomStop(0, hamburg.stops.size() - 1);
+                const Stop *a = &hamburg.stops[randomStop(rng)];
+                const Stop *b = &hamburg.stops[randomStop(rng)];
+                const Stop *c = &hamburg.stops[randomStop(rng)];
+                std::optional<Journey> aTob_ = pathfind(hamburg, a->id, b->id, initDateTime);
+                if (!aTob_.has_value()) {
+                    continue;
+                }
+                Journey &aTob = aTob_.value();
+                std::optional<Journey> bToc_ = pathfind(hamburg, b->id, c->id, aTob.arrivalTime);
+                if (!bToc_.has_value()) {
+                    continue;
+                }
+                Journey &bToc = bToc_.value();
+                std::optional<Journey> aToc_ = pathfind(hamburg, a->id, c->id, initDateTime);
+                assert(aToc_.has_value());
+                Journey &aToc = aToc_.value();
+                assert(aToc.arrivalTime <= bToc.arrivalTime);
+            }
+        }
     }
 
     SUBCASE("Paris") {
@@ -138,6 +163,25 @@ TEST_CASE("Substring find test") {
         std::vector<QString> expected;
         assert(expected == result);
     }
+
+    SUBCASE("Stress test") {
+        const int N_TESTS = 5;
+        const int N_STRINGS = 50;
+        const int N_SUBSTRINGS = 200;
+        const int STRING_LENGTH = 10;
+        const int SUBSTRING_LENGTH = 2;
+
+        for (int i = 0; i < N_TESTS; i++) {
+            std::vector strings = generateStrings(N_STRINGS, STRING_LENGTH);
+            SuffixAutomaton sa(strings);
+            for (int j = 0; j < N_SUBSTRINGS; j++) {
+                QString substring = generateString(SUBSTRING_LENGTH);
+                std::vector<QString> expected = naiveFindAllStringsContaining(strings, substring);
+                std::vector<QString> actual = sa.findAllStringsContaining(substring);
+                assert(expected == actual);
+            }
+        }
+    }
 }
 
 }
diff --git a/test/util.cpp b/test/util.cpp
@@ -55,4 +55,36 @@ void TestCase::check() const {
     }
 }
 
+QString generateString(size_t len) {
+    std::string result;
+    result.reserve(len);
+    for (size_t i = 0; i < len; ++i) {
+        result += 'a' + randomChar(rng);
+    }
+
+    return result.c_str();
+}
+
+
+std::vector<QString> generateStrings(size_t n, size_t len) {
+    std::vector<QString> result;
+    result.reserve(n);
+    for (size_t i = 0; i < n; i++) {
+        result.push_back(generateString(len));
+    }
+    return result;
+}
+
+std::vector<QString> naiveFindAllStringsContaining(const std::vector<QString> &strings, const QString &substring) {
+    std::vector<QString> result;
+    std::string stdSubstring = substring.toStdString();
+    for (auto &string : strings) {
+        if (string.toStdString().find(stdSubstring) != string.toStdString().npos) {
+            result.push_back(string);
+        }
+    }
+    std::ranges::sort(result);
+    return result;
+}
+
 }
diff --git a/test/util.h b/test/util.h
@@ -6,9 +6,17 @@
 
 #include <string>
 #include <vector>
+#include <random>
 
 namespace sdtmaps::test {
 
+static std::random_device rd;
+static std::mt19937 rng{rd()};
+static std::uniform_int_distribution randomChar(0, 51);
+
+static QDateTime initDateTime = QDateTime(QDate::fromJulianDay(0), QTime(0, 0));
+
+
 BETTER_ENUM(JourneyElementType, int, RIDE, TRANSFER);
 
 struct SimplifiedJourneyElement {
@@ -45,6 +53,12 @@ struct TestCase {
     void check() const;
 };
 
+QString generateString(size_t len);
+
+std::vector<QString> generateStrings(size_t n, size_t len);
+
+std::vector<QString> naiveFindAllStringsContaining(const std::vector<QString> &strings, const QString &substring);
+
 }
 
 #endif //UTIL_H