Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

!!DO NOT MERGE!! Support reusable slices #80

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

DamianEdwards
Copy link
Owner

@DamianEdwards DamianEdwards commented Dec 20, 2024

This is WIP, not ready to merge yet. If I do decide to merge this I might mark it experimental initially as it's a bit scary.

Related to #79

@DamianEdwards DamianEdwards linked an issue Dec 20, 2024 that may be closed by this pull request

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 8 changed files in this pull request and generated no comments.

Files not reviewed (3)
  • samples/RazorSlices.Samples.WebApp/Slices/Lorem/LoremFormattable.cshtml: Evaluated as low risk
  • tests/BenchmarksWebApps/RazorSlices.Benchmarks.RazorClassLibrary.Local/ReusableHello.cshtml: Evaluated as low risk
  • src/RazorSlices/IRazorReusableSlice.cs: Evaluated as low risk
Comments suppressed due to low confidence (2)

tests/BenchmarksWebApps/RazorSlices.Benchmarks.RazorClassLibrary.Local/LocalVersion.cs:19

  • The new method RenderReusableHello is introduced without any test coverage. Please add tests to verify its behavior.
public static ValueTask<string> RenderReusableHello()

src/RazorSlices/RazorSlice.cs:204

  • Ensure that the new reusable slice functionality, including the commented-out Dispose call, is covered by tests.
//Dispose();
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support reusable slices
1 participant