Do explicit uint casting in GLSL operations

[illwieckz]

Do explicit uint casting in GLSL operations.

Fixes #1611:

• Some bitwise errors on Mali G52 r1 #1611

[illwieckz]

I confirm it fixes #1611:

• Some bitwise errors on Mali G52 r1 #1611

[illwieckz]

Curiously the last commit (wip: set u_numLights and u_lightLayer as uint from the start) is generating a bunch of:

OpenGL error GL_INVALID_OPERATION detected

When running with this environment:

export MESA_GL_VERSION_OVERRIDE='3.1'
export MESA_GLSL_VERSION_OVERRIDE='140'
export MESA_EXTENSION_OVERRIDE='-GL_ARB_gpu_shader5'

And this breaks dynamic lighting.

But the last too commits (this one and the one before it) are totally optional. So without those commits making things cleaner, it would work anyway.

[illwieckz]

I removed all commits that were not meant to fix the #1611 bug.

Fixes for other bugs found when debugging this are now tracked there:

• renderer: catch shader source processing exceptions and print raw source #1614

Further improvements (like passing some variables as uint directly instead of casting them) can be done later.

[VReaperV]

This could potentially fix #1491.

[VReaperV]

I think this should keep at least the outer parentheses so it's clear immediately what the intended order of operations is.

[illwieckz]

Right, this is because I first added explicit cast everywhere to get something working, so I ended transforming ( ... ) into uint( ... ). But then when I tracked down the useless casts, I mistakenly deleted the parentheses that were there before…

Now fixed.

[illwieckz]

This could potentially fix #1491.

Yes #1491 is very likely the same bug as #1611, they're both running OpenGL 3.1 with GLSL 1.40, and I can reproduce the bug (which is now fixed) with other Mesa drivers (radeonsi…) when I force GL 3.1 and GLSL 1.40.

[VReaperV]

LGTM

[illwieckz]

LGTM

Thank you very much!