-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the contact
cvar and server info string to contain contact information to reach out the server admin when needed
#1465
base: master
Are you sure you want to change the base?
Conversation
…tact information to reach out the server admin when needed
… like /systeminfo and /serverinfo)
The
The idea is that we will encourage public server owners to give some contact information, be it a chat or forum nick, or email address, or whatever we can use to reach them. This could be usable to reach out server admins outside of the game for processing abusive behavior from players. It is why it is named This could also be usable to reach out server admin to tell them to update their servers. Actually writing there the forum nick may allow us to integrate the web server list with the forum private message feature. At some point we may recommend this. |
At some point we may enforce this string to be set for starting public servers. People will still be free to put garbage there so giving information will still not be mandatory, but it would be mandatory for the public server owner to decide to not give contact information on purpose. So people wanting to remain fully anonymous (even not disclosing their forum/chat nick name) but actually doing things right would not be bothered. But if we need to contact a server owner because of abusive behavior not being processed and we discover the server owner intentionally doesn't want to be reached out, we may decide to blacklist the server. So basically it would help to make the difference between neglect and intentional ill-will. That's why I believe we may require that value to be set in the future for starting public servers, as making it a requirement:
What we can do is to have it optional (with the warning) for the next version and the next-next version would make it required. |
src/engine/server/sv_init.cpp
Outdated
@@ -437,6 +440,12 @@ void SV_SpawnServer(std::string pakname, std::string mapname) | |||
SV_ShutdownGameProgs(); | |||
|
|||
PrintBanner( "Server Initialization" ) | |||
|
|||
if ( SV_Private( ServerPrivate::Public ) && cvar_abuse.Get().empty() ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The condition is inverted here. Also I suggest including sv_networkScope so that it matches the condition for advertising to the master server. So !SV_Private(ServerPrivate::NoAdvertise) && sv_networkScope >= 2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is still not fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
src/engine/server/sv_init.cpp
Outdated
@@ -52,6 +52,9 @@ static Cvar::Cvar<std::string> cvar_pakname( | |||
"pakname", "pak containing current map", Cvar::SERVERINFO | Cvar::ROM, ""); | |||
static Cvar::Cvar<std::string> sv_paks( | |||
"sv_paks", "currently loaded paks", Cvar::SYSTEMINFO | Cvar::ROM, ""); | |||
static Cvar::Cvar<std::string> cvar_abuse( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why call it "abuse" if that's not the main motivation for providing it? How about "contact" or "admin"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be named contact
, I first named it admin
but then it sounded weird because there are other admin*
commands and this would be confusing. Then my next example in mind was the abuse@
mail address convention. But I'm fully open to other names, like contact
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I renamed to contact
.
abuse
cvar and server info string to contain contact information to reach out the server admin when neededcontact
cvar and server info string to contain contact information to reach out the server admin when needed
0050dbf
to
e8eeed3
Compare
A commented-out example in LGTM |
contact
cvar and server info string to contain contact information to reach out the server admin when neededInfo_Print()
(used by commands like/systeminfo
and/serverinfo
)