Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:add cow limit order core action #324

Draft
wants to merge 18 commits into
base: develop
Choose a base branch
from

Conversation

yathindrak
Copy link
Contributor

@yathindrak yathindrak commented Mar 20, 2023

Description

Adds new cow limit order core action.

Closes #189

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

My.Movie.mp4

Checklist:

  • My code follows the existing style of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any UI changes have been tested and made responsive for mobile views

@vercel
Copy link

vercel bot commented Mar 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
davi ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 29, 2023 at 4:51AM (UTC)

@yathindrak
Copy link
Contributor Author

Found an existing issue that affects this feature. The issue is, the app crashes when clicking on the approve function signature.

Screenshot 2023-03-29 at 08 40 32

The issue is fixed with this pr itself: https://github.com/DXgovernance/davi-monorepo/pull/324/files#diff-83170dbccf333f64e59e868d4a60f2cb110ac25ed973000aff2a4614af3581deL105

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cowswap core action
1 participant