Merge pull request #357 from dcrescimbeni/fix/approval-assets-bug

Fix: approval call was incorrectly decoded
DXgovernance · Mar 29, 2023 · e3b1798 · e3b1798 · vercel · Mar 29, 2023
2 parents 9c05d42 + 23e165b
commit e3b1798
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/...i/src/components/ActionsBuilder/SupportedActions/GenericCall/GenericCallParamsMatcher.tsx b/...i/src/components/ActionsBuilder/SupportedActions/GenericCall/GenericCallParamsMatcher.tsx
@@ -44,7 +44,7 @@ export const renderGenericCallParamValue = (
       return `${param.value}`;
     case 'tokenAmount':
       // TODO: Handle number of decimals better
-      const number = BigNumber.from(param.value);
+      const number = BigNumber.from(param.value ?? 0);
       let formatted = Number.parseFloat(formatUnits(number, 18));
       return Math.round(formatted * Math.pow(10, 4)) / Math.pow(10, 4);
     case 'contentHash':

diff --git a/apps/davi/src/utils/encodingCalls.ts b/apps/davi/src/utils/encodingCalls.ts
@@ -102,7 +102,7 @@ export const encodeActions = async (
           ...newCall,
           approval: {
             ...decodedApprovalCall,
-            amount: decodedApprovalCall?.args?._value,
+            amount: decodedApprovalCall?.args?.amount,
             token: decodedApprovalCall?.to,
           },
         };