Skip to content

#5636 - fixing i18n translation problem for date picker labels #5647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kanasznagyzoltan wants to merge 1 commit into
base: main
Choose a base branch
from
Open

#5636 - fixing i18n translation problem for date picker labels #5647

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/app/shared/form/builder/ds-dynamic-form-ui/models/date-picker/date-picker.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
[(ngModel)]="initialYear"
[value]="year"
[invalid]="showErrorMessages"
[placeholder]="'form.date-picker.placeholder.year' | translate"
[placeholder]="'Year'"
Copy link
Copy Markdown
Member

@tdonohue tdonohue May 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kanasznagyzoltan : As @GauravD2t pointed out, I think these placeholders need to be lowercased. In the en.json5 file the i18n keys are as follows:

 "form.date-picker.placeholder.year": "Year",

  "form.date-picker.placeholder.month": "Month",

  "form.date-picker.placeholder.day": "Day",

But, by making this uppercased Year, you are trying to use a non-existent key of form.date-picker.placeholder.Year instead of form.date-picker.placeholder.year.

[widthClass]="'four-digits'"
(blur)="onBlur($event)"
(change)="onChange($event)"
Expand All @@ -35,7 +35,7 @@
[size]="2"
[(ngModel)]="initialMonth"
[value]="month"
[placeholder]="'form.date-picker.placeholder.month' | translate"
[placeholder]="'Month'"
[disabled]="!year || model.disabled"
[widthClass]="'two-digits'"
(blur)="onBlur($event)"
Expand All @@ -52,7 +52,7 @@
[size]="2"
[(ngModel)]="initialDay"
[value]="day"
[placeholder]="'form.date-picker.placeholder.day' | translate"
[placeholder]="'Day'"
[disabled]="!month || model.disabled"
[widthClass]="'two-digits'"
(blur)="onBlur($event)"
Expand Down
8 changes: 4 additions & 4 deletions src/app/shared/form/number-picker/number-picker.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@
tabindex="0"
[dsBtnDisabled]="disabled"
(click)="toggleUp()"
title="{{'form.number-picker.increment' | translate: {field: placeholder} }}"
[attr.aria-label]="'form.number-picker.increment' | translate: {field: placeholder}">
title="{{'form.number-picker.increment' | translate: {field: ('form.number-picker.label.' + placeholder | translate)} }}"
[attr.aria-label]="'form.number-picker.increment' | translate: {field: ('form.number-picker.label.' + placeholder | translate)}">
<span class="chevron"></span>
<span class="sr-only">{{'form.number-picker.increment' | translate: {field: name} }}</span>
</button>
Expand Down Expand Up @@ -36,8 +36,8 @@
tabindex="0"
[dsBtnDisabled]="disabled"
(click)="toggleDown()"
title="{{'form.number-picker.decrement' | translate: {field: placeholder} }}"
[attr.aria-label]="'form.number-picker.decrement' | translate: {field: placeholder}">
title="{{'form.number-picker.decrement' | translate: {field: ('form.number-picker.label.' + placeholder | translate)} }}"
[attr.aria-label]="'form.number-picker.decrement' | translate: {field: ('form.number-picker.label.' + placeholder | translate)}">
<span class="chevron bottom"></span>
<span class="sr-only">{{'form.number-picker.decrement' | translate: {field: name} }}</span>
</button>
Expand Down
9 changes: 3 additions & 6 deletions src/assets/i18n/hu.json5
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3429,16 +3429,13 @@
"form.number-picker.increment": "{{field}} növelése",

// "form.number-picker.label.Year": "Year",
// TODO New key - Add a translation
"form.number-picker.label.Year": "Year",
"form.number-picker.label.Year": "Év",
Copy link
Copy Markdown
Member

@tdonohue tdonohue May 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should also be lowercased to match the en.json5 file. So this should be form.number-picker.label.year


// "form.number-picker.label.Month": "Month",
// TODO New key - Add a translation
"form.number-picker.label.Month": "Month",
"form.number-picker.label.Month": "Hónap",

// "form.number-picker.label.Day": "Day",
// TODO New key - Add a translation
"form.number-picker.label.Day": "Day",
"form.number-picker.label.Day": "Nap",

// "form.repeatable.sort.tip": "Drop the item in the new position",
"form.repeatable.sort.tip": "Húzza az elemet az új pozícióba.",
Expand Down
Loading