-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed laborHours Calculations #203
base: dev
Are you sure you want to change the base?
Conversation
Signed-off-by: Sachin Panayil <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is on the right track but I think we should be more specific in what we exclude.
scc supports adding a .sccignore
file in the same way that .gitignore
works: https://github.com/boyter/scc?tab=readme-ov-file#ignore-files
Preferably, we would exclude all changes before a specific commit or something but I don't think that that is supported by scc.
@IsaacMilarky one of my approaches was to use the .sccignore file but for some reason the laborHours value wasnt changing. I will take another crack at it tho using .sccignore incase i used it improperly. if the above issue persists then maybe we can have an array of files we want to exclude and pipe that into the command with the current method |
That's fair if the |
Signed-off-by: Sachin Panayil <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use the --exclude-file
option instead of the --exclude-ext
option? That way we won't exclude all of the additional docs work a project is doing. It's good to know if a project is providing docs and analyze the work in that.
If there are problems with that option we can talk about it more this week.
Signed-off-by: Sachin Panayil <[email protected]>
this new method reduces laborHour bloat significantly |
Fixed laborHours Calculations
Problem
Overall, labor_hour value is pretty high because it is taking into account the markdown files. We would like to exclude this from the calculation.
Solution
Included a flag in the scc command that excludes md files.
Result
A decrease in laborHours
Before
After
Some important notes regarding the summary line:
Test Plan
Tested locally and each tier showed a decrease in labor hours