Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add example for inspection of picture content #624

Merged
merged 5 commits into from
Jan 29, 2025

Conversation

cau-git
Copy link
Contributor

@cau-git cau-git commented Dec 18, 2024

Checklist:

  • Documentation has been updated, if necessary.
  • Examples have been added, if necessary.
  • Tests have been added, if necessary.

Copy link

mergify bot commented Dec 18, 2024

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🟢 Enforce conventional commit

Wonderful, this rule succeeded.

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert)(?:\(.+\))?(!)?:

🟢 Require two reviewer for test updates

Wonderful, this rule succeeded.

When test data is updated, we require two reviewers

  • #approved-reviews-by >= 2

PeterStaar-IBM
PeterStaar-IBM previously approved these changes Dec 19, 2024
dolfim-ibm
dolfim-ibm previously approved these changes Jan 6, 2025
@cau-git
Copy link
Contributor Author

cau-git commented Jan 20, 2025

All mended now.

@dolfim-ibm
Copy link
Contributor

Differences in the test files are found in

  1. tiny diff for bbox, e.g. 143.63768005371094 vs 143.63763427734375
  2. tiny diff in the confidence of layout cluster predictions

@dolfim-ibm dolfim-ibm changed the title chore: Add example for inspection of picture content docs: Add example for inspection of picture content Jan 29, 2025
Copy link
Contributor

@PeterStaar-IBM PeterStaar-IBM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@dolfim-ibm dolfim-ibm merged commit f9144f2 into main Jan 29, 2025
9 checks passed
@dolfim-ibm dolfim-ibm deleted the cau/picture-content-example branch January 29, 2025 09:39
vancura pushed a commit to vancura/docling that referenced this pull request Feb 6, 2025
* chore: Add example for inspection of picture content

Signed-off-by: Christoph Auer <[email protected]>

* fix: Test case re-generation

Signed-off-by: Christoph Auer <[email protected]>

* fix: Test case re-generation only on CPU

Signed-off-by: Christoph Auer <[email protected]>

* fix: Add missing GT files

Signed-off-by: Christoph Auer <[email protected]>

---------

Signed-off-by: Christoph Auer <[email protected]>
Signed-off-by: Václav Vančura <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants