feat(OCR): Introduce the OcrOptions.force_full_page_ocr parameter that forces a full page OCR scanning #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t forces a full page OCR scanning and uses the recognized OCR cells instead of any existing PDF cells. Update unit tests. Signed-off-by: Nikos Livathinos <[email protected]>
Signed-off-by: Nikos Livathinos <[email protected]>
nikos-livathinos
requested review from
PeterStaar-IBM,
cau-git and
dolfim-ibm
dolfim-ibm
reviewed
Nov 10, 2024
docs/examples/full_page_ocr.py
Outdated
| format_options={ | ||
| InputFormat.PDF: PdfFormatOption( | ||
| pipeline_options=pipeline_options, | ||
| backend=DoclingParseDocumentBackend, |
There was a problem hiding this comment.
I would remove the hard-coded backend, since it is an example about OCR.
maxmnemonic
previously approved these changes
Nov 11, 2024
|
@nikos-livathinos Maybe, let's add a cli parameter to enforce-ocr. |
…ull_page_ocr.py example in mkdocs Signed-off-by: Nikos Livathinos <[email protected]>
nikos-livathinos
dismissed stale reviews from maxmnemonic and PeterStaar-IBM
via
7234dc3
cau-git
reviewed
Nov 11, 2024
Signed-off-by: Nikos Livathinos <[email protected]>
cau-git
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In certain occasions the user may want to force a full page OCR and ignore the text contained in a programmatic PDF (see issue #185).
This PR introduces the parameter
OcrOptions.force_full_page_ocrthat implements this feature.Please check this example that demonstrates how to force OCR: https://github.com/DS4SD/docling/blob/force_ocr/docs/examples/full_page_ocr.py
Issue resolved by this Pull Request:
Resolves #185
Checklist:
conventional commits.