Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: move autoflake to dev dependencies #86

Merged
merged 3 commits into from
Jan 21, 2025
Merged

Conversation

hadim
Copy link
Contributor

@hadim hadim commented Jan 17, 2025

No description provided.

@hadim
Copy link
Contributor Author

hadim commented Jan 17, 2025

Fix #84

Copy link

mergify bot commented Jan 17, 2025

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🟢 Enforce conventional commit

Wonderful, this rule succeeded.

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert)(?:\(.+\))?:

@hadim hadim changed the title move autoflake to dev dependencies fix: move autoflake to dev dependencies Jan 17, 2025
dolfim-ibm
dolfim-ibm previously approved these changes Jan 20, 2025
@dolfim-ibm
Copy link
Contributor

@hadim note that when touching the pyproject.toml file, you also have to run something like poetry lock --no-update for updating the lock file.

@hadim
Copy link
Contributor Author

hadim commented Jan 20, 2025

@dolfim-ibm I also removed the entrypoint (which is missing from the source code) as said at #85

hadim and others added 3 commits January 20, 2025 10:27
Signed-off-by: Hadrien Mary <[email protected]>
Signed-off-by: Hadrien Mary <[email protected]>
Signed-off-by: Hadrien Mary <[email protected]>
fix Broken CLI DS4SD#85

Signed-off-by: Hadrien Mary <[email protected]>
@hadim
Copy link
Contributor Author

hadim commented Jan 20, 2025

It seems like your CI is compiling external libs such as jpeg and qpdf which takes a lot of time.

Maybe you should consider relying on the conda-forge deps for jpeg, qpdf and others instead in order to speedup the CI duration?

@dolfim-ibm
Copy link
Contributor

Maybe you should consider relying on the conda-forge deps for jpeg, qpdf and others instead in order to speedup the CI duration?

The actual long time is the cross-compilation for linux-arm64. For building the distribution wheels at the moment we require the static libraries of the dependencies, which I think are not available in the coda packages.

@dolfim-ibm dolfim-ibm merged commit eed5080 into DS4SD:main Jan 21, 2025
30 checks passed
@hadim hadim deleted the patch-1 branch January 21, 2025 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants