Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update for complex fonts, rendering, and experimental high-level API #82

Merged
merged 25 commits into from
Jan 17, 2025

Conversation

PeterStaar-IBM
Copy link
Contributor

No description provided.

Copy link

mergify bot commented Jan 11, 2025

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🟢 Enforce conventional commit

Wonderful, this rule succeeded.

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert)(?:\(.+\))?:

@cau-git
Copy link
Contributor

cau-git commented Jan 13, 2025

I checked this with most of the known examples, and it appears to work much better!

However, there are other cases left where the output is still bad, I collected these below:

  1. EL00820224CPARE.PDF - some text decodes with weird chars, e.g. Leilªo Pœblico instead of Leilão Público (expected), or Alienaçªo FiduciÆria instead of Alienação Fiduciária (expected). Note: pypdfium and Adobe Acrobat extract this correctly.
  2. glyph_text.pdf - only glyph symbols are printed, in this form: /G42/G79/G82/G69/G68/.... Note: Adobe Acrobat fails at this too.
  3. 050216e467d363616161fb79e2bfaa3e.pdf - many parts are glyphs, in a different form with pointy brackets and between char garbage: *OREDOLVLHUXQJGLYPH<3>LQGLYPH<3>GHUGLYPH<3>6SHLVHNDPPHU %DQGGLYPH<3>GLYPH<20>GLYPH<29>. Note: Adobe Acrobat fails at this too.

PeterStaar-IBM and others added 18 commits January 13, 2025 17:49
Signed-off-by: Peter Staar <[email protected]>
Signed-off-by: Peter Staar <[email protected]>
Signed-off-by: Peter Staar <[email protected]>
Signed-off-by: Peter Staar <[email protected]>
Signed-off-by: Peter Staar <[email protected]>
Signed-off-by: Peter Staar <[email protected]>
Signed-off-by: Christoph Auer <[email protected]>
@cau-git cau-git changed the title Update for complex fonts feat: Update for complex fonts, rendering, and experimental high-level API Jan 17, 2025
cau-git
cau-git previously approved these changes Jan 17, 2025
@cau-git
Copy link
Contributor

cau-git commented Jan 17, 2025

We discovered one regression: Some cells come out with zero-height now.

Signed-off-by: Christoph Auer <[email protected]>
@cau-git cau-git self-requested a review January 17, 2025 16:13
@cau-git cau-git merged commit 525ed8e into main Jan 17, 2025
33 checks passed
@cau-git cau-git deleted the dev/add-support-for-complex-fonts branch January 17, 2025 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants