-
Notifications
You must be signed in to change notification settings - Fork 153
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Submitting the review
|
@iperdomo according to the Jellow AAC app team the Google dependencies are mostly secondary services and not part of the core app features as stated below. The crucial point would be to establish whether or not replacing the Google dependencies with open source alternatives would require almost a complete rewrite of the code base in terms of effort.
|
@nathanbaleeta I did find a required closed dependency, Google Text-to-Speech (TTS) service. The Android device where I tested didn't have the package com.google.android.tts. You get prompted to install it and if you refuse then the app invites the user to exit. |
@iperdomo The Jellow AAC Communicator team have recently tried Hear2read, an open source TTS engine available for the Indian language, however it offers degraded performance especially for indian voices hence less satisfactory. I have updated the submission to reflect the key points taken from the rich and helpful discussion on this thread as recorded in commit 6fcd3e2 |
@nathanbaleeta I'm a bit confused on the fact that the project is marked as Platform Independent but is not. I understand the arguments about better performance of Google TTS over open source like Hear2read, but the fact is that the project depends on closed source components is still true. |
@iperdomo I have reached out to Jellow AAC team and advised them on using generic software interfaces that provide domains and allow different classes to implement the above interfaces and encapsulate specific details therein hence make the code reusable and more platform agnostic/ independent. I will revert once we hear from the team. Thanks. |
Automatic addition of a new digital public good submitted through the online form available at https://digitalpublicgoods.net/submission