Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes the review workflow to a mermaid diagram #192

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

omahane
Copy link
Contributor

@omahane omahane commented Oct 24, 2024

I was working on a session proposal for DrupalCon 2025 about Digital Public Goods when I looked at this repository of the Standard. I thought it might be worth changing the flowchart to use a generated diagram from text, rather than an image.

Changes proposed in this pull request:

  • The flowchart that describes the submission workflow changes from an image to text, using the mermaid to leverage the Github rendering of the image. This makes the workflow more accessible, easier to change, easier to track across any future changes and more in line with the use of open source technologies.
  • To make it easier to review, you can see the README.md in the PR branch of my fork: https://github.com/omahane/DPG-Standard/tree/diagram-change-to-mermaid

Propagation of Changes

Identify where of the following the proposed changes need to be propagated, and include the relevant pull request where appropriate:

Copy link

@kjetilk kjetilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to say that I support the use of mermaid diagrams, since it allows for version control and patching of the diagram itself. And it renders well.

@ricardomiron ricardomiron self-requested a review October 30, 2024 15:18
Copy link
Collaborator

@ricardomiron ricardomiron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, this looks great!

@ricardomiron ricardomiron merged commit 7e55586 into DPGAlliance:main Oct 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants