New defaults #733
New defaults #733
Conversation
ldecicco-USGS
had a problem deploying
to
github-pages
GitHub Actions
Failure
|
@lstanish-usgs and @ehinman take a look and let me know if you have any comments. |
ldecicco-USGS
had a problem deploying
to
github-pages
GitHub Actions
Failure
R/constructNWISURL.R
Outdated
| @@ -319,7 +319,8 @@ constructNWISURL <- function(siteNumbers, | |||
| #' retrieval for the earliest possible record. | |||
| #' @param endDate character ending date for data retrieval in the form YYYY-MM-DD. Default is "" which indicates | |||
| #' retrieval for the latest possible record. | |||
| #' @param legacy Logical. If TRUE, uses legacy WQP services. Default is FALSE. | |||
| #' @param legacy Logical. If TRUE, use legacy WQP services. Default is TRUE. | |||
There was a problem hiding this comment.
| #' @param legacy Logical. If TRUE, use legacy WQP services. Default is TRUE. | |
| #' @param legacy Logical. If TRUE, uses legacy WQP services. If FALSE, uses WQX3.0 WQP services. Default is TRUE. |
There was a problem hiding this comment.
Or maybe you don't want to offer that at this point.
There was a problem hiding this comment.
That text is basically in the next line. I do think changing from use to uses sounds better though.
R/readWQPqw.R
Outdated
| @@ -33,7 +33,8 @@ | |||
| #' numerics based on a standard algorithm. If false, everything is returned as a character. | |||
| #' @param ignore_attributes logical to choose to ignore fetching site and parameter | |||
| #' attributes. Default is \code{FALSE}. | |||
| #' @param legacy Logical. If TRUE, use legacy WQP services. Default is FALSE. | |||
| #' @param legacy Logical. If TRUE, use legacy WQP services. Default is TRUE. | |||
| #' Setting legacy = FALSE uses WQX3 services, which are in-development, use with caution. | |||
There was a problem hiding this comment.
Oh, I like this message here. But I see. This one is much more visible than the constructNWISURL() function.
| if(legacy){ | ||
| wqp_message() | ||
| } else { | ||
| wqp_message_beta |
There was a problem hiding this comment.
Does this one need wqp_message_beta()?
| baseURL <- drURL("Activity", arg.list = values) | ||
| } else { | ||
| baseURL <- drURL("ActivityWQX3", arg.list = values) | ||
| } |
There was a problem hiding this comment.
So in the development version, this function only performed WQX3.0 calls, but this version adds in the choice?
| j=d.createElement(s),dl=l!='dataLayer'?'&l='+l:'';j.async=true;j.src= | ||
| 'https://www.googletagmanager.com/gtm.js?id='+i+dl;f.parentNode.insertBefore(j,f); | ||
| })(window,document,'script','dataLayer','GTM-TKQR8KP');</script> | ||
| <!-- End Google Tag Manager --> |
There was a problem hiding this comment.
Does the new page still have google tags? Having trouble locating in the changed text
There was a problem hiding this comment.
I added that tag stuff to a new file which is injected into the header. Locally when I build the pkgdown site with the new code it's in there. Once we merge this PR, we can double-check that everything's working as expected on both GitHub and GitLab pages.
ldecicco-USGS
had a problem deploying
to
github-pages
GitHub Actions
Failure
… the navbar white
ldecicco-USGS
had a problem deploying
to
github-pages
GitHub Actions
Failure
ldecicco-USGS
had a problem deploying
to
github-pages
GitHub Actions
Failure
defaults to legacy - so shouldn't break anyone's code. But DOES offer users the chance to use the new services.