Skip to content

Commit

Permalink
Merge pull request #726 from ldecicco-USGS/fix_agency
Browse files Browse the repository at this point in the history
thought this was a requirement, but isn't...
  • Loading branch information
ldecicco-USGS authored Aug 21, 2024
2 parents a5c9729 + fa45738 commit 26b9265
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 11 deletions.
1 change: 0 additions & 1 deletion R/constructNWISURL.R
Original file line number Diff line number Diff line change
Expand Up @@ -242,7 +242,6 @@ constructNWISURL <- function(siteNumbers,

url <- appendDrURL(baseURL,
site_no = siteNumbers,
agency_cd = "USGS",
format = "rdb"
)
if (nzchar(startDate)) {
Expand Down
10 changes: 0 additions & 10 deletions tests/testthat/tests_imports.R
Original file line number Diff line number Diff line change
Expand Up @@ -235,16 +235,6 @@ test_that("importWaterML2 internal test", {
expect_is(UserData$value, "numeric")
})

test_that("importWaterML2 external test", {
testthat::skip_on_cran()
url <- "https://waterservices.usgs.gov/nwis/iv/?format=waterml,2.0&sites=01646500&parameterCd=00060,00065"
xml <- getWebServiceData(url)
measurementTS2 <- xml2::xml_find_all(xml, "//wml2:MeasurementTimeseries")
exData <- importWaterML2(measurementTS2)
expect_is(exData$value, "numeric")
expect_gt(nrow(exData), 0)
})


context("importWQP_noCRAN")

Expand Down

0 comments on commit 26b9265

Please sign in to comment.