replaced custom min/max with std::max/std::min #5490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acpaquette
reviewed
Apr 30, 2024
isis/src/base/objs/Cube/Cube.h
Outdated
| @@ -451,7 +451,6 @@ namespace Isis { | |||
|
|
|||
| //! If allocated, converts from physical on-disk band # to virtual band # | |||
| QList<int> *m_virtualBandList; | |||
| }; | |||
There was a problem hiding this comment.
This broke building ISIS
|
Like Adam mentioned a few months ago. Build is broken: |
|
DefaultCube.FunctionalTestNoprojExpand and isis_unit_test_NaifDskShape are failing, I'll take a look at these |
|
isis_unit_test_NaifDskShape is failing on dev too, seems related to the egos segfault issue? DefaultCube.FunctionalTestNoprojExpand passes locally (probably a Mac thing) but also fails on dev. So I think tests are good rn. |
amystamile-usgs
approved these changes
Jul 23, 2024
acpaquette
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replacing many custom MIN/MAX functions with std library versions.
Related Issue
no related issue. Needed to make these changes as part of adding GDAL support for cubes. Got a bunch of errors after adding the GDAL dependency.
How Has This Been Validated?
Still need to run tests locally.
Types of changes
Checklist:
Licensing
This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words: